Re: [RFC PATCH 2/2] lightnvm: add non-continuous lun target creation support

2016-01-21 Thread Matias Bjørling
On 01/21/2016 02:58 PM, Wenwei Tao wrote: 2016-01-21 17:49 GMT+08:00 Matias Bjørling : On 01/21/2016 10:47 AM, Wenwei Tao wrote: Currently a bitmap of luns already added into nvm_dev, every time we map the luns we check the bitmap. I don't quite understand why we need to add another bitmap?

Re: [RFC PATCH 2/2] lightnvm: add non-continuous lun target creation support

2016-01-21 Thread Wenwei Tao
2016-01-21 17:49 GMT+08:00 Matias Bjørling : > On 01/21/2016 10:47 AM, Wenwei Tao wrote: > >> >> Currently a bitmap of luns already added into nvm_dev, every time we >> map the luns we check the bitmap. >> I don't quite understand why we need to add another bitmap? > > We can definitely use

Re: [RFC PATCH 2/2] lightnvm: add non-continuous lun target creation support

2016-01-21 Thread Matias Bjørling
On 01/21/2016 10:47 AM, Wenwei Tao wrote: > > Currently a bitmap of luns already added into nvm_dev, every time we > map the luns we check the bitmap. > I don't quite understand why we need to add another bitmap? We can definitely use lun_map that you introduced in the patch.

Re: [RFC PATCH 2/2] lightnvm: add non-continuous lun target creation support

2016-01-21 Thread Wenwei Tao
2016-01-21 15:53 GMT+08:00 Matias Bjørling : > On 01/21/2016 08:44 AM, Wenwei Tao wrote: >> 2016-01-20 21:19 GMT+08:00 Matias Bjørling : >>> On 01/15/2016 12:44 PM, Wenwei Tao wrote: When create a target, we specify the begin lunid and the end lunid, and get the corresponding continuous

Re: [RFC PATCH 2/2] lightnvm: add non-continuous lun target creation support

2016-01-21 Thread Wenwei Tao
2016-01-21 17:49 GMT+08:00 Matias Bjørling : > On 01/21/2016 10:47 AM, Wenwei Tao wrote: > >> >> Currently a bitmap of luns already added into nvm_dev, every time we >> map the luns we check the bitmap. >> I don't quite understand why we need to add another bitmap? > > We can

Re: [RFC PATCH 2/2] lightnvm: add non-continuous lun target creation support

2016-01-21 Thread Matias Bjørling
On 01/21/2016 10:47 AM, Wenwei Tao wrote: > > Currently a bitmap of luns already added into nvm_dev, every time we > map the luns we check the bitmap. > I don't quite understand why we need to add another bitmap? We can definitely use lun_map that you introduced in the patch.

Re: [RFC PATCH 2/2] lightnvm: add non-continuous lun target creation support

2016-01-21 Thread Wenwei Tao
2016-01-21 15:53 GMT+08:00 Matias Bjørling : > On 01/21/2016 08:44 AM, Wenwei Tao wrote: >> 2016-01-20 21:19 GMT+08:00 Matias Bjørling : >>> On 01/15/2016 12:44 PM, Wenwei Tao wrote: When create a target, we specify the begin lunid and the end lunid,

Re: [RFC PATCH 2/2] lightnvm: add non-continuous lun target creation support

2016-01-21 Thread Matias Bjørling
On 01/21/2016 02:58 PM, Wenwei Tao wrote: 2016-01-21 17:49 GMT+08:00 Matias Bjørling : On 01/21/2016 10:47 AM, Wenwei Tao wrote: Currently a bitmap of luns already added into nvm_dev, every time we map the luns we check the bitmap. I don't quite understand why we need to

Re: [RFC PATCH 2/2] lightnvm: add non-continuous lun target creation support

2016-01-20 Thread Matias Bjørling
On 01/21/2016 08:44 AM, Wenwei Tao wrote: > 2016-01-20 21:19 GMT+08:00 Matias Bjørling : >> On 01/15/2016 12:44 PM, Wenwei Tao wrote: >>> When create a target, we specify the begin lunid and >>> the end lunid, and get the corresponding continuous >>> luns from media manager, if one of the luns is

Re: [RFC PATCH 2/2] lightnvm: add non-continuous lun target creation support

2016-01-20 Thread Wenwei Tao
2016-01-20 21:19 GMT+08:00 Matias Bjørling : > On 01/15/2016 12:44 PM, Wenwei Tao wrote: >> When create a target, we specify the begin lunid and >> the end lunid, and get the corresponding continuous >> luns from media manager, if one of the luns is not free, >> we failed to create the target,

Re: [RFC PATCH 2/2] lightnvm: add non-continuous lun target creation support

2016-01-20 Thread Matias Bjørling
On 01/21/2016 08:44 AM, Wenwei Tao wrote: > 2016-01-20 21:19 GMT+08:00 Matias Bjørling : >> On 01/15/2016 12:44 PM, Wenwei Tao wrote: >>> When create a target, we specify the begin lunid and >>> the end lunid, and get the corresponding continuous >>> luns from media manager, if

Re: [RFC PATCH 2/2] lightnvm: add non-continuous lun target creation support

2016-01-20 Thread Wenwei Tao
2016-01-20 21:19 GMT+08:00 Matias Bjørling : > On 01/15/2016 12:44 PM, Wenwei Tao wrote: >> When create a target, we specify the begin lunid and >> the end lunid, and get the corresponding continuous >> luns from media manager, if one of the luns is not free, >> we failed to