Re: [RFC PATCH 2/2] rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq()

2016-07-05 Thread pankaj.dubey
Hi Alim, On Tuesday 05 July 2016 02:22 PM, Alim Akhtar wrote: > > > On 07/05/2016 01:46 PM, Krzysztof Kozlowski wrote: >> On 07/04/2016 01:03 PM, Alim Akhtar wrote: >>> As per code flow it is possible that s3c_rtc_setfreq() might get called >>> with rtc clock disabled and in set_freq we perform

Re: [RFC PATCH 2/2] rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq()

2016-07-05 Thread pankaj.dubey
Hi Alim, On Tuesday 05 July 2016 02:22 PM, Alim Akhtar wrote: > > > On 07/05/2016 01:46 PM, Krzysztof Kozlowski wrote: >> On 07/04/2016 01:03 PM, Alim Akhtar wrote: >>> As per code flow it is possible that s3c_rtc_setfreq() might get called >>> with rtc clock disabled and in set_freq we perform

Re: [RFC PATCH 2/2] rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq()

2016-07-05 Thread pankaj.dubey
Hi Alim, On Tuesday 05 July 2016 02:26 PM, Krzysztof Kozlowski wrote: > On 07/05/2016 10:52 AM, Alim Akhtar wrote: >> >> >> On 07/05/2016 01:46 PM, Krzysztof Kozlowski wrote: >>> On 07/04/2016 01:03 PM, Alim Akhtar wrote: As per code flow it is possible that s3c_rtc_setfreq() might get

Re: [RFC PATCH 2/2] rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq()

2016-07-05 Thread pankaj.dubey
Hi Alim, On Tuesday 05 July 2016 02:26 PM, Krzysztof Kozlowski wrote: > On 07/05/2016 10:52 AM, Alim Akhtar wrote: >> >> >> On 07/05/2016 01:46 PM, Krzysztof Kozlowski wrote: >>> On 07/04/2016 01:03 PM, Alim Akhtar wrote: As per code flow it is possible that s3c_rtc_setfreq() might get

Re: [RFC PATCH 2/2] rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq()

2016-07-05 Thread Krzysztof Kozlowski
On 07/05/2016 10:52 AM, Alim Akhtar wrote: > > > On 07/05/2016 01:46 PM, Krzysztof Kozlowski wrote: >> On 07/04/2016 01:03 PM, Alim Akhtar wrote: >>> As per code flow it is possible that s3c_rtc_setfreq() might get called >>> with rtc clock disabled and in set_freq we perform h/w registers >>>

Re: [RFC PATCH 2/2] rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq()

2016-07-05 Thread Krzysztof Kozlowski
On 07/05/2016 10:52 AM, Alim Akhtar wrote: > > > On 07/05/2016 01:46 PM, Krzysztof Kozlowski wrote: >> On 07/04/2016 01:03 PM, Alim Akhtar wrote: >>> As per code flow it is possible that s3c_rtc_setfreq() might get called >>> with rtc clock disabled and in set_freq we perform h/w registers >>>

Re: [RFC PATCH 2/2] rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq()

2016-07-05 Thread Alim Akhtar
On 07/05/2016 01:46 PM, Krzysztof Kozlowski wrote: On 07/04/2016 01:03 PM, Alim Akhtar wrote: As per code flow it is possible that s3c_rtc_setfreq() might get called with rtc clock disabled and in set_freq we perform h/w registers read/write, which might results in a kernel crash while

Re: [RFC PATCH 2/2] rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq()

2016-07-05 Thread Alim Akhtar
On 07/05/2016 01:46 PM, Krzysztof Kozlowski wrote: On 07/04/2016 01:03 PM, Alim Akhtar wrote: As per code flow it is possible that s3c_rtc_setfreq() might get called with rtc clock disabled and in set_freq we perform h/w registers read/write, which might results in a kernel crash while

Re: [RFC PATCH 2/2] rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq()

2016-07-05 Thread Krzysztof Kozlowski
On 07/04/2016 01:03 PM, Alim Akhtar wrote: > As per code flow it is possible that s3c_rtc_setfreq() might get called > with rtc clock disabled and in set_freq we perform h/w registers read/write, > which might results in a kernel crash while probing rtc driver. > Below is one such case: >

Re: [RFC PATCH 2/2] rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq()

2016-07-05 Thread Krzysztof Kozlowski
On 07/04/2016 01:03 PM, Alim Akhtar wrote: > As per code flow it is possible that s3c_rtc_setfreq() might get called > with rtc clock disabled and in set_freq we perform h/w registers read/write, > which might results in a kernel crash while probing rtc driver. > Below is one such case: >

[RFC PATCH 2/2] rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq()

2016-07-04 Thread Alim Akhtar
As per code flow it is possible that s3c_rtc_setfreq() might get called with rtc clock disabled and in set_freq we perform h/w registers read/write, which might results in a kernel crash while probing rtc driver. Below is one such case: s3c_rtc_probe() clk_prepare_enable(info->rtc_clk) // rtc

[RFC PATCH 2/2] rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq()

2016-07-04 Thread Alim Akhtar
As per code flow it is possible that s3c_rtc_setfreq() might get called with rtc clock disabled and in set_freq we perform h/w registers read/write, which might results in a kernel crash while probing rtc driver. Below is one such case: s3c_rtc_probe() clk_prepare_enable(info->rtc_clk) // rtc