Re: [RFC PATCH 2/2] tracing: Teach FETCH_MTD_symbol to handle per-cpu data

2013-11-27 Thread Masami Hiramatsu
(2013/11/27 2:44), Oleg Nesterov wrote: > FETCH_FUNC_NAME(symbol) blindly dereferences sc->addr + sc->offset, > this is not what we want if this symbol is per-cpu. Change this code > to use this_cpu_ptr(sc->addr) in this case. This looks good for me :) Thanks! > Note: this doesn't work for modul

[RFC PATCH 2/2] tracing: Teach FETCH_MTD_symbol to handle per-cpu data

2013-11-26 Thread Oleg Nesterov
FETCH_FUNC_NAME(symbol) blindly dereferences sc->addr + sc->offset, this is not what we want if this symbol is per-cpu. Change this code to use this_cpu_ptr(sc->addr) in this case. Note: this doesn't work for modules, but module's per-cpu data is not visible for kallsyms_lookup_name() anyway. Sig