Re: [RFC PATCH 2/3] arm64: dts: APM X-Gene PCIe device tree nodes

2014-01-09 Thread Tanmay Inamdar
On Tue, Jan 7, 2014 at 9:27 AM, Jason Gunthorpe wrote: > On Mon, Jan 06, 2014 at 06:56:21PM -0800, Tanmay Inamdar wrote: > >> > There is some kind of an addressing problem because you've done this: >> > >> > +static void xgene_pcie_fixup_bridge(struct pci_dev *dev) >> > +{ >> > + int i; >> >

Re: [RFC PATCH 2/3] arm64: dts: APM X-Gene PCIe device tree nodes

2014-01-07 Thread Jason Gunthorpe
On Mon, Jan 06, 2014 at 06:56:21PM -0800, Tanmay Inamdar wrote: > > There is some kind of an addressing problem because you've done this: > > > > +static void xgene_pcie_fixup_bridge(struct pci_dev *dev) > > +{ > > + int i; > > + > > + for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) { > >

Re: [RFC PATCH 2/3] arm64: dts: APM X-Gene PCIe device tree nodes

2014-01-06 Thread Tanmay Inamdar
On Thu, Jan 2, 2014 at 4:52 PM, Jason Gunthorpe wrote: > On Thu, Jan 02, 2014 at 01:56:51PM -0800, Tanmay Inamdar wrote: >> On Mon, Dec 23, 2013 at 9:46 AM, Jason Gunthorpe >> wrote: >> > On Mon, Dec 23, 2013 at 01:32:03PM +0530, Tanmay Inamdar wrote: >> >> This patch adds the device tree nodes f

Re: [RFC PATCH 2/3] arm64: dts: APM X-Gene PCIe device tree nodes

2014-01-02 Thread Jason Gunthorpe
On Thu, Jan 02, 2014 at 01:56:51PM -0800, Tanmay Inamdar wrote: > On Mon, Dec 23, 2013 at 9:46 AM, Jason Gunthorpe > wrote: > > On Mon, Dec 23, 2013 at 01:32:03PM +0530, Tanmay Inamdar wrote: > >> This patch adds the device tree nodes for APM X-Gene PCIe controller and > >> PCIe clock interface. S

Re: [RFC PATCH 2/3] arm64: dts: APM X-Gene PCIe device tree nodes

2014-01-02 Thread Tanmay Inamdar
On Mon, Dec 23, 2013 at 9:46 AM, Jason Gunthorpe wrote: > On Mon, Dec 23, 2013 at 01:32:03PM +0530, Tanmay Inamdar wrote: >> This patch adds the device tree nodes for APM X-Gene PCIe controller and >> PCIe clock interface. Since X-Gene SOC supports maximum 5 ports, 5 dts nodes >> are added. > > Ca

Re: [RFC PATCH 2/3] arm64: dts: APM X-Gene PCIe device tree nodes

2013-12-23 Thread Jason Gunthorpe
On Mon, Dec 23, 2013 at 01:32:03PM +0530, Tanmay Inamdar wrote: > This patch adds the device tree nodes for APM X-Gene PCIe controller and > PCIe clock interface. Since X-Gene SOC supports maximum 5 ports, 5 dts nodes > are added. Can you include an lspci dump for PCI DT bindings please? It is imp

[RFC PATCH 2/3] arm64: dts: APM X-Gene PCIe device tree nodes

2013-12-23 Thread Tanmay Inamdar
This patch adds the device tree nodes for APM X-Gene PCIe controller and PCIe clock interface. Since X-Gene SOC supports maximum 5 ports, 5 dts nodes are added. Signed-off-by: Tanmay Inamdar --- arch/arm64/boot/dts/apm-mustang.dts |4 + arch/arm64/boot/dts/apm-storm.dtsi | 140