Re: [RFC PATCH 2/3] x86,smp: proportional backoff for ticket spinlocks

2012-12-23 Thread Rafael Aquini
On Fri, Dec 21, 2012 at 06:51:15PM -0500, Rik van Riel wrote: > Subject: x86,smp: proportional backoff for ticket spinlocks > > Simple fixed value proportional backoff for ticket spinlocks. > By pounding on the cacheline with the spin lock less often, > bus traffic is reduced. In cases of a data

Re: [RFC PATCH 2/3] x86,smp: proportional backoff for ticket spinlocks

2012-12-23 Thread Rafael Aquini
On Fri, Dec 21, 2012 at 06:51:15PM -0500, Rik van Riel wrote: Subject: x86,smp: proportional backoff for ticket spinlocks Simple fixed value proportional backoff for ticket spinlocks. By pounding on the cacheline with the spin lock less often, bus traffic is reduced. In cases of a data

Re: [RFC PATCH 2/3] x86,smp: proportional backoff for ticket spinlocks

2012-12-21 Thread Michel Lespinasse
On Fri, Dec 21, 2012 at 3:51 PM, Rik van Riel wrote: > Subject: x86,smp: proportional backoff for ticket spinlocks > > Simple fixed value proportional backoff for ticket spinlocks. > By pounding on the cacheline with the spin lock less often, > bus traffic is reduced. In cases of a data structure

Re: [RFC PATCH 2/3] x86,smp: proportional backoff for ticket spinlocks

2012-12-21 Thread Rik van Riel
On 12/21/2012 10:14 PM, Steven Rostedt wrote: OK, I replied here before reading patch 3 (still reviewing it). Why have this patch at all? Just to test if you broke something between this and patch 3? Or perhaps patch 3 may not get accepted? In that case, you would still need a comment. Either

Re: [RFC PATCH 2/3] x86,smp: proportional backoff for ticket spinlocks

2012-12-21 Thread Steven Rostedt
On Fri, Dec 21, 2012 at 10:07:56PM -0500, Steven Rostedt wrote: > > diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c > > index 20da354..4e44840 100644 > > --- a/arch/x86/kernel/smp.c > > +++ b/arch/x86/kernel/smp.c > > @@ -118,9 +118,11 @@ static bool smp_no_nmi_ipi = false; > > void

Re: [RFC PATCH 2/3] x86,smp: proportional backoff for ticket spinlocks

2012-12-21 Thread Steven Rostedt
On Fri, Dec 21, 2012 at 06:51:15PM -0500, Rik van Riel wrote: > Subject: x86,smp: proportional backoff for ticket spinlocks > > Simple fixed value proportional backoff for ticket spinlocks. > By pounding on the cacheline with the spin lock less often, > bus traffic is reduced. In cases of a data

[RFC PATCH 2/3] x86,smp: proportional backoff for ticket spinlocks

2012-12-21 Thread Rik van Riel
Subject: x86,smp: proportional backoff for ticket spinlocks Simple fixed value proportional backoff for ticket spinlocks. By pounding on the cacheline with the spin lock less often, bus traffic is reduced. In cases of a data structure with embedded spinlock, the lock holder has a better chance of

[RFC PATCH 2/3] x86,smp: proportional backoff for ticket spinlocks

2012-12-21 Thread Rik van Riel
Subject: x86,smp: proportional backoff for ticket spinlocks Simple fixed value proportional backoff for ticket spinlocks. By pounding on the cacheline with the spin lock less often, bus traffic is reduced. In cases of a data structure with embedded spinlock, the lock holder has a better chance of

Re: [RFC PATCH 2/3] x86,smp: proportional backoff for ticket spinlocks

2012-12-21 Thread Steven Rostedt
On Fri, Dec 21, 2012 at 06:51:15PM -0500, Rik van Riel wrote: Subject: x86,smp: proportional backoff for ticket spinlocks Simple fixed value proportional backoff for ticket spinlocks. By pounding on the cacheline with the spin lock less often, bus traffic is reduced. In cases of a data

Re: [RFC PATCH 2/3] x86,smp: proportional backoff for ticket spinlocks

2012-12-21 Thread Steven Rostedt
On Fri, Dec 21, 2012 at 10:07:56PM -0500, Steven Rostedt wrote: diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c index 20da354..4e44840 100644 --- a/arch/x86/kernel/smp.c +++ b/arch/x86/kernel/smp.c @@ -118,9 +118,11 @@ static bool smp_no_nmi_ipi = false; void

Re: [RFC PATCH 2/3] x86,smp: proportional backoff for ticket spinlocks

2012-12-21 Thread Rik van Riel
On 12/21/2012 10:14 PM, Steven Rostedt wrote: OK, I replied here before reading patch 3 (still reviewing it). Why have this patch at all? Just to test if you broke something between this and patch 3? Or perhaps patch 3 may not get accepted? In that case, you would still need a comment. Either

Re: [RFC PATCH 2/3] x86,smp: proportional backoff for ticket spinlocks

2012-12-21 Thread Michel Lespinasse
On Fri, Dec 21, 2012 at 3:51 PM, Rik van Riel r...@redhat.com wrote: Subject: x86,smp: proportional backoff for ticket spinlocks Simple fixed value proportional backoff for ticket spinlocks. By pounding on the cacheline with the spin lock less often, bus traffic is reduced. In cases of a data