Re: [RFC PATCH 2/4] drivers/bus: Freescale Management Complex (fsl-mc) bus driver

2014-08-22 Thread German Rivera
Hi Arnd, I have posted respin v3 of this patch series to address your lastest of comments. Please see below the resolutions. Thanks, German On 08/21/2014 06:30 AM, Arnd Bergmann wrote: On Tuesday 19 August 2014, German Rivera wrote: + * @dev_node: Node in the container's child list Same

Re: [RFC PATCH 2/4] drivers/bus: Freescale Management Complex (fsl-mc) bus driver

2014-08-21 Thread Arnd Bergmann
On Tuesday 19 August 2014, German Rivera wrote: > >> + * @dev_node: Node in the container's child list > > > > Same here: just use the device model's list management instead if you can, > > or explain why this is needed. > > > We still need to keep a per-bus list of child devices (devices contained

Re: [RFC PATCH 2/4] drivers/bus: Freescale Management Complex (fsl-mc) bus driver

2014-08-19 Thread German Rivera
Hi Arnd, Thanks for your comments. My replies inline below. Please let me know if there is anything else, before post a respin of the patch series that addresses your comments. Thanks, German On 08/16/2014 09:12 AM, Arnd Bergmann wrote: On Friday 15 August 2014 17:13:12 J. German Rivera wrote

Re: [RFC PATCH 2/4] drivers/bus: Freescale Management Complex (fsl-mc) bus driver

2014-08-16 Thread Arnd Bergmann
On Friday 15 August 2014 17:13:12 J. German Rivera wrote: > +struct fsl_mc_bus *fsl_mc_bus; > +EXPORT_SYMBOL(fsl_mc_bus); This does not look like something that should be exported. Or even better, kill this structure entirely and just pass around pointers to the fsl_mc_device so you can deal with

Re: [RFC PATCH 2/4] drivers/bus: Freescale Management Complex (fsl-mc) bus driver

2014-08-16 Thread Arnd Bergmann
On Friday 15 August 2014 17:13:12 J. German Rivera wrote: > +struct fsl_mc_bus *fsl_mc_bus; > +EXPORT_SYMBOL(fsl_mc_bus); This does not look like something that should be exported. Or even better, kill this structure entirely and just pass around pointers to the fsl_mc_device so you can deal with

[RFC PATCH 2/4] drivers/bus: Freescale Management Complex (fsl-mc) bus driver

2014-08-15 Thread J. German Rivera
From: "J. German Rivera" Platform device driver that sets up the basic bus infrastructure for the fsl-mc bus type, including support for adding/removing fsl-mc devices, register/unregister of fsl-mc drivers, and bus match support to bind devices to drivers. Signed-off-by: J. German Rivera ---

[RFC PATCH 2/4] drivers/bus: Freescale Management Complex (fsl-mc) bus driver

2014-08-15 Thread J. German Rivera
From: "J. German Rivera" Platform device driver that sets up the basic bus infrastructure for the fsl-mc bus type, including support for adding/removing fsl-mc devices, register/unregister of fsl-mc drivers, and bus match support to bind devices to drivers. Signed-off-by: J. German Rivera ---