Re: [RFC PATCH 2/6] ASoC: Intel: Skylake: stop init/probe if DSP is not present

2018-11-21 Thread Andy Shevchenko
On Wed, Nov 21, 2018 at 10:48:57AM -0600, Pierre-Louis Bossart wrote: > > On 11/21/18 8:29 AM, Andy Shevchenko wrote: > > On Tue, Nov 20, 2018 at 03:36:40PM -0600, Pierre-Louis Bossart wrote: > > > Check immediately if the DSP can be found, bail and avoid doing inits > > > to enable legacy

Re: [RFC PATCH 2/6] ASoC: Intel: Skylake: stop init/probe if DSP is not present

2018-11-21 Thread Andy Shevchenko
On Wed, Nov 21, 2018 at 10:48:57AM -0600, Pierre-Louis Bossart wrote: > > On 11/21/18 8:29 AM, Andy Shevchenko wrote: > > On Tue, Nov 20, 2018 at 03:36:40PM -0600, Pierre-Louis Bossart wrote: > > > Check immediately if the DSP can be found, bail and avoid doing inits > > > to enable legacy

Re: [RFC PATCH 2/6] ASoC: Intel: Skylake: stop init/probe if DSP is not present

2018-11-21 Thread Pierre-Louis Bossart
On 11/21/18 8:29 AM, Andy Shevchenko wrote: On Tue, Nov 20, 2018 at 03:36:40PM -0600, Pierre-Louis Bossart wrote: Check immediately if the DSP can be found, bail and avoid doing inits to enable legacy fallback without delay. It does slightly more than described. Please do either remove

Re: [RFC PATCH 2/6] ASoC: Intel: Skylake: stop init/probe if DSP is not present

2018-11-21 Thread Pierre-Louis Bossart
On 11/21/18 8:29 AM, Andy Shevchenko wrote: On Tue, Nov 20, 2018 at 03:36:40PM -0600, Pierre-Louis Bossart wrote: Check immediately if the DSP can be found, bail and avoid doing inits to enable legacy fallback without delay. It does slightly more than described. Please do either remove

Re: [RFC PATCH 2/6] ASoC: Intel: Skylake: stop init/probe if DSP is not present

2018-11-21 Thread Andy Shevchenko
On Tue, Nov 20, 2018 at 03:36:40PM -0600, Pierre-Louis Bossart wrote: > Check immediately if the DSP can be found, bail and avoid doing inits > to enable legacy fallback without delay. It does slightly more than described. Please do either remove unrelated changes, or fill the gap in the commit

Re: [RFC PATCH 2/6] ASoC: Intel: Skylake: stop init/probe if DSP is not present

2018-11-21 Thread Andy Shevchenko
On Tue, Nov 20, 2018 at 03:36:40PM -0600, Pierre-Louis Bossart wrote: > Check immediately if the DSP can be found, bail and avoid doing inits > to enable legacy fallback without delay. It does slightly more than described. Please do either remove unrelated changes, or fill the gap in the commit

[RFC PATCH 2/6] ASoC: Intel: Skylake: stop init/probe if DSP is not present

2018-11-20 Thread Pierre-Louis Bossart
Check immediately if the DSP can be found, bail and avoid doing inits to enable legacy fallback without delay. Signed-off-by: Pierre-Louis Bossart --- sound/soc/intel/skylake/skl.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git

[RFC PATCH 2/6] ASoC: Intel: Skylake: stop init/probe if DSP is not present

2018-11-20 Thread Pierre-Louis Bossart
Check immediately if the DSP can be found, bail and avoid doing inits to enable legacy fallback without delay. Signed-off-by: Pierre-Louis Bossart --- sound/soc/intel/skylake/skl.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git