Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-16 Thread Mark Brown
On Mon, May 16, 2016 at 02:58:13PM +0200, Takashi Iwai wrote: > Robert Jarzmik wrote: > > Even if I'd like to not have these in bus operations, the struct snd_ac97 > > had a > > need for a 'caps', 'ext_id', ... fields for example. Yet these could be > > contained in the ac97_codec_device

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-16 Thread Mark Brown
On Mon, May 16, 2016 at 02:58:13PM +0200, Takashi Iwai wrote: > Robert Jarzmik wrote: > > Even if I'd like to not have these in bus operations, the struct snd_ac97 > > had a > > need for a 'caps', 'ext_id', ... fields for example. Yet these could be > > contained in the ac97_codec_device

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-16 Thread Takashi Iwai
On Mon, 16 May 2016 10:53:56 +0200, Robert Jarzmik wrote: > > Takashi Iwai writes: > > > On Sun, 15 May 2016 23:29:27 +0200, > > Robert Jarzmik wrote: > >> > >> Takashi Iwai writes: > >> > >> > On Sat, 14 May 2016 11:50:50 +0200, > >> > > >> > No, my concern is

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-16 Thread Takashi Iwai
On Mon, 16 May 2016 10:53:56 +0200, Robert Jarzmik wrote: > > Takashi Iwai writes: > > > On Sun, 15 May 2016 23:29:27 +0200, > > Robert Jarzmik wrote: > >> > >> Takashi Iwai writes: > >> > >> > On Sat, 14 May 2016 11:50:50 +0200, > >> > > >> > No, my concern is that it's creating a dummy

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-16 Thread Robert Jarzmik
Takashi Iwai writes: > On Sun, 15 May 2016 23:29:27 +0200, > Robert Jarzmik wrote: >> >> Takashi Iwai writes: >> >> > On Sat, 14 May 2016 11:50:50 +0200, >> > >> > No, my concern is that it's creating a dummy codec object temporarily >> > on the stack just by

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-16 Thread Robert Jarzmik
Takashi Iwai writes: > On Sun, 15 May 2016 23:29:27 +0200, > Robert Jarzmik wrote: >> >> Takashi Iwai writes: >> >> > On Sat, 14 May 2016 11:50:50 +0200, >> > >> > No, my concern is that it's creating a dummy codec object temporarily >> > on the stack just by copying some fields and calling

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-15 Thread Takashi Iwai
On Sun, 15 May 2016 23:29:27 +0200, Robert Jarzmik wrote: > > Takashi Iwai writes: > > > On Sat, 14 May 2016 11:50:50 +0200, > > Robert Jarzmik wrote: > >> >> +unsigned int ac97_bus_scan_one(struct ac97_controller *ac97, > >> >> + int

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-15 Thread Takashi Iwai
On Sun, 15 May 2016 23:29:27 +0200, Robert Jarzmik wrote: > > Takashi Iwai writes: > > > On Sat, 14 May 2016 11:50:50 +0200, > > Robert Jarzmik wrote: > >> >> +unsigned int ac97_bus_scan_one(struct ac97_controller *ac97, > >> >> + int codec_num) > >> >> +{ >

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-15 Thread Robert Jarzmik
Takashi Iwai writes: > On Sat, 14 May 2016 11:50:50 +0200, > Robert Jarzmik wrote: >> >> +unsigned int ac97_bus_scan_one(struct ac97_controller *ac97, >> >> + int codec_num) >> >> +{ >> >> + struct ac97_codec_device codec; >> >> + unsigned short vid1,

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-15 Thread Robert Jarzmik
Takashi Iwai writes: > On Sat, 14 May 2016 11:50:50 +0200, > Robert Jarzmik wrote: >> >> +unsigned int ac97_bus_scan_one(struct ac97_controller *ac97, >> >> + int codec_num) >> >> +{ >> >> + struct ac97_codec_device codec; >> >> + unsigned short vid1, vid2; >> >> +

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-14 Thread Takashi Iwai
On Sat, 14 May 2016 11:50:50 +0200, Robert Jarzmik wrote: > >> +unsigned int ac97_bus_scan_one(struct ac97_controller *ac97, > >> +int codec_num) > >> +{ > >> + struct ac97_codec_device codec; > >> + unsigned short vid1, vid2; > >> + int ret; > >> + > >> +

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-14 Thread Takashi Iwai
On Sat, 14 May 2016 11:50:50 +0200, Robert Jarzmik wrote: > >> +unsigned int ac97_bus_scan_one(struct ac97_controller *ac97, > >> +int codec_num) > >> +{ > >> + struct ac97_codec_device codec; > >> + unsigned short vid1, vid2; > >> + int ret; > >> + > >> +

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-14 Thread Robert Jarzmik
Takashi Iwai writes: > On Sat, 30 Apr 2016 23:15:34 +0200, > Robert Jarzmik wrote: >> >> diff --git a/include/sound/ac97/codec.h b/include/sound/ac97/codec.h >> new file mode 100644 >> index ..4b8b3e570892 >> --- /dev/null >> +++ b/include/sound/ac97/codec.h >> @@

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-14 Thread Robert Jarzmik
Takashi Iwai writes: > On Sat, 30 Apr 2016 23:15:34 +0200, > Robert Jarzmik wrote: >> >> diff --git a/include/sound/ac97/codec.h b/include/sound/ac97/codec.h >> new file mode 100644 >> index ..4b8b3e570892 >> --- /dev/null >> +++ b/include/sound/ac97/codec.h >> @@ -0,0 +1,98 @@ >>

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-09 Thread Takashi Iwai
On Sat, 30 Apr 2016 23:15:34 +0200, Robert Jarzmik wrote: > > diff --git a/include/sound/ac97/codec.h b/include/sound/ac97/codec.h > new file mode 100644 > index ..4b8b3e570892 > --- /dev/null > +++ b/include/sound/ac97/codec.h > @@ -0,0 +1,98 @@ > +/* > + * Copyright (C) 2016 Robert

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-09 Thread Takashi Iwai
On Sat, 30 Apr 2016 23:15:34 +0200, Robert Jarzmik wrote: > > diff --git a/include/sound/ac97/codec.h b/include/sound/ac97/codec.h > new file mode 100644 > index ..4b8b3e570892 > --- /dev/null > +++ b/include/sound/ac97/codec.h > @@ -0,0 +1,98 @@ > +/* > + * Copyright (C) 2016 Robert

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-05 Thread Robert Jarzmik
Mark Brown writes: > On Tue, May 03, 2016 at 09:43:20PM +0200, Robert Jarzmik wrote: > >> You probably mean the BITCLK clock. > >> What is a bit pesky about this clock is that it can either be mastered by >> digital controller and the codec is a slave, or the other way

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-05 Thread Robert Jarzmik
Mark Brown writes: > On Tue, May 03, 2016 at 09:43:20PM +0200, Robert Jarzmik wrote: > >> You probably mean the BITCLK clock. > >> What is a bit pesky about this clock is that it can either be mastered by >> digital controller and the codec is a slave, or the other way around. > > That's a bit

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-04 Thread Mark Brown
On Tue, May 03, 2016 at 09:43:20PM +0200, Robert Jarzmik wrote: > You probably mean the BITCLK clock. > What is a bit pesky about this clock is that it can either be mastered by > digital controller and the codec is a slave, or the other way around. That's a bit surprising - I've never

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-04 Thread Mark Brown
On Tue, May 03, 2016 at 09:43:20PM +0200, Robert Jarzmik wrote: > You probably mean the BITCLK clock. > What is a bit pesky about this clock is that it can either be mastered by > digital controller and the codec is a slave, or the other way around. That's a bit surprising - I've never

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-03 Thread Robert Jarzmik
Mark Brown writes: > On Sat, Apr 30, 2016 at 11:15:34PM +0200, Robert Jarzmik wrote: >> AC97 is a bus for sound usage. It enables for a AC97 AC-Link to link one >> controller to 0 to 4 AC97 codecs. > >> The goal of this new implementation is to implement a device/driver >>

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-03 Thread Robert Jarzmik
Mark Brown writes: > On Sat, Apr 30, 2016 at 11:15:34PM +0200, Robert Jarzmik wrote: >> AC97 is a bus for sound usage. It enables for a AC97 AC-Link to link one >> controller to 0 to 4 AC97 codecs. > >> The goal of this new implementation is to implement a device/driver >> model for AC97, with

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-03 Thread Mark Brown
On Sat, Apr 30, 2016 at 11:15:34PM +0200, Robert Jarzmik wrote: > AC97 is a bus for sound usage. It enables for a AC97 AC-Link to link one > controller to 0 to 4 AC97 codecs. > The goal of this new implementation is to implement a device/driver > model for AC97, with an automatic scan of the bus

Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-05-03 Thread Mark Brown
On Sat, Apr 30, 2016 at 11:15:34PM +0200, Robert Jarzmik wrote: > AC97 is a bus for sound usage. It enables for a AC97 AC-Link to link one > controller to 0 to 4 AC97 codecs. > The goal of this new implementation is to implement a device/driver > model for AC97, with an automatic scan of the bus

[RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-04-30 Thread Robert Jarzmik
AC97 is a bus for sound usage. It enables for a AC97 AC-Link to link one controller to 0 to 4 AC97 codecs. The goal of this new implementation is to implement a device/driver model for AC97, with an automatic scan of the bus and automatic discovery of AC97 codec devices. Signed-off-by: Robert

[RFC PATCH 2/7] ALSA: ac97: add an ac97 bus

2016-04-30 Thread Robert Jarzmik
AC97 is a bus for sound usage. It enables for a AC97 AC-Link to link one controller to 0 to 4 AC97 codecs. The goal of this new implementation is to implement a device/driver model for AC97, with an automatic scan of the bus and automatic discovery of AC97 codec devices. Signed-off-by: Robert