Re: [RFC PATCH 2/8] kmod - rename call_usermodehelper() flags parameter

2015-02-05 Thread Ian Kent
On Thu, 2015-02-05 at 15:01 +, David Howells wrote: > Ian Kent wrote: > > > -call_usermodehelper(char *path, char **argv, char **envp, int wait); > > +call_usermodehelper(char *path, char **argv, char **envp, int flags); > > Can we make flags unsigned whilst we're at it? Other than that: S

Re: [RFC PATCH 2/8] kmod - rename call_usermodehelper() flags parameter

2015-02-05 Thread David Howells
Ian Kent wrote: > -call_usermodehelper(char *path, char **argv, char **envp, int wait); > +call_usermodehelper(char *path, char **argv, char **envp, int flags); Can we make flags unsigned whilst we're at it? Other than that: Acked-by: David Howells -- To unsubscribe from this list: send the l

[RFC PATCH 2/8] kmod - rename call_usermodehelper() flags parameter

2015-02-04 Thread Ian Kent
The wait parameter of call_usermodehelper() is not quite a parameter that describes the wait behaviour alone and will later be used to request exec within a namespace. So change its name to flags. Signed-off-by: Ian Kent Cc: Benjamin Coddington Cc: Al Viro Cc: J. Bruce Fields Cc: David Howell

[RFC PATCH 2/8] kmod - rename call_usermodehelper() flags parameter

2015-02-02 Thread Ian Kent
The wait parameter of call_usermodehelper() is not quite a parameter that describes the wait behaviour alone and will later be used to request exec within a namespace. So change its name to flags. Signed-off-by: Ian Kent Cc: Benjamin Coddington Cc: Al Viro Cc: J. Bruce Fields Cc: David Howell