Re: [dm-devel] Re: [RFC PATCH 2/8] rqbased-dm: add block layer hook

2006-12-22 Thread Kiyoshi Ueda
Hi Mike, On Fri, 22 Dec 2006 01:18:44 -0600, Mike Christie <[EMAIL PROTECTED]> wrote: > > In addition to the suggested approach, what do you think about > > adding a new flag to req->cmd_flags which lets the end_io() handler > > not to return bio to upper layer? > > It will be useful for multipath

Re: [dm-devel] Re: [RFC PATCH 2/8] rqbased-dm: add block layer hook

2006-12-21 Thread Mike Christie
Kiyoshi Ueda wrote: > Hi Jens, > > On Thu, 21 Dec 2006 08:49:47 +0100, Jens Axboe <[EMAIL PROTECTED]> wrote: >>> The new hook is needed for error handling in dm. >>> For example, when an error occurred on a request, dm-multipath >>> wants to try another path before returning EIO to application. >>

Re: [RFC PATCH 2/8] rqbased-dm: add block layer hook

2006-12-21 Thread business1
Kiyoshi Ueda wrote: > > Hi Jens, > > Sorry for the less explanation. > > On Wed, 20 Dec 2006 14:49:24 +0100, Jens Axboe <[EMAIL PROTECTED]> > wrote: >> On Tue, Dec 19 2006, Kiyoshi Ueda wrote: >> > This patch adds new "end_io_first" hook in __end_that_request_first() >> > for request-based de

Re: [RFC PATCH 2/8] rqbased-dm: add block layer hook

2006-12-21 Thread business1
Jens Axboe-5 wrote: > > On Tue, Dec 19 2006, Kiyoshi Ueda wrote: >> This patch adds new "end_io_first" hook in __end_that_request_first() >> for request-based device-mapper. > > What's this for, lack of stacking? > > -- > Jens Axboe look at this it will halp > http://www.thebusinesssuccessgr

Re: [RFC PATCH 2/8] rqbased-dm: add block layer hook

2006-12-21 Thread business1
Kiyoshi Ueda wrote: > > Hi Jens, > > On Thu, 21 Dec 2006 08:49:47 +0100, Jens Axboe <[EMAIL PROTECTED]> > wrote: >> > The new hook is needed for error handling in dm. >> > For example, when an error occurred on a request, dm-multipath >> > wants to try another path before returning EIO to appl

Re: [RFC PATCH 2/8] rqbased-dm: add block layer hook

2006-12-21 Thread business1
Kiyoshi Ueda wrote: > > This patch adds new "end_io_first" hook in __end_that_request_first() > for request-based device-mapper. > > > Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> > Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> > > diff -rupN 1-blk-get-request-irqrestore/block/ll_rw_

Re: [RFC PATCH 2/8] rqbased-dm: add block layer hook

2006-12-21 Thread Kiyoshi Ueda
Hi Jens, On Thu, 21 Dec 2006 08:49:47 +0100, Jens Axboe <[EMAIL PROTECTED]> wrote: > > The new hook is needed for error handling in dm. > > For example, when an error occurred on a request, dm-multipath > > wants to try another path before returning EIO to application. > > Without the new hook, at

Re: [RFC PATCH 2/8] rqbased-dm: add block layer hook

2006-12-20 Thread Jens Axboe
On Wed, Dec 20 2006, Kiyoshi Ueda wrote: > Hi Jens, > > Sorry for the less explanation. > > On Wed, 20 Dec 2006 14:49:24 +0100, Jens Axboe <[EMAIL PROTECTED]> wrote: > > On Tue, Dec 19 2006, Kiyoshi Ueda wrote: > > > This patch adds new "end_io_first" hook in __end_that_request_first() > > > for

Re: [RFC PATCH 2/8] rqbased-dm: add block layer hook

2006-12-20 Thread Kiyoshi Ueda
Hi Jens, Sorry for the less explanation. On Wed, 20 Dec 2006 14:49:24 +0100, Jens Axboe <[EMAIL PROTECTED]> wrote: > On Tue, Dec 19 2006, Kiyoshi Ueda wrote: > > This patch adds new "end_io_first" hook in __end_that_request_first() > > for request-based device-mapper. > > What's this for, lack o

Re: [RFC PATCH 2/8] rqbased-dm: add block layer hook

2006-12-20 Thread Jens Axboe
On Tue, Dec 19 2006, Kiyoshi Ueda wrote: > This patch adds new "end_io_first" hook in __end_that_request_first() > for request-based device-mapper. What's this for, lack of stacking? -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

[RFC PATCH 2/8] rqbased-dm: add block layer hook

2006-12-19 Thread Kiyoshi Ueda
This patch adds new "end_io_first" hook in __end_that_request_first() for request-based device-mapper. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> diff -rupN 1-blk-get-request-irqrestore/block/ll_rw_blk.c 2-add-generic-hook/block/ll_rw_blk.