Re: [RFC PATCH 22/57] drivers: i2c: Use generic helper to match device by acpi_dev

2019-06-10 Thread Suzuki K Poulose
Hi, On 06/06/2019 21:03, Wolfram Sang wrote: - dev = bus_find_device(_bus_type, NULL, adev, - i2c_acpi_find_match_device); + dev = bus_find_device(_bus_type, NULL, adev, device_match_acpi_dev); In general, this looks like a nice cleanup which I am in

Re: [RFC PATCH 22/57] drivers: i2c: Use generic helper to match device by acpi_dev

2019-06-06 Thread Wolfram Sang
> - dev = bus_find_device(_bus_type, NULL, adev, > - i2c_acpi_find_match_device); > + dev = bus_find_device(_bus_type, NULL, adev, device_match_acpi_dev); In general, this looks like a nice cleanup which I am in favour of. However, I didn't understand why ACPI

Re: [RFC PATCH 22/57] drivers: i2c: Use generic helper to match device by acpi_dev

2019-06-04 Thread Mika Westerberg
On Mon, Jun 03, 2019 at 04:49:48PM +0100, Suzuki K Poulose wrote: > Switch to the generic helper to match device by acpi_dev. It would be nice if you had Cc'd actual implementation of device_match_acpi_dev() as well but if it looks like i2c_acpi_find_match_device() then this is fine by me,

[RFC PATCH 22/57] drivers: i2c: Use generic helper to match device by acpi_dev

2019-06-03 Thread Suzuki K Poulose
Switch to the generic helper to match device by acpi_dev. Cc: Mika Westerberg Cc: Wolfram Sang cc: linux-...@vger.kernel.org Signed-off-by: Suzuki K Poulose --- drivers/i2c/i2c-core-acpi.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/i2c/i2c-core-acpi.c