Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner.

2020-11-17 Thread Matthew Wilcox
On Tue, Nov 17, 2020 at 01:35:37PM -0800, Roman Gushchin wrote: > On Tue, Nov 17, 2020 at 09:22:55PM +, Matthew Wilcox wrote: > > On Tue, Nov 17, 2020 at 04:12:03PM -0500, Zi Yan wrote: > > > On 17 Nov 2020, at 16:05, Matthew Wilcox wrote: > > > > > > > On Fri, Nov 13, 2020 at 05:38:01PM

Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner.

2020-11-17 Thread Roman Gushchin
On Tue, Nov 17, 2020 at 09:22:55PM +, Matthew Wilcox wrote: > On Tue, Nov 17, 2020 at 04:12:03PM -0500, Zi Yan wrote: > > On 17 Nov 2020, at 16:05, Matthew Wilcox wrote: > > > > > On Fri, Nov 13, 2020 at 05:38:01PM -0800, Roman Gushchin wrote: > > >> On Fri, Nov 13, 2020 at 08:08:58PM -0500,

Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner.

2020-11-17 Thread Zi Yan
On 17 Nov 2020, at 16:22, Matthew Wilcox wrote: > On Tue, Nov 17, 2020 at 04:12:03PM -0500, Zi Yan wrote: >> On 17 Nov 2020, at 16:05, Matthew Wilcox wrote: >> >>> On Fri, Nov 13, 2020 at 05:38:01PM -0800, Roman Gushchin wrote: On Fri, Nov 13, 2020 at 08:08:58PM -0500, Zi Yan wrote: >

Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner.

2020-11-17 Thread Matthew Wilcox
On Tue, Nov 17, 2020 at 04:12:03PM -0500, Zi Yan wrote: > On 17 Nov 2020, at 16:05, Matthew Wilcox wrote: > > > On Fri, Nov 13, 2020 at 05:38:01PM -0800, Roman Gushchin wrote: > >> On Fri, Nov 13, 2020 at 08:08:58PM -0500, Zi Yan wrote: > >>> Matthew recently converted split_page_owner to take nr

Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner.

2020-11-17 Thread Zi Yan
On 17 Nov 2020, at 16:10, Matthew Wilcox wrote: > On Wed, Nov 11, 2020 at 03:40:05PM -0500, Zi Yan wrote: >> -for (i = 0; i < nr; i++) { >> +for (i = 0; i < nr; i += (1 << new_order)) { >> page_owner = get_page_owner(page_ext); >> -page_owner->order = 0; >> +

Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner.

2020-11-17 Thread Zi Yan
On 17 Nov 2020, at 16:05, Matthew Wilcox wrote: > On Fri, Nov 13, 2020 at 05:38:01PM -0800, Roman Gushchin wrote: >> On Fri, Nov 13, 2020 at 08:08:58PM -0500, Zi Yan wrote: >>> Matthew recently converted split_page_owner to take nr instead of order.[1] >>> But I am not >>> sure why, since it

Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner.

2020-11-17 Thread Matthew Wilcox
On Wed, Nov 11, 2020 at 03:40:05PM -0500, Zi Yan wrote: > - for (i = 0; i < nr; i++) { > + for (i = 0; i < nr; i += (1 << new_order)) { > page_owner = get_page_owner(page_ext); > - page_owner->order = 0; > + page_owner->order = new_order; >

Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner.

2020-11-17 Thread Matthew Wilcox
On Fri, Nov 13, 2020 at 05:38:01PM -0800, Roman Gushchin wrote: > On Fri, Nov 13, 2020 at 08:08:58PM -0500, Zi Yan wrote: > > Matthew recently converted split_page_owner to take nr instead of order.[1] > > But I am not > > sure why, since it seems to me that two call sites (__split_huge_page in >

Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner.

2020-11-16 Thread Zi Yan
On 16 Nov 2020, at 11:25, Kirill A. Shutemov wrote: > On Wed, Nov 11, 2020 at 03:40:05PM -0500, Zi Yan wrote: >> From: Zi Yan >> >> It adds a new_order parameter to set new page order in page owner. >> It prepares for upcoming changes to support split huge page to any lower >> order. >> >>

Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner.

2020-11-16 Thread Kirill A. Shutemov
On Wed, Nov 11, 2020 at 03:40:05PM -0500, Zi Yan wrote: > From: Zi Yan > > It adds a new_order parameter to set new page order in page owner. > It prepares for upcoming changes to support split huge page to any lower > order. > > Signed-off-by: Zi Yan > --- > include/linux/page_owner.h | 7

Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner.

2020-11-13 Thread Roman Gushchin
On Fri, Nov 13, 2020 at 08:08:58PM -0500, Zi Yan wrote: > On 13 Nov 2020, at 19:15, Roman Gushchin wrote: > > > On Wed, Nov 11, 2020 at 03:40:05PM -0500, Zi Yan wrote: > > > From: Zi Yan > > > > > > It adds a new_order parameter to set new page order in page owner. > > > It prepares for

Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner.

2020-11-13 Thread Zi Yan
On 13 Nov 2020, at 19:15, Roman Gushchin wrote: On Wed, Nov 11, 2020 at 03:40:05PM -0500, Zi Yan wrote: From: Zi Yan It adds a new_order parameter to set new page order in page owner. It prepares for upcoming changes to support split huge page to any lower order. Signed-off-by: Zi Yan

Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner.

2020-11-13 Thread Roman Gushchin
On Wed, Nov 11, 2020 at 03:40:05PM -0500, Zi Yan wrote: > From: Zi Yan > > It adds a new_order parameter to set new page order in page owner. > It prepares for upcoming changes to support split huge page to any lower > order. > > Signed-off-by: Zi Yan > --- > include/linux/page_owner.h | 7

Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner.

2020-11-12 Thread Zi Yan
On 12 Nov 2020, at 12:57, Ralph Campbell wrote: > On 11/11/20 12:40 PM, Zi Yan wrote: >> From: Zi Yan >> >> It adds a new_order parameter to set new page order in page owner. >> It prepares for upcoming changes to support split huge page to any lower >> order. >> >> Signed-off-by: Zi Yan > >

Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner.

2020-11-12 Thread Ralph Campbell
On 11/11/20 12:40 PM, Zi Yan wrote: From: Zi Yan It adds a new_order parameter to set new page order in page owner. It prepares for upcoming changes to support split huge page to any lower order. Signed-off-by: Zi Yan Except for a minor fix below, you can add: Reviewed-by: Ralph Campbell

[RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner.

2020-11-11 Thread Zi Yan
From: Zi Yan It adds a new_order parameter to set new page order in page owner. It prepares for upcoming changes to support split huge page to any lower order. Signed-off-by: Zi Yan --- include/linux/page_owner.h | 7 --- mm/huge_memory.c | 2 +- mm/page_alloc.c| 2