Re: [RFC PATCH 3/8] qaic: Create char dev

2020-05-17 Thread Jeffrey Hugo
On 5/17/2020 1:14 AM, Greg KH wrote: On Sat, May 16, 2020 at 03:29:19PM -0600, Jeffrey Hugo wrote: On 5/16/2020 1:01 AM, Greg KH wrote: On Fri, May 15, 2020 at 03:08:59PM -0600, Jeffrey Hugo wrote: 2. There are a limited number of dynamic minor numbers for misc devs (64), so if you are expecti

Re: [RFC PATCH 3/8] qaic: Create char dev

2020-05-17 Thread Greg KH
On Sat, May 16, 2020 at 03:29:19PM -0600, Jeffrey Hugo wrote: > On 5/16/2020 1:01 AM, Greg KH wrote: > > On Fri, May 15, 2020 at 03:08:59PM -0600, Jeffrey Hugo wrote: > > > 2. There are a limited number of dynamic minor numbers for misc devs (64), > > > so if you are expecting more devices than tha

Re: [RFC PATCH 3/8] qaic: Create char dev

2020-05-16 Thread Jeffrey Hugo
On 5/16/2020 1:01 AM, Greg KH wrote: On Fri, May 15, 2020 at 03:08:59PM -0600, Jeffrey Hugo wrote: 2. There are a limited number of dynamic minor numbers for misc devs (64), so if you are expecting more devices than that, a misc dev is not appropiate. Also, these minors are shared with other mi

Re: [RFC PATCH 3/8] qaic: Create char dev

2020-05-16 Thread Greg KH
On Fri, May 15, 2020 at 03:08:59PM -0600, Jeffrey Hugo wrote: > 2. There are a limited number of dynamic minor numbers for misc devs (64), > so if you are expecting more devices than that, a misc dev is not > appropiate. Also, these minors are shared with other misc dev users, so > depending on th

Re: [RFC PATCH 3/8] qaic: Create char dev

2020-05-15 Thread Jeffrey Hugo
On 5/14/2020 10:24 AM, Jeffrey Hugo wrote: On 5/14/2020 9:56 AM, Greg KH wrote: Please use misc. Ok, will investigate. Misc looks like it'll work, and I'm expecting to have that in the next revision. However, a few of us looked at misc vs chardev, and didn't see much of a difference. W

Re: [RFC PATCH 3/8] qaic: Create char dev

2020-05-14 Thread Jeffrey Hugo
On 5/14/2020 9:56 AM, Greg KH wrote: On Thu, May 14, 2020 at 09:05:30AM -0600, Jeffrey Hugo wrote: Wow, thank you for the near immediate response. I'm am quite impressed. On 5/14/2020 8:12 AM, Greg KH wrote: On Thu, May 14, 2020 at 08:07:41AM -0600, Jeffrey Hugo wrote: /* Copyright (c) 20

Re: [RFC PATCH 3/8] qaic: Create char dev

2020-05-14 Thread Greg KH
On Thu, May 14, 2020 at 09:05:30AM -0600, Jeffrey Hugo wrote: > Wow, thank you for the near immediate response. I'm am quite impressed. > > On 5/14/2020 8:12 AM, Greg KH wrote: > > On Thu, May 14, 2020 at 08:07:41AM -0600, Jeffrey Hugo wrote: > > > /* Copyright (c) 2019-2020, The Linux Foundati

Re: [RFC PATCH 3/8] qaic: Create char dev

2020-05-14 Thread Jeffrey Hugo
Wow, thank you for the near immediate response. I'm am quite impressed. On 5/14/2020 8:12 AM, Greg KH wrote: On Thu, May 14, 2020 at 08:07:41AM -0600, Jeffrey Hugo wrote: /* Copyright (c) 2019-2020, The Linux Foundation. All rights reserved. */ +#include +#include +#include +#include

Re: [RFC PATCH 3/8] qaic: Create char dev

2020-05-14 Thread Greg KH
On Thu, May 14, 2020 at 08:07:41AM -0600, Jeffrey Hugo wrote: > /* Copyright (c) 2019-2020, The Linux Foundation. All rights reserved. */ > > +#include > +#include > +#include > +#include > +#include > #include > #include > +#include > #include > #include > > @@ -13,9 +19,242 @@

[RFC PATCH 3/8] qaic: Create char dev

2020-05-14 Thread Jeffrey Hugo
Now that we can fully boot the device, we should start making it usable. The primary interface to the device will be via a char dev. Add the necessary framework to detect when the device is fully booted, and create the char dev at that point. The device is only usable when it is fully booted. Th