Re: [RFC PATCH 4/5] mm, memory_hotplug: print reason for the offlining failure

2018-11-13 Thread Michal Hocko
On Wed 07-11-18 14:04:13, Andrew Morton wrote: > On Wed, 7 Nov 2018 11:18:29 +0100 Michal Hocko wrote: > > > From: Michal Hocko > > > > The memory offlining failure reporting is inconsistent and insufficient. > > Some error paths simply do not report the failure to the log at all. > > When we

Re: [RFC PATCH 4/5] mm, memory_hotplug: print reason for the offlining failure

2018-11-08 Thread Michal Hocko
On Wed 07-11-18 14:04:13, Andrew Morton wrote: [...] > Fix: > > --- > a/mm/memory_hotplug.c~mm-memory_hotplug-print-reason-for-the-offlining-failure-fix > +++ a/mm/memory_hotplug.c > @@ -1576,7 +1576,7 @@ static int __ref __offline_pages(unsigne > MIGRATE_MOVA

Re: [RFC PATCH 4/5] mm, memory_hotplug: print reason for the offlining failure

2018-11-08 Thread Michal Hocko
On Thu 08-11-18 11:53:21, Anshuman Khandual wrote: > > > On 11/07/2018 03:48 PM, Michal Hocko wrote: > > From: Michal Hocko > > > > The memory offlining failure reporting is inconsistent and insufficient. > > Some error paths simply do not report the failure to the log at all. > > When we do re

Re: [RFC PATCH 4/5] mm, memory_hotplug: print reason for the offlining failure

2018-11-07 Thread Anshuman Khandual
On 11/07/2018 03:48 PM, Michal Hocko wrote: > From: Michal Hocko > > The memory offlining failure reporting is inconsistent and insufficient. > Some error paths simply do not report the failure to the log at all. > When we do report there are no details about the reason of the failure > and th

Re: [RFC PATCH 4/5] mm, memory_hotplug: print reason for the offlining failure

2018-11-07 Thread Andrew Morton
On Wed, 7 Nov 2018 11:18:29 +0100 Michal Hocko wrote: > From: Michal Hocko > > The memory offlining failure reporting is inconsistent and insufficient. > Some error paths simply do not report the failure to the log at all. > When we do report there are no details about the reason of the failur

[RFC PATCH 4/5] mm, memory_hotplug: print reason for the offlining failure

2018-11-07 Thread Michal Hocko
From: Michal Hocko The memory offlining failure reporting is inconsistent and insufficient. Some error paths simply do not report the failure to the log at all. When we do report there are no details about the reason of the failure and there are several of them which makes memory offlining failur