Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver

2024-01-07 Thread Mark Brown
On Sun, Jan 07, 2024 at 10:49:20AM +0100, Karel Balej wrote: > On Fri Jan 5, 2024 at 4:18 PM CET, Mark Brown wrote: > > Why are we adding an of_compatible here? It's redundant, the MFD split > > is a feature of Linux internals not of the hardware, and the existing > > 88pm8xx MFD doesn't use

Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver

2024-01-07 Thread Karel Balej
On Sun Jan 7, 2024 at 11:35 AM CET, Krzysztof Kozlowski wrote: > On 28/12/2023 10:39, Karel Balej wrote: > > diff --git a/drivers/mfd/88pm88x.c b/drivers/mfd/88pm88x.c > > index 69a8e39d43b3..999d0539b720 100644 > > --- a/drivers/mfd/88pm88x.c > > +++ b/drivers/mfd/88pm88x.c > > @@ -68,6 +68,21 @@

Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver

2024-01-07 Thread Karel Balej
Krzysztof, On Sun Jan 7, 2024 at 11:34 AM CET, Krzysztof Kozlowski wrote: > On 07/01/2024 10:49, Karel Balej wrote: > > Mark, > > > > On Fri Jan 5, 2024 at 4:18 PM CET, Mark Brown wrote: > >> On Thu, Dec 28, 2023 at 10:39:13AM +0100, Karel Balej wrote: > >> > >>> @@ -68,6 +68,21 @@ static struct

Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver

2024-01-07 Thread Krzysztof Kozlowski
On 28/12/2023 10:39, Karel Balej wrote: > diff --git a/drivers/mfd/88pm88x.c b/drivers/mfd/88pm88x.c > index 69a8e39d43b3..999d0539b720 100644 > --- a/drivers/mfd/88pm88x.c > +++ b/drivers/mfd/88pm88x.c > @@ -68,6 +68,21 @@ static struct mfd_cell pm886_devs[] = { > .num_resources =

Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver

2024-01-07 Thread Krzysztof Kozlowski
On 07/01/2024 10:49, Karel Balej wrote: > Mark, > > On Fri Jan 5, 2024 at 4:18 PM CET, Mark Brown wrote: >> On Thu, Dec 28, 2023 at 10:39:13AM +0100, Karel Balej wrote: >> >>> @@ -68,6 +68,21 @@ static struct mfd_cell pm886_devs[] = { >>> .num_resources =

Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver

2024-01-07 Thread Karel Balej
Mark, On Fri Jan 5, 2024 at 4:18 PM CET, Mark Brown wrote: > On Thu, Dec 28, 2023 at 10:39:13AM +0100, Karel Balej wrote: > > > @@ -68,6 +68,21 @@ static struct mfd_cell pm886_devs[] = { > > .num_resources = ARRAY_SIZE(pm88x_onkey_resources), > > .resources =

Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver

2024-01-05 Thread Mark Brown
On Thu, Dec 28, 2023 at 10:39:13AM +0100, Karel Balej wrote: > @@ -68,6 +68,21 @@ static struct mfd_cell pm886_devs[] = { > .num_resources = ARRAY_SIZE(pm88x_onkey_resources), > .resources = pm88x_onkey_resources, > }, > + { > + .name =

[RFC PATCH 4/5] regulator: add 88pm88x regulators driver

2023-12-28 Thread Karel Balej
From: Karel Balej Support the LDO and buck regulators of the Marvell 88PM886 PMIC. Support for 88PM880 is not included but should be easy to implement being just a matter of defining the additional LDOs and all bucks and modifying the 88PM88X MFD driver appropriately. Signed-off-by: Karel Balej