Re: [RFC PATCH 6/9] gpiolib: add API to get gpio desc and flags

2014-08-19 Thread Alexandre Courbot
On Tue, Aug 19, 2014 at 1:56 AM, Mika Westerberg wrote: > On Mon, Aug 18, 2014 at 09:24:48AM -0700, Alexandre Courbot wrote: >> On Fri, Aug 15, 2014 at 11:53 PM, Mika Westerberg >> wrote: >> > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c >> > index 2ebc9071e354..e6c2413a6fbf 10064

Re: [RFC PATCH 6/9] gpiolib: add API to get gpio desc and flags

2014-08-19 Thread Grant Likely
On Mon, 18 Aug 2014 06:57:41 +0200, "Rafael J. Wysocki" wrote: > On Sunday, August 17, 2014 12:43:38 PM Darren Hart wrote: > > On 8/17/14, 6:00, "Grant Likely" wrote: > > > > >> > > >>+ /* Using device tree? */ > > >>+ if (IS_ENABLED(CONFIG_OF) && dev->of_node) > > >>+ desc = of_find_gp

Re: [RFC PATCH 6/9] gpiolib: add API to get gpio desc and flags

2014-08-19 Thread Aaron Lu
On 08/19/2014 04:56 PM, Mika Westerberg wrote: > On Mon, Aug 18, 2014 at 09:24:48AM -0700, Alexandre Courbot wrote: >> On Fri, Aug 15, 2014 at 11:53 PM, Mika Westerberg >> wrote: >>> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c >>> index 2ebc9071e354..e6c2413a6fbf 100644 >>> --- a/

Re: [RFC PATCH 6/9] gpiolib: add API to get gpio desc and flags

2014-08-19 Thread Mika Westerberg
On Mon, Aug 18, 2014 at 09:24:48AM -0700, Alexandre Courbot wrote: > On Fri, Aug 15, 2014 at 11:53 PM, Mika Westerberg > wrote: > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > > index 2ebc9071e354..e6c2413a6fbf 100644 > > --- a/drivers/gpio/gpiolib.c > > +++ b/drivers/gpio/gpiol

Re: [RFC PATCH 6/9] gpiolib: add API to get gpio desc and flags

2014-08-18 Thread Aaron Lu
On 08/18/2014 12:57 PM, Rafael J. Wysocki wrote: > On Sunday, August 17, 2014 12:43:38 PM Darren Hart wrote: >> On 8/17/14, 6:00, "Grant Likely" wrote: >> + /* Using device tree? */ + if (IS_ENABLED(CONFIG_OF) && dev->of_node) + desc = of_find_gpio(dev, NULL, idx, fl

Re: [RFC PATCH 6/9] gpiolib: add API to get gpio desc and flags

2014-08-17 Thread Rafael J. Wysocki
On Sunday, August 17, 2014 12:43:38 PM Darren Hart wrote: > On 8/17/14, 6:00, "Grant Likely" wrote: > > >> > >>+ /* Using device tree? */ > >>+ if (IS_ENABLED(CONFIG_OF) && dev->of_node) > >>+ desc = of_find_gpio(dev, NULL, idx, flags); > > > >of_find_gpio() doesn't exist. > > Hrm.

Re: [RFC PATCH 6/9] gpiolib: add API to get gpio desc and flags

2014-08-17 Thread Darren Hart
On 8/17/14, 6:00, "Grant Likely" wrote: >> >>+ /* Using device tree? */ >>+ if (IS_ENABLED(CONFIG_OF) && dev->of_node) >>+ desc = of_find_gpio(dev, NULL, idx, flags); > >of_find_gpio() doesn't exist. Hrm... As of 3.16.0 (e64df3ebe8262c8203d1fe4f541e0241c3112c01) $ git blame

Re: [RFC PATCH 6/9] gpiolib: add API to get gpio desc and flags

2014-08-17 Thread Grant Likely
On Sun, 17 Aug 2014 09:04:16 +0300, Mika Westerberg wrote: > From: Aaron Lu > > Add a new API to get the GPIO's description pointer and its flags for > both OF based system and ACPI based system. This is useful in drivers > that do not need to care about the underlying firmware interface. Hi M

[RFC PATCH 6/9] gpiolib: add API to get gpio desc and flags

2014-08-16 Thread Mika Westerberg
From: Aaron Lu Add a new API to get the GPIO's description pointer and its flags for both OF based system and ACPI based system. This is useful in drivers that do not need to care about the underlying firmware interface. Signed-off-by: Aaron Lu Signed-off-by: Max Eliaser Signed-off-by: Darren