Re: [RFC PATCH 7/8] mtd: rawnand: ams-delta: Check sanity of data GPIO resource

2018-07-29 Thread Boris Brezillon
On Sun, 29 Jul 2018 22:36:49 +0200 Linus Walleij wrote: > On Thu, Jul 19, 2018 at 8:44 AM Boris Brezillon > wrote: > > > I guess you'd prefer to have the pin values in a bitmap instead of an > > array of integers. That's probably something you can discuss with > > Linus, see if he would accept

Re: [RFC PATCH 7/8] mtd: rawnand: ams-delta: Check sanity of data GPIO resource

2018-07-29 Thread Linus Walleij
On Thu, Jul 19, 2018 at 8:44 AM Boris Brezillon wrote: > I guess you'd prefer to have the pin values in a bitmap instead of an > array of integers. That's probably something you can discuss with > Linus, see if he would accept to change the prototype of > gpiod_get_raw_array_value(). I am not so

Re: [RFC PATCH 7/8] mtd: rawnand: ams-delta: Check sanity of data GPIO resource

2018-07-29 Thread Linus Walleij
Hi Janusz! Nice work overall! Some feedback: On Thu, Jul 19, 2018 at 1:57 AM Janusz Krzysztofik wrote: > +#include Let's skip that. > + /* > +* For acceptable performance require the data GPIO > +* chip to support get/set_multiple() callbacks. > +*/ > + if

Re: [RFC PATCH 7/8] mtd: rawnand: ams-delta: Check sanity of data GPIO resource

2018-07-18 Thread Boris Brezillon
On Thu, 19 Jul 2018 01:57:09 +0200 Janusz Krzysztofik wrote: > The plan is to replace data port readw()/writew() operations with GPIO > callbacks provided by gpio-omap driver. For acceptable performance the > GPIO chip must support get/set_multiple() GPIO callbacks. > > In order to avoid data c

[RFC PATCH 7/8] mtd: rawnand: ams-delta: Check sanity of data GPIO resource

2018-07-18 Thread Janusz Krzysztofik
The plan is to replace data port readw()/writew() operations with GPIO callbacks provided by gpio-omap driver. For acceptable performance the GPIO chip must support get/set_multiple() GPIO callbacks. In order to avoid data corruption, we require the array of data GPIO descriptors obtained with gp