Re: [RFC PATCH bpf-next 0/6] bpf, printk: add BTF-based type printing

2020-05-01 Thread Joe Perches
On Thu, 2020-04-30 at 03:03 -0700, Alan Maguire wrote: > On Mon, 20 Apr 2020, Joe Perches wrote: > > Here as well the individual field types don't contain > > enough information to determine if a field should be > > output as %x or %u. > Right, we could add some more format modifiers for cases >

Re: [RFC PATCH bpf-next 0/6] bpf, printk: add BTF-based type printing

2020-04-30 Thread Alan Maguire
On Mon, 20 Apr 2020, Joe Perches wrote: > On Mon, 2020-04-20 at 16:29 +0100, Alan Maguire wrote: > > On Sat, 18 Apr 2020, Alexei Starovoitov wrote: > > > > > On Fri, Apr 17, 2020 at 11:42:34AM +0100, Alan Maguire wrote: > > > > The printk family of functions support printing specific pointer

Re: [RFC PATCH bpf-next 0/6] bpf, printk: add BTF-based type printing

2020-04-29 Thread Rasmus Villemoes
On 20/04/2020 18.32, Joe Perches wrote: > On Mon, 2020-04-20 at 16:29 +0100, Alan Maguire wrote: struct sk_buff *skb = alloc_skb(64, GFP_KERNEL); pr_info("%pTN", skb); >>> >>> why follow "TN" convention? >>> I think "%p" is much more obvious, unambiguous, and >>> equally easy