Joe Perches :
> On Tue, 2014-09-23 at 21:02 +0200, Francois Romieu wrote:
[...]
> > How about kernel tinification ?
>
> The tiny case where a large number of ethernet drivers are included?
No.
A couple of bytes here and there vs a cosmetic kernel wide change.
--
Ueimor
--
To unsubscribe from
On Tue, 2014-09-23 at 21:02 +0200, Francois Romieu wrote:
> Mark Einon :
> [...]
> > > No need for the #define here, just assigne et131x_pm_ops to .driver.pm
> > > directly, its members will be NULL and thus never called. Also, you can
> > > make et131x_pm_ops const.
> >
> > Ok, I can change
Mark Einon :
[...]
> > No need for the #define here, just assigne et131x_pm_ops to .driver.pm
> > directly, its members will be NULL and thus never called. Also, you can
> > make et131x_pm_ops const.
>
> Ok, I can change this.
>
> Btw, this appears to be a fairly standard way of using
On Tue, Sep 23, 2014 at 12:01:07PM +0200, Tobias Klauser wrote:
> On 2014-09-23 at 11:46:15 +0200, Mark Einon wrote:
> > On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote:
> >
> > Hi Tobias,
> >
> > Thanks for the details review. I've replied below -
> >
> > [...]
> > > > +/*
On 2014-09-23 at 11:46:15 +0200, Mark Einon wrote:
> On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote:
>
> Hi Tobias,
>
> Thanks for the details review. I've replied below -
>
> [...]
> > > +/* et131x_rx_dma_memory_alloc
> > > + *
> > > + * Allocates Free buffer ring 1 for sure,
On Tue, Sep 23, 2014 at 09:56:53AM +1000, Angus Gibson wrote:
> > +config NET_VENDOR_AGERE
> > + bool "Agere devices"
> > + default y
> > + depends on PCI
> > + ---help---
> > + If you have a network (Ethernet) card belonging to this class, say =
> > Y
> > + and read the
On Mon, Sep 22, 2014 at 06:57:25PM -0700, Joe Perches wrote:
> On Mon, 2014-09-22 at 22:28 +0100, Mark Einon wrote:
> > This patch moves the et131x gigabit ethernet driver from drivers/staging
> > to drivers/net/ethernet/agere.
> >
> > There are no known issues at this time.
>
> This doesn't
On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote:
Hi Tobias,
Thanks for the details review. I've replied below -
[...]
> > +/* et131x_rx_dma_memory_alloc
> > + *
> > + * Allocates Free buffer ring 1 for sure, free buffer ring 0 if required,
> > + * and the Packet Status Ring.
> >
On 2014-09-22 at 23:28:03 +0200, Mark Einon wrote:
> This patch moves the et131x gigabit ethernet driver from drivers/staging
> to drivers/net/ethernet/agere.
>
> There are no known issues at this time.
>
> Signed-off-by: Mark Einon
> ---
>
> This patch will only apply once the last few
On 2014-09-22 at 23:28:03 +0200, Mark Einon mark.ei...@gmail.com wrote:
This patch moves the et131x gigabit ethernet driver from drivers/staging
to drivers/net/ethernet/agere.
There are no known issues at this time.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
This patch will
On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote:
Hi Tobias,
Thanks for the details review. I've replied below -
[...]
+/* et131x_rx_dma_memory_alloc
+ *
+ * Allocates Free buffer ring 1 for sure, free buffer ring 0 if required,
+ * and the Packet Status Ring.
+ */
On Mon, Sep 22, 2014 at 06:57:25PM -0700, Joe Perches wrote:
On Mon, 2014-09-22 at 22:28 +0100, Mark Einon wrote:
This patch moves the et131x gigabit ethernet driver from drivers/staging
to drivers/net/ethernet/agere.
There are no known issues at this time.
This doesn't apply to -next
On Tue, Sep 23, 2014 at 09:56:53AM +1000, Angus Gibson wrote:
+config NET_VENDOR_AGERE
+ bool Agere devices
+ default y
+ depends on PCI
+ ---help---
+ If you have a network (Ethernet) card belonging to this class, say =
Y
+ and read the Ethernet-HOWTO, available
On 2014-09-23 at 11:46:15 +0200, Mark Einon mark.ei...@gmail.com wrote:
On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote:
Hi Tobias,
Thanks for the details review. I've replied below -
[...]
+/* et131x_rx_dma_memory_alloc
+ *
+ * Allocates Free buffer ring 1 for
On Tue, Sep 23, 2014 at 12:01:07PM +0200, Tobias Klauser wrote:
On 2014-09-23 at 11:46:15 +0200, Mark Einon mark.ei...@gmail.com wrote:
On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote:
Hi Tobias,
Thanks for the details review. I've replied below -
[...]
+/*
Mark Einon mark.ei...@gmail.com :
[...]
No need for the #define here, just assigne et131x_pm_ops to .driver.pm
directly, its members will be NULL and thus never called. Also, you can
make et131x_pm_ops const.
Ok, I can change this.
Btw, this appears to be a fairly standard way of using
On Tue, 2014-09-23 at 21:02 +0200, Francois Romieu wrote:
Mark Einon mark.ei...@gmail.com :
[...]
No need for the #define here, just assigne et131x_pm_ops to .driver.pm
directly, its members will be NULL and thus never called. Also, you can
make et131x_pm_ops const.
Ok, I can
Joe Perches j...@perches.com :
On Tue, 2014-09-23 at 21:02 +0200, Francois Romieu wrote:
[...]
How about kernel tinification ?
The tiny case where a large number of ethernet drivers are included?
No.
A couple of bytes here and there vs a cosmetic kernel wide change.
--
Ueimor
--
To
On Mon, 2014-09-22 at 22:28 +0100, Mark Einon wrote:
> This patch moves the et131x gigabit ethernet driver from drivers/staging
> to drivers/net/ethernet/agere.
>
> There are no known issues at this time.
This doesn't apply to -next or -linux
[]
> This patch will only apply once the last few
> +config NET_VENDOR_AGERE
> + bool "Agere devices"
> + default y
> + depends on PCI
> + ---help---
> + If you have a network (Ethernet) card belonging to this class, say =
> Y
> + and read the Ethernet-HOWTO, available from
> +
+config NET_VENDOR_AGERE
+ bool Agere devices
+ default y
+ depends on PCI
+ ---help---
+ If you have a network (Ethernet) card belonging to this class, say =
Y
+ and read the Ethernet-HOWTO, available from
+ http://www.tldp.org/docs.html#howto.
+
+
On Mon, 2014-09-22 at 22:28 +0100, Mark Einon wrote:
This patch moves the et131x gigabit ethernet driver from drivers/staging
to drivers/net/ethernet/agere.
There are no known issues at this time.
This doesn't apply to -next or -linux
[]
This patch will only apply once the last few pending
On Mon, Jan 21, 2013 at 11:44:55PM +, Mark Einon wrote:
> On 19 January 2013 11:03, Dan Carpenter wrote:
>
> >
> > et131x_get_regs() has endian bugs calling et131x_mii_read().
> >
>
>
> Hi Dan,
>
> Could you be a bit more descriptive about the issues you think there
> are with these
On 19 January 2013 11:03, Dan Carpenter wrote:
>
> et131x_get_regs() has endian bugs calling et131x_mii_read().
>
Hi Dan,
Could you be a bit more descriptive about the issues you think there
are with these calls?
cheers,
Mark
--
To unsubscribe from this list: send the line "unsubscribe
On 19 January 2013 11:03, Dan Carpenter dan.carpen...@oracle.com wrote:
snip
et131x_get_regs() has endian bugs calling et131x_mii_read().
/snip
Hi Dan,
Could you be a bit more descriptive about the issues you think there
are with these calls?
cheers,
Mark
--
To unsubscribe from this list:
On Mon, Jan 21, 2013 at 11:44:55PM +, Mark Einon wrote:
On 19 January 2013 11:03, Dan Carpenter dan.carpen...@oracle.com wrote:
snip
et131x_get_regs() has endian bugs calling et131x_mii_read().
/snip
Hi Dan,
Could you be a bit more descriptive about the issues you think there
On Fri, Jan 18, 2013 at 02:57:06PM -0800, Greg KH wrote:
> On Fri, Jan 18, 2013 at 08:40:47PM +, Mark Einon wrote:
> > This patch moves the et131x gigabit ethernet driver from drivers/staging
> > to drivers/net/ethernet/agere.
> >
> > All the existing issues noted for this driver have been
On Fri, Jan 18, 2013 at 02:57:06PM -0800, Greg KH wrote:
On Fri, Jan 18, 2013 at 08:40:47PM +, Mark Einon wrote:
This patch moves the et131x gigabit ethernet driver from drivers/staging
to drivers/net/ethernet/agere.
All the existing issues noted for this driver have been resolved,
On Fri, Jan 18, 2013 at 08:40:47PM +, Mark Einon wrote:
> This patch moves the et131x gigabit ethernet driver from drivers/staging
> to drivers/net/ethernet/agere.
>
> All the existing issues noted for this driver have been resolved, apart
> from one performance issue where some fragmented
On Fri, Jan 18, 2013 at 08:40:47PM +, Mark Einon wrote:
This patch moves the et131x gigabit ethernet driver from drivers/staging
to drivers/net/ethernet/agere.
All the existing issues noted for this driver have been resolved, apart
from one performance issue where some fragmented packets
30 matches
Mail list logo
