Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-15 Thread Roopa Prabhu
On 12/15/14, 6:40 AM, Thomas Graf wrote: On 12/15/14 at 02:29pm, Varlese, Marco wrote: All of these are highly generic and should *not* be passed through from user space to the driver directly but rather be properly abstracted as Roopa proposed. The value of this API is abstraction. How would y

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-15 Thread Roopa Prabhu
...@gmail.com; linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration On 12/12/14, 1:19 AM, Varlese, Marco wrote: -Original Message- From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com] Sent: Thursday, December 11, 2014 5:41 PM To: Jiri

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-15 Thread Thomas Graf
On 12/15/14 at 02:29pm, Varlese, Marco wrote: > > All of these are highly generic and should *not* be passed through from user > > space to the driver directly but rather be properly abstracted as Roopa > > proposed. The value of this API is abstraction. > How would you let the user enable/disable

RE: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-15 Thread Varlese, Marco
bend, John R; > ro...@cumulusnetworks.com; sfel...@gmail.com; linux- > ker...@vger.kernel.org > Subject: Re: [RFC PATCH net-next 1/1] net: Support for switch port > configuration > > On 12/11/14 at 09:59am, Varlese, Marco wrote: > > An example of attributes are: > > * enabling/disabling

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-15 Thread Thomas Graf
On 12/11/14 at 09:59am, Varlese, Marco wrote: > An example of attributes are: > * enabling/disabling of learning of source addresses on a given port (you can > imagine the attribute called LEARNING for example); > * internal loopback control (i.e. LOOPBACK) which will control how the flow > of tr

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-15 Thread Thomas Graf
On 12/10/14 at 04:23pm, Varlese, Marco wrote: > +#ifdef CONFIG_NET_SWITCHDEV > +static int do_setswcfg(struct net_device *dev, struct nlattr *attr) > +{ > + int rem, err = -EINVAL; > + struct nlattr *v; > + const struct net_device_ops *ops = dev->netdev_ops; > + > + nla_for_each_nes

RE: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-15 Thread Arad, Ronen
, December 15, 2014 1:40 AM > To: Roopa Prabhu > Cc: Jiri Pirko; John Fastabend; net...@vger.kernel.org; > step...@networkplumber.org; Fastabend, John R; sfel...@gmail.com; > linux-kernel@vger.kernel.org > Subject: RE: [RFC PATCH net-next 1/1] net: Support for switch port &g

RE: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-15 Thread Varlese, Marco
om; > linux-kernel@vger.kernel.org > Subject: Re: [RFC PATCH net-next 1/1] net: Support for switch port > configuration > > On 12/12/14, 1:19 AM, Varlese, Marco wrote: > >> -Original Message- > >> From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com] > >> S

RE: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-13 Thread Rosen, Rami
; Fastabend, John R; sfel...@gmail.com; linux-kernel@vger.kernel.org Subject: RE: [RFC PATCH net-next 1/1] net: Support for switch port configuration > -Original Message- > From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com] > Sent: Thursday, December 11, 2014 5:41 PM > To: Jir

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-12 Thread Roopa Prabhu
...@gmail.com; linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration On 12/11/14, 8:56 AM, Jiri Pirko wrote: Thu, Dec 11, 2014 at 05:37:46PM CET, ro...@cumulusnetworks.com wrote: On 12/11/14, 3:01 AM, Jiri Pirko wrote: Thu, Dec 11, 2014 at 10

RE: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-12 Thread Varlese, Marco
om; > linux-kernel@vger.kernel.org > Subject: Re: [RFC PATCH net-next 1/1] net: Support for switch port > configuration > > On 12/11/14, 8:56 AM, Jiri Pirko wrote: > > Thu, Dec 11, 2014 at 05:37:46PM CET, ro...@cumulusnetworks.com wrote: > >> On 12/11/14, 3:01 AM, Jiri Pirko

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread John Fastabend
co; net...@vger.kernel.org; >>>>>> step...@networkplumber.org; Fastabend, John R; >>>>>> ro...@cumulusnetworks.com; sfel...@gmail.com; linux- >>>>>> ker...@vger.kernel.org >>>>>> Subject: Re: [RFC PATCH net-next 1/1] net: Support for s

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Jiri Pirko
ese, Marco; net...@vger.kernel.org; >>>>>>step...@networkplumber.org; Fastabend, John R; >>>>>>ro...@cumulusnetworks.com; sfel...@gmail.com; linux- >>>>>>ker...@vger.kernel.org >>>>>>Subject: Re: [RFC PATCH net-next 1/1] net: S

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Roopa Prabhu
...@gmail.com] Sent: Wednesday, December 10, 2014 5:04 PM To: Jiri Pirko Cc: Varlese, Marco; net...@vger.kernel.org; step...@networkplumber.org; Fastabend, John R; ro...@cumulusnetworks.com; sfel...@gmail.com; linux- ker...@vger.kernel.org Subject: Re: [RFC PATCH net-next 1/1] net: Support for switch port

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Jiri Pirko
..@gmail.com] >>>>Sent: Wednesday, December 10, 2014 5:04 PM >>>>To: Jiri Pirko >>>>Cc: Varlese, Marco; net...@vger.kernel.org; >>>>step...@networkplumber.org; Fastabend, John R; >>>>ro...@cumulusnetworks.com; sfel...@gmail.com; linux- >

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Roopa Prabhu
; step...@networkplumber.org; Fastabend, John R; ro...@cumulusnetworks.com; sfel...@gmail.com; linux- ker...@vger.kernel.org Subject: Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration On 12/10/2014 08:50 AM, Jiri Pirko wrote: Wed, Dec 10, 2014 at 05:23:40PM CET, marco.varl

RE: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Varlese, Marco
stabend, John R; > ro...@cumulusnetworks.com; sfel...@gmail.com; linux- > ker...@vger.kernel.org > Subject: Re: [RFC PATCH net-next 1/1] net: Support for switch port > configuration > > Thu, Dec 11, 2014 at 01:02:36PM CET, marco.varl...@intel.com wrote: > >> -Origi

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Jiri Pirko
>> step...@networkplumber.org; Fastabend, John R; >> ro...@cumulusnetworks.com; sfel...@gmail.com; linux- >> ker...@vger.kernel.org >> Subject: Re: [RFC PATCH net-next 1/1] net: Support for switch port >> configuration >> >> Thu, Dec 11, 2014 at 10:59:42AM CET, ma

RE: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Varlese, Marco
ail.com; linux- > ker...@vger.kernel.org > Subject: Re: [RFC PATCH net-next 1/1] net: Support for switch port > configuration > > Thu, Dec 11, 2014 at 10:59:42AM CET, marco.varl...@intel.com wrote: > >> -Original Message- > >> From: John Fastabend [mailto:john.

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Jiri Pirko
>> step...@networkplumber.org; Fastabend, John R; >> ro...@cumulusnetworks.com; sfel...@gmail.com; linux- >> ker...@vger.kernel.org >> Subject: Re: [RFC PATCH net-next 1/1] net: Support for switch port >> configuration >> >> On 12/10/2014 08:50 AM

RE: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Varlese, Marco
l...@gmail.com; linux- > ker...@vger.kernel.org > Subject: Re: [RFC PATCH net-next 1/1] net: Support for switch port > configuration > > On 12/10/2014 08:50 AM, Jiri Pirko wrote: > > Wed, Dec 10, 2014 at 05:23:40PM CET, marco.varl...@intel.com wrote: > >> From: Marco

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-10 Thread John Fastabend
On 12/10/2014 08:50 AM, Jiri Pirko wrote: Wed, Dec 10, 2014 at 05:23:40PM CET, marco.varl...@intel.com wrote: From: Marco Varlese Switch hardware offers a list of attributes that are configurable on a per port basis. This patch provides a mechanism to configure switch ports by adding an NDO fo

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-10 Thread Jiri Pirko
Wed, Dec 10, 2014 at 05:23:40PM CET, marco.varl...@intel.com wrote: >From: Marco Varlese > >Switch hardware offers a list of attributes that are configurable >on a per port basis. >This patch provides a mechanism to configure switch ports by adding >an NDO for setting specific values to specific a

[RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-10 Thread Varlese, Marco
From: Marco Varlese Switch hardware offers a list of attributes that are configurable on a per port basis. This patch provides a mechanism to configure switch ports by adding an NDO for setting specific values to specific attributes. There will be a separate patch that extends iproute2 to call th