Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-05 Thread Joe Perches
On Tue, 2020-10-06 at 00:34 +, Joel Stanley wrote: > arch/powerpc/boot is the powerpc wrapper, and it's not built with the > same includes or flags as the rest of the kernel. It doesn't include > any of the headers in the top level include/ directory for hysterical > raisins. > > The

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-05 Thread Joel Stanley
On Thu, 1 Oct 2020 at 20:19, Joe Perches wrote: > > On Thu, 2020-10-01 at 14:39 -0500, Segher Boessenkool wrch/ote: > > Hi! > > > > On Thu, Oct 01, 2020 at 12:15:39PM +0200, Miguel Ojeda wrote: > > > > So it looks like the best option is to exclude these > > > > 2 files from conversion. > > > > >

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-05 Thread Joe Perches
On Mon, 2020-10-05 at 11:36 -0700, Nick Desaulniers wrote: > I don't think there's anything wrong with manually including it and adding `-I > ` (capital i) if needed. All of this is secondary to the actual change to use quoted __section("foo") rather than __section(foo) I'd rather get that done

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-05 Thread Nick Desaulniers
On Thu, Oct 1, 2020 at 1:19 PM Joe Perches wrote: > > On Thu, 2020-10-01 at 14:39 -0500, Segher Boessenkool wrch/ote: > > Hi! > > > > On Thu, Oct 01, 2020 at 12:15:39PM +0200, Miguel Ojeda wrote: > > > > So it looks like the best option is to exclude these > > > > 2 files from conversion. > > > >

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-01 Thread Joe Perches
On Thu, 2020-10-01 at 14:39 -0500, Segher Boessenkool wrch/ote: > Hi! > > On Thu, Oct 01, 2020 at 12:15:39PM +0200, Miguel Ojeda wrote: > > > So it looks like the best option is to exclude these > > > 2 files from conversion. > > > > Agreed. Nevertheless, is there any reason arch/powerpc/*

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-01 Thread Segher Boessenkool
Hi! On Thu, Oct 01, 2020 at 12:15:39PM +0200, Miguel Ojeda wrote: > > So it looks like the best option is to exclude these > > 2 files from conversion. > > Agreed. Nevertheless, is there any reason arch/powerpc/* should not be > compiling cleanly with compiler.h? (CC'ing the rest of the PowerPC

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-01 Thread Joe Perches
On Thu, 2020-10-01 at 12:15 +0200, Miguel Ojeda wrote: > Hi Joe, Buenas Miguel. > On Thu, Oct 1, 2020 at 12:56 AM Joe Perches wrote: > > So I installed the powerpc cross compiler, and > > nope, that doesn't work, it makes a mess. > > Thanks a lot for reviving the script and sending the

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-01 Thread Miguel Ojeda
Hi Joe, On Thu, Oct 1, 2020 at 12:56 AM Joe Perches wrote: > > So I installed the powerpc cross compiler, and > nope, that doesn't work, it makes a mess. Thanks a lot for reviving the script and sending the treewide cleanup! > So it looks like the best option is to exclude these > 2 files from

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-09-30 Thread Joe Perches
On Wed, 2020-09-30 at 15:25 -0700, Joe Perches wrote: > On Wed, 2020-09-30 at 15:20 -0700, Nick Desaulniers wrote: > > On Wed, Sep 30, 2020 at 3:06 PM Joe Perches wrote: > > > On Wed, 2020-09-30 at 14:40 -0700, Nick Desaulniers wrote: > > > > On Wed, Sep 30, 2020 at 12:16 PM Joe Perches wrote: >

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-09-30 Thread Joe Perches
On Wed, 2020-09-30 at 15:20 -0700, Nick Desaulniers wrote: > On Wed, Sep 30, 2020 at 3:06 PM Joe Perches wrote: > > On Wed, 2020-09-30 at 14:40 -0700, Nick Desaulniers wrote: > > > On Wed, Sep 30, 2020 at 12:16 PM Joe Perches wrote: > > > > Use a more generic form for __section that requires

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-09-30 Thread Nick Desaulniers
On Wed, Sep 30, 2020 at 3:06 PM Joe Perches wrote: > > On Wed, 2020-09-30 at 14:40 -0700, Nick Desaulniers wrote: > > On Wed, Sep 30, 2020 at 12:16 PM Joe Perches wrote: > > > Use a more generic form for __section that requires quotes to avoid > > > complications with clang and gcc differences.

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-09-30 Thread Joe Perches
On Wed, 2020-09-30 at 15:06 -0700, Joe Perches wrote: > Perhaps these are also possible files that need exclusions: > > ./arch/x86/boot/video.h:#define __videocard struct card_info > __section(".videocards") __attribute__((used)) > ./arch/x86/boot/compressed/pgtable_64.c:unsigned long

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-09-30 Thread Joe Perches
On Wed, 2020-09-30 at 14:40 -0700, Nick Desaulniers wrote: > On Wed, Sep 30, 2020 at 12:16 PM Joe Perches wrote: > > Use a more generic form for __section that requires quotes to avoid > > complications with clang and gcc differences. > > > > Remove the quote operator # from

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-09-30 Thread Nick Desaulniers
On Wed, Sep 30, 2020 at 12:16 PM Joe Perches wrote: > > Use a more generic form for __section that requires quotes to avoid > complications with clang and gcc differences. > > Remove the quote operator # from compiler_attributes.h __section macro. > > Convert all unquoted __section(foo) uses to

[RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-09-30 Thread Joe Perches
Use a more generic form for __section that requires quotes to avoid complications with clang and gcc differences. Remove the quote operator # from compiler_attributes.h __section macro. Convert all unquoted __section(foo) uses to quoted __section("foo"). Also convert