Re: [RFC PATCH v1] PCI: qcom: Use quirk to override incorrect device class

2019-05-02 Thread Marc Gonzalez
On 30/04/2019 16:06, Lorenzo Pieralisi wrote: > On Tue, Mar 12, 2019 at 06:34:55PM +0100, Marc Gonzalez wrote: > >> On 12/03/2019 18:18, Marc Gonzalez wrote: >> >>> On 12/03/2019 13:42, Stanimir Varbanov wrote: >>> I wonder, in case that dw_pcie_setup_rc() already has a write to

Re: [RFC PATCH v1] PCI: qcom: Use quirk to override incorrect device class

2019-04-30 Thread Lorenzo Pieralisi
On Tue, Mar 12, 2019 at 06:34:55PM +0100, Marc Gonzalez wrote: > On 12/03/2019 18:18, Marc Gonzalez wrote: > > > On 12/03/2019 13:42, Stanimir Varbanov wrote: > > > >> I wonder, in case that dw_pcie_setup_rc() already has a write to > >> PCI_CLASS_DEVICE configuration register to set it as a

Re: [RFC PATCH v1] PCI: qcom: Use quirk to override incorrect device class

2019-03-12 Thread Marc Gonzalez
On 12/03/2019 18:18, Marc Gonzalez wrote: > On 12/03/2019 13:42, Stanimir Varbanov wrote: > >> I wonder, in case that dw_pcie_setup_rc() already has a write to >> PCI_CLASS_DEVICE configuration register to set it as a bridge do we >> still need to do the above fixup? > > I don't know, I don't

Re: [RFC PATCH v1] PCI: qcom: Use quirk to override incorrect device class

2019-03-12 Thread Marc Gonzalez
On 12/03/2019 13:42, Stanimir Varbanov wrote: > On 3/11/19 4:56 PM, Marc Gonzalez wrote: > >> Some chips report an incorrect device class. Override the incorrect >> value using a quirk, instead of code in the read function. >> >> Signed-off-by: Marc Gonzalez >> --- >> FWIW, this quirk is no

Re: [RFC PATCH v1] PCI: qcom: Use quirk to override incorrect device class

2019-03-12 Thread Stanimir Varbanov
Hi Marc, Thanks for the patch! On 3/11/19 4:56 PM, Marc Gonzalez wrote: > Some chips report an incorrect device class. Override the incorrect > value using a quirk, instead of code in the read function. > > Signed-off-by: Marc Gonzalez > --- > FWIW, this quirk is no longer required on recent

[RFC PATCH v1] PCI: qcom: Use quirk to override incorrect device class

2019-03-11 Thread Marc Gonzalez
Some chips report an incorrect device class. Override the incorrect value using a quirk, instead of code in the read function. Signed-off-by: Marc Gonzalez --- FWIW, this quirk is no longer required on recent chips: msm8996 (tested by Stanimir), msm8998 (tested by me), sdm845 (untested) are