Re: [RFC PATCH v1 03/13] regulator: bd718x7 use chip specific and generic data structs

2019-01-24 Thread Mark Brown
On Thu, Jan 24, 2019 at 09:16:35AM +0200, Matti Vaittinen wrote: > Yes. If we don't want to break the compilation between commits then > the patches 2, 3 and 4 should be squashed into one. I sent them as > separare changes for easier review. I can squash them and send them > squashed if they are

Re: [RFC PATCH v1 03/13] regulator: bd718x7 use chip specific and generic data structs

2019-01-23 Thread Matti Vaittinen
Hello Mark, Thanks again for looking through my changes =) On Wed, Jan 23, 2019 at 03:51:21PM +, Mark Brown wrote: > On Tue, Jan 22, 2019 at 11:43:28AM +0200, Matti Vaittinen wrote: > > Header rohm-bd718x7.h was split to generic and component specific > > parts. This changed the struct

Re: [RFC PATCH v1 03/13] regulator: bd718x7 use chip specific and generic data structs

2019-01-23 Thread Mark Brown
On Tue, Jan 22, 2019 at 11:43:28AM +0200, Matti Vaittinen wrote: > Header rohm-bd718x7.h was split to generic and component specific > parts. This changed the struct bd718x7. Adapt the regulator driver to > these changes. Acked-by: Mark Brown Does this need to be squashed into the earlier

[RFC PATCH v1 03/13] regulator: bd718x7 use chip specific and generic data structs

2019-01-22 Thread Matti Vaittinen
Header rohm-bd718x7.h was split to generic and component specific parts. This changed the struct bd718x7. Adapt the regulator driver to these changes. Signed-off-by: Matti Vaittinen --- drivers/regulator/bd718x7-regulator.c | 22 +++--- 1 file changed, 11 insertions(+), 11