Re: [RFC PATCH v1 04/11] sched/idle: make the fast idle path for short idle periods

2017-07-12 Thread Peter Zijlstra
On Tue, Jul 11, 2017 at 06:33:55PM +0200, Frederic Weisbecker wrote: > if (!tick_nohz_full_cpu(smp_processor_id()) && likely(predicted_idle_us < > short_idle_threshold)) > cpuidle_fast(); > > Ugly but safer! I'd not overly worry about this, cpuidle_fast() isn't anything that's likely

Re: [RFC PATCH v1 04/11] sched/idle: make the fast idle path for short idle periods

2017-07-11 Thread Li, Aubrey
On 2017/7/12 13:03, Paul E. McKenney wrote: > On Wed, Jul 12, 2017 at 11:19:59AM +0800, Li, Aubrey wrote: >> On 2017/7/12 2:11, Paul E. McKenney wrote: >>> On Tue, Jul 11, 2017 at 06:33:55PM +0200, Frederic Weisbecker wrote: On Tue, Jul 11, 2017 at 05:58:47AM -0700, Paul E. McKenney wrote: >

Re: [RFC PATCH v1 04/11] sched/idle: make the fast idle path for short idle periods

2017-07-11 Thread Paul E. McKenney
On Wed, Jul 12, 2017 at 11:19:59AM +0800, Li, Aubrey wrote: > On 2017/7/12 2:11, Paul E. McKenney wrote: > > On Tue, Jul 11, 2017 at 06:33:55PM +0200, Frederic Weisbecker wrote: > >> On Tue, Jul 11, 2017 at 05:58:47AM -0700, Paul E. McKenney wrote: > >>> On Mon, Jul 10, 2017 at 09:38:34AM +0800, Au

Re: [RFC PATCH v1 04/11] sched/idle: make the fast idle path for short idle periods

2017-07-11 Thread Li, Aubrey
On 2017/7/12 2:11, Paul E. McKenney wrote: > On Tue, Jul 11, 2017 at 06:33:55PM +0200, Frederic Weisbecker wrote: >> On Tue, Jul 11, 2017 at 05:58:47AM -0700, Paul E. McKenney wrote: >>> On Mon, Jul 10, 2017 at 09:38:34AM +0800, Aubrey Li wrote: From: Aubrey Li The system will enter

Re: [RFC PATCH v1 04/11] sched/idle: make the fast idle path for short idle periods

2017-07-11 Thread Paul E. McKenney
On Tue, Jul 11, 2017 at 06:33:55PM +0200, Frederic Weisbecker wrote: > On Tue, Jul 11, 2017 at 05:58:47AM -0700, Paul E. McKenney wrote: > > On Mon, Jul 10, 2017 at 09:38:34AM +0800, Aubrey Li wrote: > > > From: Aubrey Li > > > > > > The system will enter a fast idle loop if the predicted idle pe

Re: [RFC PATCH v1 04/11] sched/idle: make the fast idle path for short idle periods

2017-07-11 Thread Frederic Weisbecker
On Tue, Jul 11, 2017 at 05:58:47AM -0700, Paul E. McKenney wrote: > On Mon, Jul 10, 2017 at 09:38:34AM +0800, Aubrey Li wrote: > > From: Aubrey Li > > > > The system will enter a fast idle loop if the predicted idle period > > is shorter than the threshold. > > --- > > kernel/sched/idle.c | 9 ++

Re: [RFC PATCH v1 04/11] sched/idle: make the fast idle path for short idle periods

2017-07-11 Thread Paul E. McKenney
On Mon, Jul 10, 2017 at 09:38:34AM +0800, Aubrey Li wrote: > From: Aubrey Li > > The system will enter a fast idle loop if the predicted idle period > is shorter than the threshold. > --- > kernel/sched/idle.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/kern

[RFC PATCH v1 04/11] sched/idle: make the fast idle path for short idle periods

2017-07-09 Thread Aubrey Li
From: Aubrey Li The system will enter a fast idle loop if the predicted idle period is shorter than the threshold. --- kernel/sched/idle.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c index cf6c11f..16a766c 100644 --- a/ker