Re: [RFC PATCH v1 2/6] kernel-doc: replace kernel-doc perl parser with a pure python one (WIP)

2017-01-27 Thread Markus Heiser
Am 26.01.2017 um 20:26 schrieb Jani Nikula : > On Thu, 26 Jan 2017, Jonathan Corbet wrote: >> Give me a new kerneldoc that passes those tests, and I'll happily >> merge it. (I have some sympathy with the idea that we should look >> into other parsers, but I would not hold up a new kerneldoc tha

Re: [RFC PATCH v1 2/6] kernel-doc: replace kernel-doc perl parser with a pure python one (WIP)

2017-01-26 Thread Jani Nikula
On Thu, 26 Jan 2017, Jonathan Corbet wrote: > Give me a new kerneldoc that passes those tests, and I'll happily > merge it. (I have some sympathy with the idea that we should look > into other parsers, but I would not hold up a new kerneldoc that > passed those tests on this basis alone.) I'll j

Re: [RFC PATCH v1 2/6] kernel-doc: replace kernel-doc perl parser with a pure python one (WIP)

2017-01-26 Thread Jonathan Corbet
On Wed, 25 Jan 2017 20:07:47 +0100 Markus Heiser wrote: > So, what I mean is, the new parser has to generate a complete different reST > output and thats why we can't compare the perl parser with python one on a > reST > basis ... and if reST is different, HTML is different :( > > So we do not

Re: [RFC PATCH v1 2/6] kernel-doc: replace kernel-doc perl parser with a pure python one (WIP)

2017-01-26 Thread Jani Nikula
On Thu, 26 Jan 2017, Markus Heiser wrote: > Am 25.01.2017 um 21:59 schrieb Jani Nikula : > >>> But the problem I see here is, that the perl script generates a >>> reST output which I can't use. As an example we can take a look at >>> the man-page builder I shipped in the series. >> >> Sorry, I st

Re: [RFC PATCH v1 2/6] kernel-doc: replace kernel-doc perl parser with a pure python one (WIP)

2017-01-26 Thread Markus Heiser
Am 25.01.2017 um 21:59 schrieb Jani Nikula : >> But the problem I see here is, that the perl script generates a >> reST output which I can't use. As an example we can take a look at >> the man-page builder I shipped in the series. > > Sorry, I still don't understand *why* you can't use the same

Re: [RFC PATCH v1 2/6] kernel-doc: replace kernel-doc perl parser with a pure python one (WIP)

2017-01-25 Thread Jani Nikula
On Wed, 25 Jan 2017, Markus Heiser wrote: > Am 25.01.2017 um 11:24 schrieb Jani Nikula : > >> Markus, thanks for your work on this. > > Thanks for your comments! > >> Excuse me for my bluntness, but I think changing everything in a single >> commit, or even a few commits, is strictly not acceptabl

Re: [RFC PATCH v1 2/6] kernel-doc: replace kernel-doc perl parser with a pure python one (WIP)

2017-01-25 Thread Markus Heiser
Am 25.01.2017 um 11:24 schrieb Jani Nikula : > Markus, thanks for your work on this. Thanks for your comments! > Excuse me for my bluntness, but I think changing everything in a single > commit, or even a few commits, is strictly not acceptable. OK, I understand. > When I changed *small* thin

Re: [RFC PATCH v1 2/6] kernel-doc: replace kernel-doc perl parser with a pure python one (WIP)

2017-01-25 Thread Daniel Vetter
On Wed, Jan 25, 2017 at 12:24:31PM +0200, Jani Nikula wrote: > Finally, while I'd love to see scripts/kernel-doc go, I do have to ask > if changing roughly 3k lines of Perl to roughly 3k lines of Python (*) > really makes everything better? They both still parse everything using a > large pile of r

Re: [RFC PATCH v1 2/6] kernel-doc: replace kernel-doc perl parser with a pure python one (WIP)

2017-01-25 Thread Jani Nikula
On Wed, 25 Jan 2017, Jonathan Corbet wrote: > On Tue, 24 Jan 2017 20:52:40 +0100 > Markus Heiser wrote: > >> This patch is the initial merge of a pure python implementation >> to parse kernel-doc comments and generate reST from. >> >> It consist mainly of to parts, the parser module (kerneldoc.p

Re: [RFC PATCH v1 2/6] kernel-doc: replace kernel-doc perl parser with a pure python one (WIP)

2017-01-24 Thread Markus Heiser
Hi Jon, hi Daniel ! Am 25.01.2017 um 07:37 schrieb Daniel Vetter : >> Again, quick comments... >> >> - I would *much* rather evolve our existing Sphinx extension in the >> direction we want it to go than to just replace it wholesale. >> Replacement is the wrong approach for a few reasons, in

Re: [RFC PATCH v1 2/6] kernel-doc: replace kernel-doc perl parser with a pure python one (WIP)

2017-01-24 Thread Daniel Vetter
On Tue, Jan 24, 2017 at 05:13:14PM -0700, Jonathan Corbet wrote: > On Tue, 24 Jan 2017 20:52:40 +0100 > Markus Heiser wrote: > > > This patch is the initial merge of a pure python implementation > > to parse kernel-doc comments and generate reST from. > > > > It consist mainly of to parts, the p

Re: [RFC PATCH v1 2/6] kernel-doc: replace kernel-doc perl parser with a pure python one (WIP)

2017-01-24 Thread Jonathan Corbet
On Tue, 24 Jan 2017 20:52:40 +0100 Markus Heiser wrote: > This patch is the initial merge of a pure python implementation > to parse kernel-doc comments and generate reST from. > > It consist mainly of to parts, the parser module (kerneldoc.py) and the > sphinx-doc extension (rstKernelDoc.py). F