Re: [RFC PATCH v1 2/8] zram: avoid invalid memory access in zram_exit()

2013-06-04 Thread Jiang Liu
On Tue 04 Jun 2013 05:03:09 PM CST, Minchan Kim wrote: > On Mon, Jun 03, 2013 at 11:42:14PM +0800, Jiang Liu wrote: >> Memory for zram->disk object may have already been freed after returning >> from destroy_device(zram), then it's unsafe for zram_reset_device(zram) >> to access zram->disk again. >

Re: [RFC PATCH v1 2/8] zram: avoid invalid memory access in zram_exit()

2013-06-04 Thread Minchan Kim
On Mon, Jun 03, 2013 at 11:42:14PM +0800, Jiang Liu wrote: > Memory for zram->disk object may have already been freed after returning > from destroy_device(zram), then it's unsafe for zram_reset_device(zram) > to access zram->disk again. > > Fix it by holding an extra reference to zram->disk befor

[RFC PATCH v1 2/8] zram: avoid invalid memory access in zram_exit()

2013-06-03 Thread Jiang Liu
Memory for zram->disk object may have already been freed after returning from destroy_device(zram), then it's unsafe for zram_reset_device(zram) to access zram->disk again. Fix it by holding an extra reference to zram->disk before calling destroy_device(zram). Signed-off-by: Jiang Liu --- drive