Re: [RFC PATCH v1 4/8] zram: destroy all devices on error recovery path in zram_init()

2013-06-04 Thread Jiang Liu
On Tue 04 Jun 2013 04:49:16 PM CST, Dan Carpenter wrote: > Everyone stop putting RFC on their bugfixes! :P No one wants to > pre-review patches. > > On Mon, Jun 03, 2013 at 11:42:16PM +0800, Jiang Liu wrote: >> On error recovery path of zram_init(), it leaks the zram device object >> causing the

Re: [RFC PATCH v1 4/8] zram: destroy all devices on error recovery path in zram_init()

2013-06-04 Thread Dan Carpenter
Everyone stop putting RFC on their bugfixes! :P No one wants to pre-review patches. On Mon, Jun 03, 2013 at 11:42:16PM +0800, Jiang Liu wrote: > On error recovery path of zram_init(), it leaks the zram device object > causing the failure. > This is a real bug but the fix isn't right. The obje

[RFC PATCH v1 4/8] zram: destroy all devices on error recovery path in zram_init()

2013-06-03 Thread Jiang Liu
On error recovery path of zram_init(), it leaks the zram device object causing the failure. Signed-off-by: Jiang Liu --- drivers/staging/zram/zram_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c index