Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-06-09 Thread Petr Mladek
On Thu 2016-04-28 13:53:53, Josh Poimboeuf wrote: > On Tue, Apr 05, 2016 at 08:44:30AM -0500, Josh Poimboeuf wrote: > > On Fri, Apr 01, 2016 at 03:39:44PM +0200, Petr Mladek wrote: > > > > There's also a func->immediate flag which allows users to specify that > > > > certain functions in the patch

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-06-09 Thread Petr Mladek
On Thu 2016-04-28 13:53:53, Josh Poimboeuf wrote: > On Tue, Apr 05, 2016 at 08:44:30AM -0500, Josh Poimboeuf wrote: > > On Fri, Apr 01, 2016 at 03:39:44PM +0200, Petr Mladek wrote: > > > > There's also a func->immediate flag which allows users to specify that > > > > certain functions in the patch

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-28 Thread Josh Poimboeuf
On Tue, Apr 05, 2016 at 08:44:30AM -0500, Josh Poimboeuf wrote: > On Fri, Apr 01, 2016 at 03:39:44PM +0200, Petr Mladek wrote: > > > There's also a func->immediate flag which allows users to specify that > > > certain functions in the patch can be applied without per-task > > > consistency. This

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-28 Thread Josh Poimboeuf
On Tue, Apr 05, 2016 at 08:44:30AM -0500, Josh Poimboeuf wrote: > On Fri, Apr 01, 2016 at 03:39:44PM +0200, Petr Mladek wrote: > > > There's also a func->immediate flag which allows users to specify that > > > certain functions in the patch can be applied without per-task > > > consistency. This

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-07 Thread Jiri Kosina
On Thu, 7 Apr 2016, Josh Poimboeuf wrote: > > I admittedly forgot what the "ftrace handler switching idea" is, and am > > not sure where exactly to look for it (could you please point it to me so > > that I can refresh my memory) > > Here's where I originally described it [1]: Thanks! > | 2)

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-07 Thread Jiri Kosina
On Thu, 7 Apr 2016, Josh Poimboeuf wrote: > > I admittedly forgot what the "ftrace handler switching idea" is, and am > > not sure where exactly to look for it (could you please point it to me so > > that I can refresh my memory) > > Here's where I originally described it [1]: Thanks! > | 2)

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-07 Thread Josh Poimboeuf
On Thu, Apr 07, 2016 at 05:47:00PM +0200, Jiri Kosina wrote: > On Thu, 7 Apr 2016, Josh Poimboeuf wrote: > > > > > - try ftrace handler switching idea from v1 cover letter > [ ... ] > > > We probably should not check the stack in atomic context > > > > Can you elaborate why not? > > I

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-07 Thread Josh Poimboeuf
On Thu, Apr 07, 2016 at 05:47:00PM +0200, Jiri Kosina wrote: > On Thu, 7 Apr 2016, Josh Poimboeuf wrote: > > > > > - try ftrace handler switching idea from v1 cover letter > [ ... ] > > > We probably should not check the stack in atomic context > > > > Can you elaborate why not? > > I

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-07 Thread Jiri Kosina
On Thu, 7 Apr 2016, Josh Poimboeuf wrote: > > > - try ftrace handler switching idea from v1 cover letter [ ... ] > > We probably should not check the stack in atomic context > > Can you elaborate why not? I admittedly forgot what the "ftrace handler switching idea" is, and am not sure where

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-07 Thread Jiri Kosina
On Thu, 7 Apr 2016, Josh Poimboeuf wrote: > > > - try ftrace handler switching idea from v1 cover letter [ ... ] > > We probably should not check the stack in atomic context > > Can you elaborate why not? I admittedly forgot what the "ftrace handler switching idea" is, and am not sure where

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-07 Thread Josh Poimboeuf
On Thu, Apr 07, 2016 at 02:10:30PM +0200, Petr Mladek wrote: > On Fri 2016-03-25 14:34:47, Josh Poimboeuf wrote: > > TODO: > > - try ftrace handler switching idea from v1 cover letter > > I have had a discussion about it with Mirek. This would help with > kthreads. If they are sleeping in a

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-07 Thread Josh Poimboeuf
On Thu, Apr 07, 2016 at 02:10:30PM +0200, Petr Mladek wrote: > On Fri 2016-03-25 14:34:47, Josh Poimboeuf wrote: > > TODO: > > - try ftrace handler switching idea from v1 cover letter > > I have had a discussion about it with Mirek. This would help with > kthreads. If they are sleeping in a

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-07 Thread Petr Mladek
On Fri 2016-03-25 14:34:47, Josh Poimboeuf wrote: > TODO: > - try ftrace handler switching idea from v1 cover letter I have had a discussion about it with Mirek. This would help with kthreads. If they are sleeping in a patched function, we wake them up, this will help to migrate them before they

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-07 Thread Petr Mladek
On Fri 2016-03-25 14:34:47, Josh Poimboeuf wrote: > TODO: > - try ftrace handler switching idea from v1 cover letter I have had a discussion about it with Mirek. This would help with kthreads. If they are sleeping in a patched function, we wake them up, this will help to migrate them before they

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-06 Thread Petr Mladek
On Tue 2016-04-05 08:44:30, Josh Poimboeuf wrote: > On Fri, Apr 01, 2016 at 03:39:44PM +0200, Petr Mladek wrote: > > On Fri 2016-03-25 14:34:47, Josh Poimboeuf wrote: > > > - update documentation for sysfs, proc, livepatch > > > > Also we should publish somewhere the information about

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-06 Thread Petr Mladek
On Tue 2016-04-05 08:44:30, Josh Poimboeuf wrote: > On Fri, Apr 01, 2016 at 03:39:44PM +0200, Petr Mladek wrote: > > On Fri 2016-03-25 14:34:47, Josh Poimboeuf wrote: > > > - update documentation for sysfs, proc, livepatch > > > > Also we should publish somewhere the information about

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-05 Thread Miroslav Benes
On Tue, 5 Apr 2016, Josh Poimboeuf wrote: > On Tue, Apr 05, 2016 at 04:24:33PM +0200, Miroslav Benes wrote: > > On Mon, 4 Apr 2016, Josh Poimboeuf wrote: > > > > > > I'd add a fake signal facility for sleeping non-migrated tasks. This > > > > would accelerate a migration to a new universe. We

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-05 Thread Miroslav Benes
On Tue, 5 Apr 2016, Josh Poimboeuf wrote: > On Tue, Apr 05, 2016 at 04:24:33PM +0200, Miroslav Benes wrote: > > On Mon, 4 Apr 2016, Josh Poimboeuf wrote: > > > > > > I'd add a fake signal facility for sleeping non-migrated tasks. This > > > > would accelerate a migration to a new universe. We

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-05 Thread Josh Poimboeuf
On Tue, Apr 05, 2016 at 04:24:33PM +0200, Miroslav Benes wrote: > On Mon, 4 Apr 2016, Josh Poimboeuf wrote: > > > > I'd add a fake signal facility for sleeping non-migrated tasks. This > > > would accelerate a migration to a new universe. We have it in kgraft for > > > quite some time and it

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-05 Thread Josh Poimboeuf
On Tue, Apr 05, 2016 at 04:24:33PM +0200, Miroslav Benes wrote: > On Mon, 4 Apr 2016, Josh Poimboeuf wrote: > > > > I'd add a fake signal facility for sleeping non-migrated tasks. This > > > would accelerate a migration to a new universe. We have it in kgraft for > > > quite some time and it

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-05 Thread Miroslav Benes
On Mon, 4 Apr 2016, Josh Poimboeuf wrote: > > I'd add a fake signal facility for sleeping non-migrated tasks. This > > would accelerate a migration to a new universe. We have it in kgraft for > > quite some time and it worked out great. See > >

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-05 Thread Miroslav Benes
On Mon, 4 Apr 2016, Josh Poimboeuf wrote: > > I'd add a fake signal facility for sleeping non-migrated tasks. This > > would accelerate a migration to a new universe. We have it in kgraft for > > quite some time and it worked out great. See > >

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-05 Thread Josh Poimboeuf
On Fri, Apr 01, 2016 at 03:39:44PM +0200, Petr Mladek wrote: > On Fri 2016-03-25 14:34:47, Josh Poimboeuf wrote: > > These patches are still a work in progress, but Jiri asked that I share > > them before I go on vacation next week. Based on origin/master because > > it has

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-05 Thread Josh Poimboeuf
On Fri, Apr 01, 2016 at 03:39:44PM +0200, Petr Mladek wrote: > On Fri 2016-03-25 14:34:47, Josh Poimboeuf wrote: > > These patches are still a work in progress, but Jiri asked that I share > > them before I go on vacation next week. Based on origin/master because > > it has

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-04 Thread Josh Poimboeuf
On Thu, Mar 31, 2016 at 02:54:26PM +0200, Miroslav Benes wrote: > > Hi, > > this is a great work. I'll have to review it properly (especially 13/14, > probably several times as it is a heavy stuff), but I've gathered some > notes so there they are. > > On Fri, 25 Mar 2016, Josh Poimboeuf

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-04 Thread Josh Poimboeuf
On Thu, Mar 31, 2016 at 02:54:26PM +0200, Miroslav Benes wrote: > > Hi, > > this is a great work. I'll have to review it properly (especially 13/14, > probably several times as it is a heavy stuff), but I've gathered some > notes so there they are. > > On Fri, 25 Mar 2016, Josh Poimboeuf

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-01 Thread Petr Mladek
On Fri 2016-04-01 15:39:44, Petr Mladek wrote: > On Fri 2016-03-25 14:34:47, Josh Poimboeuf wrote: > > These patches are still a work in progress, but Jiri asked that I share > > them before I go on vacation next week. Based on origin/master because > > it has CONFIG_STACK_VALIDATION. > > I have

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-01 Thread Petr Mladek
On Fri 2016-04-01 15:39:44, Petr Mladek wrote: > On Fri 2016-03-25 14:34:47, Josh Poimboeuf wrote: > > These patches are still a work in progress, but Jiri asked that I share > > them before I go on vacation next week. Based on origin/master because > > it has CONFIG_STACK_VALIDATION. > > I have

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-01 Thread Petr Mladek
On Fri 2016-03-25 14:34:47, Josh Poimboeuf wrote: > These patches are still a work in progress, but Jiri asked that I share > them before I go on vacation next week. Based on origin/master because > it has CONFIG_STACK_VALIDATION. I have to follow Mirek and say that it is a great work. >

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-01 Thread Petr Mladek
On Fri 2016-03-25 14:34:47, Josh Poimboeuf wrote: > These patches are still a work in progress, but Jiri asked that I share > them before I go on vacation next week. Based on origin/master because > it has CONFIG_STACK_VALIDATION. I have to follow Mirek and say that it is a great work. >

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-01 Thread Miroslav Benes
> - actually test it I did slightly and it partially worked and partially it did not. When I applied sample livepatch module, /proc/cmdline was patched and when I called 'cat /proc/cmdline' I got the correct livepatched message. So far so good. But the patching itself never finished because

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-04-01 Thread Miroslav Benes
> - actually test it I did slightly and it partially worked and partially it did not. When I applied sample livepatch module, /proc/cmdline was patched and when I called 'cat /proc/cmdline' I got the correct livepatched message. So far so good. But the patching itself never finished because

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-03-31 Thread Miroslav Benes
Hi, this is a great work. I'll have to review it properly (especially 13/14, probably several times as it is a heavy stuff), but I've gathered some notes so there they are. On Fri, 25 Mar 2016, Josh Poimboeuf wrote: > These patches are still a work in progress, but Jiri asked that I share >

Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-03-31 Thread Miroslav Benes
Hi, this is a great work. I'll have to review it properly (especially 13/14, probably several times as it is a heavy stuff), but I've gathered some notes so there they are. On Fri, 25 Mar 2016, Josh Poimboeuf wrote: > These patches are still a work in progress, but Jiri asked that I share >

[RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-03-25 Thread Josh Poimboeuf
These patches are still a work in progress, but Jiri asked that I share them before I go on vacation next week. Based on origin/master because it has CONFIG_STACK_VALIDATION. This has two consistency models: the immediate model (like in today's code) and the new kpatch/kgraft hybrid model. The

[RFC PATCH v1.9 00/14] livepatch: hybrid consistency model

2016-03-25 Thread Josh Poimboeuf
These patches are still a work in progress, but Jiri asked that I share them before I go on vacation next week. Based on origin/master because it has CONFIG_STACK_VALIDATION. This has two consistency models: the immediate model (like in today's code) and the new kpatch/kgraft hybrid model. The