Re: [RFC PATCH v2] Add functionality to ipu3-cio2 driver allowing software_node connections to sensors on platforms designed for Windows

2020-10-09 Thread Dan Scally
On 09/10/2020 13:44, Andy Shevchenko wrote: >> ...I agree with your other email re. turning this into a series and >> making the additional changes you suggested, so I'll do that too for the v3. > I forgot to mention module rename as a separate patch. So, something like 6 > (or more) in a series I

Re: [RFC PATCH v2] Add functionality to ipu3-cio2 driver allowing software_node connections to sensors on platforms designed for Windows

2020-10-09 Thread Andy Shevchenko
On Thu, Oct 08, 2020 at 10:51:46PM +0100, Dan Scally wrote: > On 01/10/2020 18:37, Andy Shevchenko wrote: > > On Thu, Oct 01, 2020 at 10:33:26AM +0100, Daniel Scally wrote: > > Awesome work! > > My, almost minor, comments below. > Thanks as always for your help - great comments. I'll work through

Re: [RFC PATCH v2] Add functionality to ipu3-cio2 driver allowing software_node connections to sensors on platforms designed for Windows

2020-10-08 Thread Dan Scally
Hi Andy - sorry for delayed reply, busy week On 01/10/2020 18:37, Andy Shevchenko wrote: > On Thu, Oct 01, 2020 at 10:33:26AM +0100, Daniel Scally wrote: > > Awesome work! > My, almost minor, comments below. Thanks as always for your help - great comments. I'll work through and make the changes

Re: [RFC PATCH v2] Add functionality to ipu3-cio2 driver allowing software_node connections to sensors on platforms designed for Windows

2020-10-01 Thread Andy Shevchenko
On Thu, Oct 01, 2020 at 10:33:26AM +0100, Daniel Scally wrote: ... > This patch is dependent on another (which implements the software node graph > family of functions): > > https://lore.kernel.org/linux-media/20200915232827.3416-1-djrsca...@gmail.com/ More thoughts about the (future) series.

Re: [RFC PATCH v2] Add functionality to ipu3-cio2 driver allowing software_node connections to sensors on platforms designed for Windows

2020-10-01 Thread Andy Shevchenko
On Thu, Oct 01, 2020 at 10:33:26AM +0100, Daniel Scally wrote: Awesome work! My, almost minor, comments below. > Currently on platforms designed for Windows, connections between CIO2 and > sensors are not properly defined in DSDT. This patch extends the ipu3-cio2 > driver to compensate by

[RFC PATCH v2] Add functionality to ipu3-cio2 driver allowing software_node connections to sensors on platforms designed for Windows

2020-10-01 Thread Daniel Scally
Currently on platforms designed for Windows, connections between CIO2 and sensors are not properly defined in DSDT. This patch extends the ipu3-cio2 driver to compensate by building software_node connections, parsing the connection properties from the sensor's SSDB buffer. Suggested-by: Jordan