Re: [RFC PATCH v2] sched: reflect sched_entity movement into task_group's utilization

2016-06-06 Thread Vincent Guittot
On 6 June 2016 at 12:52, Dietmar Eggemann wrote: > On 24/05/16 10:55, Vincent Guittot wrote: > > [...] > >> +/* Take into account the change of the utilization of a child task group */ >> +static void update_tg_cfs_util(struct sched_entity *se, int blocked) >> +{ >> + int delta; >> + struc

Re: [RFC PATCH v2] sched: reflect sched_entity movement into task_group's utilization

2016-06-06 Thread Dietmar Eggemann
On 24/05/16 10:55, Vincent Guittot wrote: [...] > +/* Take into account the change of the utilization of a child task group */ > +static void update_tg_cfs_util(struct sched_entity *se, int blocked) > +{ > + int delta; > + struct cfs_rq *cfs_rq; > + long update_util_avg; > + long

Re: [RFC PATCH v2] sched: reflect sched_entity movement into task_group's utilization

2016-06-06 Thread Yuyang Du
On Wed, Jun 01, 2016 at 02:54:07PM +0200, Peter Zijlstra wrote: > On Tue, May 24, 2016 at 10:57:32AM +0200, Vincent Guittot wrote: > > Ensure that the changes of the utilization of a sched_entity will be > > reflected in the task_group hierarchy. > > > > This patch tries another way than the flat

Re: [RFC PATCH v2] sched: reflect sched_entity movement into task_group's utilization

2016-06-01 Thread Dietmar Eggemann
On 01/06/16 13:54, Peter Zijlstra wrote: > On Tue, May 24, 2016 at 10:57:32AM +0200, Vincent Guittot wrote: >> Ensure that the changes of the utilization of a sched_entity will be >> reflected in the task_group hierarchy. >> >> This patch tries another way than the flat utilization hierarchy propos

Re: [RFC PATCH v2] sched: reflect sched_entity movement into task_group's utilization

2016-06-01 Thread Vincent Guittot
On 1 June 2016 at 15:36, Peter Zijlstra wrote: > On Tue, May 24, 2016 at 10:57:32AM +0200, Vincent Guittot wrote: > >> +/* >> + * Save how much utilization has just been added/removed on cfs rq so we can >> + * propagate it across the whole tg tree >> + */ >> +static void set_tg_cfs_rq_util(struct

Re: [RFC PATCH v2] sched: reflect sched_entity movement into task_group's utilization

2016-06-01 Thread Peter Zijlstra
On Tue, May 24, 2016 at 10:57:32AM +0200, Vincent Guittot wrote: > +/* > + * Save how much utilization has just been added/removed on cfs rq so we can > + * propagate it across the whole tg tree > + */ > +static void set_tg_cfs_rq_util(struct cfs_rq *cfs_rq, int delta) > +{ > + if (cfs_rq->tg

Re: [RFC PATCH v2] sched: reflect sched_entity movement into task_group's utilization

2016-06-01 Thread Peter Zijlstra
On Tue, May 24, 2016 at 10:57:32AM +0200, Vincent Guittot wrote: > Ensure that the changes of the utilization of a sched_entity will be > reflected in the task_group hierarchy. > > This patch tries another way than the flat utilization hierarchy proposal > to ensure the changes will be propagated

[RFC PATCH v2] sched: reflect sched_entity movement into task_group's utilization

2016-05-24 Thread Vincent Guittot
Ensure that the changes of the utilization of a sched_entity will be reflected in the task_group hierarchy. This patch tries another way than the flat utilization hierarchy proposal to ensure the changes will be propagated down to the root cfs. The way to compute the sched average metrics stays t

[RFC PATCH v2] sched: reflect sched_entity movement into task_group's utilization

2016-05-24 Thread Vincent Guittot
Ensure that the changes of the utilization of a sched_entity will be reflected in the task_group hierarchy. This patch tries another way than the flat utilization hierarchy proposal to ensure the changes will be propagated down to the root cfs. The way to compute the sched average metrics stays t