Re: [RFC PATCH v2 0/4] mm, memory_hotplug: allocate memmap from hotadded memory

2019-02-12 Thread Oscar Salvador
On Tue, Feb 12, 2019 at 03:42:42PM +0100, Michal Hocko wrote: > Please make sure to test on a larger machine which has multi section > memblocks. This is where I was hitting on bugs hard. I tested the patchset with large memblocks (2GB) on x86_64, and worked fine as well. On powerpc I was only

Re: [RFC PATCH v2 0/4] mm, memory_hotplug: allocate memmap from hotadded memory

2019-02-12 Thread Michal Hocko
On Tue 12-02-19 14:56:58, Oscar Salvador wrote: > On Tue, Feb 12, 2019 at 01:21:38PM +, Shameerali Kolothum Thodi wrote: > > > Hi Oscar, > > > > > > I ran tests on one of our arm64 machines. Particular machine doesn't > > > actually > > > have > > > the mechanics for hotplug, so was all

Re: [RFC PATCH v2 0/4] mm, memory_hotplug: allocate memmap from hotadded memory

2019-02-12 Thread Oscar Salvador
On Tue, Feb 12, 2019 at 01:21:38PM +, Shameerali Kolothum Thodi wrote: > > Hi Oscar, > > > > I ran tests on one of our arm64 machines. Particular machine doesn't > > actually > > have > > the mechanics for hotplug, so was all 'faked', but software wise it's all > > the > > same. > > > >

RE: [RFC PATCH v2 0/4] mm, memory_hotplug: allocate memmap from hotadded memory

2019-02-12 Thread Shameerali Kolothum Thodi
intel.com; Shameerali Kolothum > Thodi ; Linuxarm > ; Robin Murphy > Subject: Re: [RFC PATCH v2 0/4] mm, memory_hotplug: allocate memmap from > hotadded memory > > On Tue, 22 Jan 2019 11:37:04 +0100 > Oscar Salvador wrote: > > > Hi, > > > > this is the v2 of

Re: [RFC PATCH v2 0/4] mm, memory_hotplug: allocate memmap from hotadded memory

2019-02-12 Thread Jonathan Cameron
On Tue, 22 Jan 2019 11:37:04 +0100 Oscar Salvador wrote: > Hi, > > this is the v2 of the first RFC I sent back then in October [1]. > In this new version I tried to reduce the complexity as much as possible, > plus some clean ups. > > [Testing] > > I have tested it on "x86_64" (small/big

Re: [RFC PATCH v2 0/4] mm, memory_hotplug: allocate memmap from hotadded memory

2019-01-31 Thread Oscar Salvador
On Thu, Jan 31, 2019 at 08:23:19AM +0100, Michal Hocko wrote: > On Wed 30-01-19 22:52:04, Oscar Salvador wrote: > > On Tue, Jan 22, 2019 at 11:37:04AM +0100, Oscar Salvador wrote: > > > I yet have to check a couple of things like creating an accounting item > > > like VMEMMAP_PAGES to show in

Re: [RFC PATCH v2 0/4] mm, memory_hotplug: allocate memmap from hotadded memory

2019-01-30 Thread Michal Hocko
On Wed 30-01-19 22:52:04, Oscar Salvador wrote: > On Tue, Jan 22, 2019 at 11:37:04AM +0100, Oscar Salvador wrote: > > I yet have to check a couple of things like creating an accounting item > > like VMEMMAP_PAGES to show in /proc/meminfo to ease to spot the memory that > > went in there, testing

Re: [RFC PATCH v2 0/4] mm, memory_hotplug: allocate memmap from hotadded memory

2019-01-30 Thread Oscar Salvador
On Tue, Jan 22, 2019 at 11:37:04AM +0100, Oscar Salvador wrote: > I yet have to check a couple of things like creating an accounting item > like VMEMMAP_PAGES to show in /proc/meminfo to ease to spot the memory that > went in there, testing Hyper-V/Xen to see how they react to the fact that > we

Re: [RFC PATCH v2 0/4] mm, memory_hotplug: allocate memmap from hotadded memory

2019-01-29 Thread David Hildenbrand
On 29.01.19 09:43, Oscar Salvador wrote: > On Fri, Jan 25, 2019 at 09:53:35AM +0100, David Hildenbrand wrote: > Hi David, > >> I only had a quick glimpse. I would prefer if the caller of add_memory() >> can specify whether it would be ok to allocate vmmap from the range. >> This e.g. allows ACPI

Re: [RFC PATCH v2 0/4] mm, memory_hotplug: allocate memmap from hotadded memory

2019-01-29 Thread Oscar Salvador
On Fri, Jan 25, 2019 at 09:53:35AM +0100, David Hildenbrand wrote: Hi David, > I only had a quick glimpse. I would prefer if the caller of add_memory() > can specify whether it would be ok to allocate vmmap from the range. > This e.g. allows ACPI dimm code to allocate from the range, however >

Re: [RFC PATCH v2 0/4] mm, memory_hotplug: allocate memmap from hotadded memory

2019-01-25 Thread David Hildenbrand
On 22.01.19 11:37, Oscar Salvador wrote: > Hi, > > this is the v2 of the first RFC I sent back then in October [1]. > In this new version I tried to reduce the complexity as much as possible, > plus some clean ups. > > [Testing] > > I have tested it on "x86_64" (small/big memblocks) and on

[RFC PATCH v2 0/4] mm, memory_hotplug: allocate memmap from hotadded memory

2019-01-22 Thread Oscar Salvador
Hi, this is the v2 of the first RFC I sent back then in October [1]. In this new version I tried to reduce the complexity as much as possible, plus some clean ups. [Testing] I have tested it on "x86_64" (small/big memblocks) and on "powerpc". On both architectures hot-add/hot-remove