Re: [RFC PATCH v2 09/15] perf probe: Support $params without debuginfo

2015-05-30 Thread Masami Hiramatsu
On 2015/05/30 10:27, Alexei Starovoitov wrote: > On 5/29/15 4:55 PM, Masami Hiramatsu wrote: >> On 2015/05/29 15:30, He Kuang wrote: >>> hi, Alexei >>> >>> On 2015/5/29 2:10, Alexei Starovoitov wrote: On 5/28/15 6:01 AM, He Kuang wrote: >> I don't think you can break it down in two steps l

Re: [RFC PATCH v2 09/15] perf probe: Support $params without debuginfo

2015-05-29 Thread Alexei Starovoitov
On 5/29/15 4:55 PM, Masami Hiramatsu wrote: > On 2015/05/29 15:30, He Kuang wrote: >> hi, Alexei >> >> On 2015/5/29 2:10, Alexei Starovoitov wrote: >>> On 5/28/15 6:01 AM, He Kuang wrote: > I don't think you can break it down in two steps like this. >> There is no such thing as 'calling reg

Re: Re: [RFC PATCH v2 09/15] perf probe: Support $params without debuginfo

2015-05-29 Thread Masami Hiramatsu
On 2015/05/29 15:30, He Kuang wrote: > hi, Alexei > > On 2015/5/29 2:10, Alexei Starovoitov wrote: >> On 5/28/15 6:01 AM, He Kuang wrote: I don't think you can break it down in two steps like this. > There is no such thing as 'calling regs'. x86_32 with ax,dx,cx > are not 'calling reg

Re: [RFC PATCH v2 09/15] perf probe: Support $params without debuginfo

2015-05-28 Thread He Kuang
hi, Alexei On 2015/5/29 2:10, Alexei Starovoitov wrote: > On 5/28/15 6:01 AM, He Kuang wrote: >>> I don't think you can break it down in two steps like this. There is no such thing as 'calling regs'. x86_32 with ax,dx,cx are not 'calling regs'. 64-bit values will be passed in a pair. >>>

Re: [RFC PATCH v2 09/15] perf probe: Support $params without debuginfo

2015-05-28 Thread Alexei Starovoitov
On 5/28/15 6:01 AM, He Kuang wrote: >> I don't think you can break it down in two steps like this. >> >There is no such thing as 'calling regs'. x86_32 with ax,dx,cx >> >are not 'calling regs'. 64-bit values will be passed in a pair. >> >Only 'pt_regs + arch + func_proto + asmlinkage' makes sense >

Re: [RFC PATCH v2 09/15] perf probe: Support $params without debuginfo

2015-05-28 Thread He Kuang
On 2015/5/27 23:30, Alexei Starovoitov wrote: > On 5/26/15 7:27 PM, He Kuang wrote: >> hi, Alexei >> >> On 2015/5/27 1:50, Alexei Starovoitov wrote: >>> On 5/25/15 1:33 AM, He Kuang wrote: Right, I learnt regparm(3) is mandatory in x86_32, according to rules, the first three args will g

Re: [RFC PATCH v2 09/15] perf probe: Support $params without debuginfo

2015-05-27 Thread Alexei Starovoitov
On 5/26/15 7:27 PM, He Kuang wrote: > hi, Alexei > > On 2015/5/27 1:50, Alexei Starovoitov wrote: >> On 5/25/15 1:33 AM, He Kuang wrote: >>> Right, I learnt regparm(3) is mandatory in x86_32, according to rules, >>> the first three args will go to regparm(ax, dx, cx). But we should not >>> refer a

Re: [RFC PATCH v2 09/15] perf probe: Support $params without debuginfo

2015-05-27 Thread Masami Hiramatsu
On 2015/05/27 11:27, He Kuang wrote: > hi, Alexei > > On 2015/5/27 1:50, Alexei Starovoitov wrote: >> On 5/25/15 1:33 AM, He Kuang wrote: >>> Right, I learnt regparm(3) is mandatory in x86_32, according to rules, >>> the first three args will go to regparm(ax, dx, cx). But we should not >>> refer

Re: [RFC PATCH v2 09/15] perf probe: Support $params without debuginfo

2015-05-26 Thread He Kuang
hi, Alexei On 2015/5/27 1:50, Alexei Starovoitov wrote: > On 5/25/15 1:33 AM, He Kuang wrote: >> Right, I learnt regparm(3) is mandatory in x86_32, according to rules, >> the first three args will go to regparm(ax, dx, cx). But we should not >> refer arg1~3 to ax, dx, cx because of 64bit parameter

Re: [RFC PATCH v2 09/15] perf probe: Support $params without debuginfo

2015-05-26 Thread Alexei Starovoitov
On 5/25/15 1:33 AM, He Kuang wrote: > Right, I learnt regparm(3) is mandatory in x86_32, according to rules, > the first three args will go to regparm(ax, dx, cx). But we should not > refer arg1~3 to ax, dx, cx because of 64bit parameters (other reasons?). > > Consider this keyword is used for gen

Re: Re: [RFC PATCH v2 09/15] perf probe: Support $params without debuginfo

2015-05-25 Thread Masami Hiramatsu
On 2015/05/25 21:46, Arnaldo Carvalho de Melo wrote: > Em Mon, May 25, 2015 at 09:22:50PM +0900, Masami Hiramatsu escreveu: >> Actually, I'm working on the perf-probe cache enhancement (and it will be >> perf-cache) >> which allows you to cache the result of debuginfo analysis under >> buildid-ca

Re: [RFC PATCH v2 09/15] perf probe: Support $params without debuginfo

2015-05-25 Thread Arnaldo Carvalho de Melo
Em Mon, May 25, 2015 at 09:22:50PM +0900, Masami Hiramatsu escreveu: > Actually, I'm working on the perf-probe cache enhancement (and it will be > perf-cache) > which allows you to cache the result of debuginfo analysis under > buildid-cache. > So, if the build-id is same on remote machines, you

Re: [RFC PATCH v2 09/15] perf probe: Support $params without debuginfo

2015-05-25 Thread Masami Hiramatsu
On 2015/05/25 17:33, He Kuang wrote: > hi, > > On 2015/5/24 16:49, Masami Hiramatsu wrote: >> On 2015/05/24 17:28, He Kuang wrote: >>> When probing at function entry, fallback $params to calling regs if no >>> debuginfo is provided. >>> >>> Before this path: >>>$ perf probe -v --add='generic_p

Re: [RFC PATCH v2 09/15] perf probe: Support $params without debuginfo

2015-05-25 Thread He Kuang
hi, On 2015/5/24 16:49, Masami Hiramatsu wrote: > On 2015/05/24 17:28, He Kuang wrote: >> When probing at function entry, fallback $params to calling regs if no >> debuginfo is provided. >> >> Before this path: >>$ perf probe -v --add='generic_perform_write $params' >>... >>Added new e

Re: [RFC PATCH v2 09/15] perf probe: Support $params without debuginfo

2015-05-24 Thread Masami Hiramatsu
On 2015/05/24 17:28, He Kuang wrote: > When probing at function entry, fallback $params to calling regs if no > debuginfo is provided. > > Before this path: > $ perf probe -v --add='generic_perform_write $params' > ... > Added new event: > Writing event: p:probe/generic_perform_write _stex

[RFC PATCH v2 09/15] perf probe: Support $params without debuginfo

2015-05-24 Thread He Kuang
When probing at function entry, fallback $params to calling regs if no debuginfo is provided. Before this path: $ perf probe -v --add='generic_perform_write $params' ... Added new event: Writing event: p:probe/generic_perform_write _stext+1246632 $params [86152.161204] Parse error at arg