Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

* Brian Norris [171222 23:23]: > + Rafael to this thread > > On Wed, Dec 20, 2017 at 11:19:12AM -0800, Tony Lindgren wrote: > > * Brian Norris [171219 00:50]: > > > On Wed, Aug 23, 2017 at 09:32:39AM +0800, Jeffy Chen wrote: > > > > > > Did

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

* Brian Norris [171222 23:23]: > + Rafael to this thread > > On Wed, Dec 20, 2017 at 11:19:12AM -0800, Tony Lindgren wrote: > > * Brian Norris [171219 00:50]: > > > On Wed, Aug 23, 2017 at 09:32:39AM +0800, Jeffy Chen wrote: > > > > > > Did this problem ever get resolved? To be clear, I

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

+ Rafael to this thread On Wed, Dec 20, 2017 at 11:19:12AM -0800, Tony Lindgren wrote: > * Brian Norris [171219 00:50]: > > On Wed, Aug 23, 2017 at 09:32:39AM +0800, Jeffy Chen wrote: > > > > Did this problem ever get resolved? To be clear, I believe the problem > > at

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

+ Rafael to this thread On Wed, Dec 20, 2017 at 11:19:12AM -0800, Tony Lindgren wrote: > * Brian Norris [171219 00:50]: > > On Wed, Aug 23, 2017 at 09:32:39AM +0800, Jeffy Chen wrote: > > > > Did this problem ever get resolved? To be clear, I believe the problem > > at hand is: > > > > (a) in

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi, * Brian Norris [171219 00:50]: > On Wed, Aug 23, 2017 at 09:32:39AM +0800, Jeffy Chen wrote: > > Did this problem ever get resolved? To be clear, I believe the problem > at hand is: > > (a) in suspend/resume (not runtime PM; we may not even have runtime PM >

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi, * Brian Norris [171219 00:50]: > On Wed, Aug 23, 2017 at 09:32:39AM +0800, Jeffy Chen wrote: > > Did this problem ever get resolved? To be clear, I believe the problem > at hand is: > > (a) in suspend/resume (not runtime PM; we may not even have runtime PM > support for most PCI devices)

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Jeffy, Tony, On Wed, Aug 23, 2017 at 09:32:39AM +0800, Jeffy Chen wrote: > Hi Tony, > > On 08/23/2017 01:26 AM, Tony Lindgren wrote: > >OK, let's fix any wakeriq ordering issues to make it more > >usable. Sounds like in your case the wakeirq needs to be enabled > >late and disabled early,

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Jeffy, Tony, On Wed, Aug 23, 2017 at 09:32:39AM +0800, Jeffy Chen wrote: > Hi Tony, > > On 08/23/2017 01:26 AM, Tony Lindgren wrote: > >OK, let's fix any wakeriq ordering issues to make it more > >usable. Sounds like in your case the wakeirq needs to be enabled > >late and disabled early,

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Brian, On 08/23/2017 09:57 AM, Brian Norris wrote: Hi Jeffy, On Wed, Aug 23, 2017 at 09:32:39AM +0800, Jeffy Chen wrote: and for eage irq, maybe we should enable it right after(or before) the driver activate wake function(for example activate WOWLAN or WOLAN), otherwise would it be

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Brian, On 08/23/2017 09:57 AM, Brian Norris wrote: Hi Jeffy, On Wed, Aug 23, 2017 at 09:32:39AM +0800, Jeffy Chen wrote: and for eage irq, maybe we should enable it right after(or before) the driver activate wake function(for example activate WOWLAN or WOLAN), otherwise would it be

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Jeffy, On Wed, Aug 23, 2017 at 09:32:39AM +0800, Jeffy Chen wrote: > and for eage irq, maybe we should enable it right after(or before) > the driver activate wake function(for example activate WOWLAN or > WOLAN), otherwise would it be possible to miss some irqs(triggered > before we actually

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Jeffy, On Wed, Aug 23, 2017 at 09:32:39AM +0800, Jeffy Chen wrote: > and for eage irq, maybe we should enable it right after(or before) > the driver activate wake function(for example activate WOWLAN or > WOLAN), otherwise would it be possible to miss some irqs(triggered > before we actually

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Tony, On 08/23/2017 01:26 AM, Tony Lindgren wrote: OK, let's fix any wakeriq ordering issues to make it more usable. Sounds like in your case the wakeirq needs to be enabled late and disabled early, while in my test cases I can keep it enabled basically any time. yes, in my case it's a

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Tony, On 08/23/2017 01:26 AM, Tony Lindgren wrote: OK, let's fix any wakeriq ordering issues to make it more usable. Sounds like in your case the wakeirq needs to be enabled late and disabled early, while in my test cases I can keep it enabled basically any time. yes, in my case it's a

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

* jeffy [170818 13:05]: > Hi guys, > > On 08/19/2017 02:14 AM, Tony Lindgren wrote: > > > static irqreturn_t handle_threaded_wake_irq(int irq, void *_wirq) > > > >{ > > > > struct wake_irq *wirq = _wirq; > > > > int res; > > > > > > > > /* Maybe

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

* jeffy [170818 13:05]: > Hi guys, > > On 08/19/2017 02:14 AM, Tony Lindgren wrote: > > > static irqreturn_t handle_threaded_wake_irq(int irq, void *_wirq) > > > >{ > > > > struct wake_irq *wirq = _wirq; > > > > int res; > > > > > > > > /* Maybe abort suspend? */ > > > >

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi guys, On 08/19/2017 02:14 AM, Tony Lindgren wrote: static irqreturn_t handle_threaded_wake_irq(int irq, void *_wirq) >{ > struct wake_irq *wirq = _wirq; > int res; > > /* Maybe abort suspend? */ > if (irqd_is_wakeup_set(irq_get_irq_data(irq))) { >

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi guys, On 08/19/2017 02:14 AM, Tony Lindgren wrote: static irqreturn_t handle_threaded_wake_irq(int irq, void *_wirq) >{ > struct wake_irq *wirq = _wirq; > int res; > > /* Maybe abort suspend? */ > if (irqd_is_wakeup_set(irq_get_irq_data(irq))) { >

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

* jeffy [170818 11:05]: > On 08/19/2017 01:01 AM, Brian Norris wrote: > > BTW, in another context, Tony suggested we might need to fix up the IRQ > > flags > > like this: > > > > int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq) > > { > > ... > >

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

* jeffy [170818 11:05]: > On 08/19/2017 01:01 AM, Brian Norris wrote: > > BTW, in another context, Tony suggested we might need to fix up the IRQ > > flags > > like this: > > > > int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq) > > { > > ... > > err =

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

* Brian Norris [170818 10:01]: > + Tony > > On Thu, Aug 17, 2017 at 08:04:29PM +0800, Jeffy Chen wrote: > > Add support for PCIE_WAKE pin in rockchip pcie driver. > > > > Signed-off-by: Jeffy Chen > > --- > > > > Changes in v2: > > Use

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

* Brian Norris [170818 10:01]: > + Tony > > On Thu, Aug 17, 2017 at 08:04:29PM +0800, Jeffy Chen wrote: > > Add support for PCIE_WAKE pin in rockchip pcie driver. > > > > Signed-off-by: Jeffy Chen > > --- > > > > Changes in v2: > > Use dev_pm_set_dedicated_wake_irq > > -- Suggested by

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Brian, On 08/19/2017 01:01 AM, Brian Norris wrote: Did you test that this works out correctly as a level-triggered interrupt? IIUC, the dummy handler won't mask the interrupt, so it might keep firing. See: static irqreturn_t handle_threaded_wake_irq(int irq, void *_wirq) { struct

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Brian, On 08/19/2017 01:01 AM, Brian Norris wrote: Did you test that this works out correctly as a level-triggered interrupt? IIUC, the dummy handler won't mask the interrupt, so it might keep firing. See: static irqreturn_t handle_threaded_wake_irq(int irq, void *_wirq) { struct

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

On Fri, Aug 18, 2017 at 10:01:07AM -0700, Brian Norris wrote: > + Tony > > On Thu, Aug 17, 2017 at 08:04:29PM +0800, Jeffy Chen wrote: > > Add support for PCIE_WAKE pin in rockchip pcie driver. > > > > Signed-off-by: Jeffy Chen > > --- > > > > Changes in v2: > > Use

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

On Fri, Aug 18, 2017 at 10:01:07AM -0700, Brian Norris wrote: > + Tony > > On Thu, Aug 17, 2017 at 08:04:29PM +0800, Jeffy Chen wrote: > > Add support for PCIE_WAKE pin in rockchip pcie driver. > > > > Signed-off-by: Jeffy Chen > > --- > > > > Changes in v2: > > Use

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

+ Tony On Thu, Aug 17, 2017 at 08:04:29PM +0800, Jeffy Chen wrote: > Add support for PCIE_WAKE pin in rockchip pcie driver. > > Signed-off-by: Jeffy Chen > --- > > Changes in v2: > Use dev_pm_set_dedicated_wake_irq > -- Suggested by Brian Norris

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

+ Tony On Thu, Aug 17, 2017 at 08:04:29PM +0800, Jeffy Chen wrote: > Add support for PCIE_WAKE pin in rockchip pcie driver. > > Signed-off-by: Jeffy Chen > --- > > Changes in v2: > Use dev_pm_set_dedicated_wake_irq > -- Suggested by Brian Norris > > drivers/pci/host/pcie-rockchip.c

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Shawn, On 08/18/2017 03:23 PM, Shawn Lin wrote: @@ -1524,6 +1532,9 @@ static int rockchip_pcie_remove(struct platform_device *pdev) struct device *dev = >dev; struct rockchip_pcie *rockchip = dev_get_drvdata(dev); +dev_pm_clear_wake_irq(dev); +device_init_wakeup(dev,

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Shawn, On 08/18/2017 03:23 PM, Shawn Lin wrote: @@ -1524,6 +1532,9 @@ static int rockchip_pcie_remove(struct platform_device *pdev) struct device *dev = >dev; struct rockchip_pcie *rockchip = dev_get_drvdata(dev); +dev_pm_clear_wake_irq(dev); +device_init_wakeup(dev,

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Jeffy On 2017/8/17 20:04, Jeffy Chen wrote: Add support for PCIE_WAKE pin in rockchip pcie driver. Signed-off-by: Jeffy Chen --- Changes in v2: Use dev_pm_set_dedicated_wake_irq -- Suggested by Brian Norris

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Jeffy On 2017/8/17 20:04, Jeffy Chen wrote: Add support for PCIE_WAKE pin in rockchip pcie driver. Signed-off-by: Jeffy Chen --- Changes in v2: Use dev_pm_set_dedicated_wake_irq -- Suggested by Brian Norris drivers/pci/host/pcie-rockchip.c | 13 - 1 file changed,

[RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Add support for PCIE_WAKE pin in rockchip pcie driver. Signed-off-by: Jeffy Chen --- Changes in v2: Use dev_pm_set_dedicated_wake_irq -- Suggested by Brian Norris drivers/pci/host/pcie-rockchip.c | 13 - 1 file changed,

[RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Add support for PCIE_WAKE pin in rockchip pcie driver. Signed-off-by: Jeffy Chen --- Changes in v2: Use dev_pm_set_dedicated_wake_irq -- Suggested by Brian Norris drivers/pci/host/pcie-rockchip.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git