Re: [RFC PATCH v2 1/3] hwmon: pmbus: Add fan control support

2017-07-19 Thread Andrew Jeffery
On Thu, 2017-07-20 at 00:35 +0930, Joel Stanley wrote: > > On Tue, Jul 18, 2017 at 1:06 PM, Andrew Jeffery wrote: > > Expose fanX_target, pwmX and pwmX_enable hwmon sysfs attributes. > > Nice! I had a bit of a read. I'm not a pmbus expert, so most of the > review is nitpicks

Re: [RFC PATCH v2 1/3] hwmon: pmbus: Add fan control support

2017-07-19 Thread Andrew Jeffery
On Thu, 2017-07-20 at 00:35 +0930, Joel Stanley wrote: > > On Tue, Jul 18, 2017 at 1:06 PM, Andrew Jeffery wrote: > > Expose fanX_target, pwmX and pwmX_enable hwmon sysfs attributes. > > Nice! I had a bit of a read. I'm not a pmbus expert, so most of the > review is nitpicks about types, etc. >

Re: [RFC PATCH v2 1/3] hwmon: pmbus: Add fan control support

2017-07-19 Thread Joel Stanley
On Tue, Jul 18, 2017 at 1:06 PM, Andrew Jeffery wrote: > Expose fanX_target, pwmX and pwmX_enable hwmon sysfs attributes. Nice! I had a bit of a read. I'm not a pmbus expert, so most of the review is nitpicks about types, etc. I'll defer to Guenter for the real stuff. > > Fans

Re: [RFC PATCH v2 1/3] hwmon: pmbus: Add fan control support

2017-07-19 Thread Joel Stanley
On Tue, Jul 18, 2017 at 1:06 PM, Andrew Jeffery wrote: > Expose fanX_target, pwmX and pwmX_enable hwmon sysfs attributes. Nice! I had a bit of a read. I'm not a pmbus expert, so most of the review is nitpicks about types, etc. I'll defer to Guenter for the real stuff. > > Fans in a PMBus

[RFC PATCH v2 1/3] hwmon: pmbus: Add fan control support

2017-07-17 Thread Andrew Jeffery
Expose fanX_target, pwmX and pwmX_enable hwmon sysfs attributes. Fans in a PMBus device are driven by the configuration of two registers: FAN_CONFIG_x_y and FAN_COMMAND_x: FAN_CONFIG_x_y dictates how the fan and the tacho operate (if installed), while FAN_COMMAND_x sets the desired fan rate. The

[RFC PATCH v2 1/3] hwmon: pmbus: Add fan control support

2017-07-17 Thread Andrew Jeffery
Expose fanX_target, pwmX and pwmX_enable hwmon sysfs attributes. Fans in a PMBus device are driven by the configuration of two registers: FAN_CONFIG_x_y and FAN_COMMAND_x: FAN_CONFIG_x_y dictates how the fan and the tacho operate (if installed), while FAN_COMMAND_x sets the desired fan rate. The