[RFC PATCH v2 1/7] mm, oom: refactor select_bad_process() to take memcg as an argument

2017-06-01 Thread Roman Gushchin
The select_bad_process() function will be used further to select a process to kill in the victim cgroup. This cgroup doesn't necessary match oc->memcg, which is a cgroup, which limits were caused cgroup-wide OOM (or NULL in case of global OOM). So, refactor select_bad_process() to take a pointer t

Re: [RFC PATCH v2 1/7] mm, oom: refactor select_bad_process() to take memcg as an argument

2017-06-06 Thread Roman Gushchin
On Sun, Jun 04, 2017 at 03:50:37PM -0700, David Rientjes wrote: > We use a heavily modified system and memcg oom killer and I'm wondering > if there is some opportunity for collaboration because we may have some > shared goals. > > I can summarize how we currently use the oom killer at a high leve

Re: [RFC PATCH v2 1/7] mm, oom: refactor select_bad_process() to take memcg as an argument

2017-06-06 Thread David Rientjes
On Tue, 6 Jun 2017, Roman Gushchin wrote: > Hi David! > > Thank you for sharing this! > > It's very interesting, and it looks like, > it's not that far from what I've suggested. > > So we definitily need to come up with some common solution. > Hi Roman, Yes, definitely. I could post a serie

Re: [RFC PATCH v2 1/7] mm, oom: refactor select_bad_process() to take memcg as an argument

2017-06-04 Thread Vladimir Davydov
On Thu, Jun 01, 2017 at 07:35:09PM +0100, Roman Gushchin wrote: > The select_bad_process() function will be used further > to select a process to kill in the victim cgroup. > This cgroup doesn't necessary match oc->memcg, > which is a cgroup, which limits were caused cgroup-wide OOM > (or NULL in c

Re: [RFC PATCH v2 1/7] mm, oom: refactor select_bad_process() to take memcg as an argument

2017-06-04 Thread David Rientjes
We use a heavily modified system and memcg oom killer and I'm wondering if there is some opportunity for collaboration because we may have some shared goals. I can summarize how we currently use the oom killer at a high level so that it is not overwhelming with implementation details and give some

Re: [RFC PATCH v2 1/7] mm, oom: refactor select_bad_process() to take memcg as an argument

2017-06-08 Thread Roman Gushchin
On Tue, Jun 06, 2017 at 01:42:29PM -0700, David Rientjes wrote: > On Tue, 6 Jun 2017, Roman Gushchin wrote: > > > Hi David! > > > > Thank you for sharing this! > > > > It's very interesting, and it looks like, > > it's not that far from what I've suggested. > > > > So we definitily need to come