Re: [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation

2014-05-13 Thread Herbert Xu
On Fri, May 09, 2014 at 12:57:39AM +0300, Stanimir Vabanov wrote: > Hi Herbert, > > On 04/28/2014 11:59 AM, Herbert Xu wrote: > > On Mon, Apr 14, 2014 at 03:48:37PM +0300, Stanimir Varbanov wrote: > >> > >> +#define QCE_MAJOR_VERSION50x05 > >> +#define QCE_QUEUE_LENGTH 50 > > > > What is

Re: [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation

2014-05-08 Thread Stanimir Vabanov
Hi Herbert, On 04/28/2014 11:59 AM, Herbert Xu wrote: > On Mon, Apr 14, 2014 at 03:48:37PM +0300, Stanimir Varbanov wrote: >> >> +#define QCE_MAJOR_VERSION5 0x05 >> +#define QCE_QUEUE_LENGTH50 > > What is the purpose of this software queue? Why can't you directly > feed the requests to the h

Re: [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation

2014-04-30 Thread Stanimir Varbanov
Hi Herbert, On 04/28/2014 11:59 AM, Herbert Xu wrote: > On Mon, Apr 14, 2014 at 03:48:37PM +0300, Stanimir Varbanov wrote: >> >> +#define QCE_MAJOR_VERSION5 0x05 >> +#define QCE_QUEUE_LENGTH50 > > What is the purpose of this software queue? Why can't you directly > feed the requests to the h

Re: [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation

2014-04-29 Thread Herbert Xu
On Tue, Apr 29, 2014 at 05:38:14PM +0300, Stanimir Varbanov wrote: > > This is new for me because I saw similar code in cryptd.c where in > cryptd_queue_worker() (workqueue context) the backlog->complete() is > called outside of local_bh_disable(). That's what I thought :) If you dig deeper you'l

Re: [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation

2014-04-29 Thread Stanimir Varbanov
Thanks for the review! On 04/28/2014 11:50 AM, Herbert Xu wrote: > On Mon, Apr 14, 2014 at 03:48:37PM +0300, Stanimir Varbanov wrote: >> >> +if (backlog) >> +backlog->complete(backlog, -EINPROGRESS); > > The completion function needs to be called with BH disabled. > > Cheers, >

Re: [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation

2014-04-28 Thread Herbert Xu
On Mon, Apr 14, 2014 at 03:48:37PM +0300, Stanimir Varbanov wrote: > > +#define QCE_MAJOR_VERSION5 0x05 > +#define QCE_QUEUE_LENGTH 50 What is the purpose of this software queue? Why can't you directly feed the requests to the hardware? If the hardware can't handle more than 50 requests in-

Re: [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation

2014-04-28 Thread Herbert Xu
On Mon, Apr 14, 2014 at 03:48:37PM +0300, Stanimir Varbanov wrote: > > + if (backlog) > + backlog->complete(backlog, -EINPROGRESS); The completion function needs to be called with BH disabled. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

[RFC PATCH v2 1/9] crypto: qce: Add core driver implementation

2014-04-14 Thread Stanimir Varbanov
This adds core driver files. The core part is implementing a platform driver probe and remove callbaks, the probe enables clocks, checks crypto version, initialize and request dma channels, create done tasklet and work queue and finally register the algorithms into crypto subsystem. Signed-off-by: