Re: [RFC PATCH v2 26/31] fprobe: Rewrite fprobe on function-graph tracer

2023-11-10 Thread Google
On Fri, 10 Nov 2023 20:44:22 -0500 Steven Rostedt wrote: > On Fri, 10 Nov 2023 16:17:39 +0900 > Masami Hiramatsu (Google) wrote: > > > > + used = 0; > > > + hlist_for_each_entry_from_rcu(node, hlist) { > > > + if (node->addr != func) > > > + break; > > > + fp = R

Re: [RFC PATCH v2 26/31] fprobe: Rewrite fprobe on function-graph tracer

2023-11-10 Thread Steven Rostedt
On Fri, 10 Nov 2023 16:17:39 +0900 Masami Hiramatsu (Google) wrote: > > + used = 0; > > + hlist_for_each_entry_from_rcu(node, hlist) { > > + if (node->addr != func) > > + break; > > + fp = READ_ONCE(node->fp); > > + if (!fp || fprobe_disabled(fp

Re: [RFC PATCH v2 26/31] fprobe: Rewrite fprobe on function-graph tracer

2023-11-09 Thread Google
Hi, On Wed, 8 Nov 2023 23:29:22 +0900 "Masami Hiramatsu (Google)" wrote: > + */ > +static inline int __fprobe_handler(unsigned long ip, unsigned long parent_ip, > +struct fprobe *fp, struct ftrace_regs *fregs, > +void *data) > +{ >

[RFC PATCH v2 26/31] fprobe: Rewrite fprobe on function-graph tracer

2023-11-08 Thread Masami Hiramatsu (Google)
From: Masami Hiramatsu (Google) Rewrite fprobe implementation on function-graph tracer. Major API changes are: - 'nr_maxactive' field is deprecated. - This depends on CONFIG_DYNAMIC_FTRACE_WITH_ARGS or !CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS, and CONFIG_HAVE_FUNCTION_GRAPH_FREGS. So cur