Re: [RFC PATCH v2 3/4] Fix twofish crypto functions prototype casts

2019-05-06 Thread Kees Cook
On Mon, May 6, 2019 at 12:20 PM Joao Moreira wrote: > RFC: twofish_enc_blk_ctr_3way is assigned both to .ecb and to .ctr, > what makes its declaration through the macro undoable, as thought in > this patch. Suggestions on how to fix this are welcome. This looks like a typo in the original code

[RFC PATCH v2 3/4] Fix twofish crypto functions prototype casts

2019-05-06 Thread Joao Moreira
Add macros that generate glue functions for twofish crypto functions. Remove GLUE_FUNC_CAST macros from function pointer assignement and use the helper instead, making the prototypes compliant. RFC: twofish_enc_blk_ctr_3way is assigned both to .ecb and to .ctr, what makes its declaration through