Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-16 Thread Xunlei Pang
On 14 January 2015 at 23:39, Alessandro Zummo wrote: > On Wed, 14 Jan 2015 23:26:37 +0800 > Xunlei Pang wrote: > >> But on the other hand, we will have no test for set_mmss64(), >> because adding the set_mmss64() will make set_mmss() dysfunctional. > > add a module parameter Hi Alessandro,

Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-16 Thread Xunlei Pang
On 14 January 2015 at 23:39, Alessandro Zummo a.zu...@towertech.it wrote: On Wed, 14 Jan 2015 23:26:37 +0800 Xunlei Pang pang.xun...@linaro.org wrote: But on the other hand, we will have no test for set_mmss64(), because adding the set_mmss64() will make set_mmss() dysfunctional. add a

Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-14 Thread Alessandro Zummo
On Wed, 14 Jan 2015 23:26:37 +0800 Xunlei Pang wrote: > But on the other hand, we will have no test for set_mmss64(), > because adding the set_mmss64() will make set_mmss() dysfunctional. add a module parameter -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy

Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-14 Thread Xunlei Pang
On 14 January 2015 at 23:03, Alessandro Zummo wrote: > On Wed, 14 Jan 2015 22:56:15 +0800 > Xunlei Pang wrote: > >> We want to do away with set_mmss() eventually, time64 is the final version, >> so I think this would be ok. > > We'll get rid of set_mmss() from the test driver later on, > after

Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-14 Thread Alessandro Zummo
On Wed, 14 Jan 2015 22:56:15 +0800 Xunlei Pang wrote: > We want to do away with set_mmss() eventually, time64 is the final version, > so I think this would be ok. We'll get rid of set_mmss() from the test driver later on, after everything else has been converted :) -- Best regards,

Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-14 Thread Xunlei Pang
On 14 January 2015 at 00:19, Alessandro Zummo wrote: > On Tue, 13 Jan 2015 23:44:51 +0800 > Xunlei Pang wrote: > >> This patch resolves them by: >> - Repalce get_seconds() with get_seconds64() >> - Replace rtc_time_to_tm() with rtc_time64_to_tm() >> - Change test_rtc_set_mmss() to use

Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-14 Thread Xunlei Pang
On 14 January 2015 at 23:03, Alessandro Zummo a.zu...@towertech.it wrote: On Wed, 14 Jan 2015 22:56:15 +0800 Xunlei Pang pang.xun...@linaro.org wrote: We want to do away with set_mmss() eventually, time64 is the final version, so I think this would be ok. We'll get rid of set_mmss() from

Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-14 Thread Alessandro Zummo
On Wed, 14 Jan 2015 22:56:15 +0800 Xunlei Pang pang.xun...@linaro.org wrote: We want to do away with set_mmss() eventually, time64 is the final version, so I think this would be ok. We'll get rid of set_mmss() from the test driver later on, after everything else has been converted :) --

Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-14 Thread Xunlei Pang
On 14 January 2015 at 00:19, Alessandro Zummo a.zu...@towertech.it wrote: On Tue, 13 Jan 2015 23:44:51 +0800 Xunlei Pang xlp...@126.com wrote: This patch resolves them by: - Repalce get_seconds() with get_seconds64() - Replace rtc_time_to_tm() with rtc_time64_to_tm() - Change

Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-14 Thread Alessandro Zummo
On Wed, 14 Jan 2015 23:26:37 +0800 Xunlei Pang pang.xun...@linaro.org wrote: But on the other hand, we will have no test for set_mmss64(), because adding the set_mmss64() will make set_mmss() dysfunctional. add a module parameter -- Best regards, Alessandro Zummo, Tower Technologies

Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-13 Thread Alessandro Zummo
On Tue, 13 Jan 2015 23:44:51 +0800 Xunlei Pang wrote: > This patch resolves them by: > - Repalce get_seconds() with get_seconds64() > - Replace rtc_time_to_tm() with rtc_time64_to_tm() > - Change test_rtc_set_mmss() to use rtc_class_ops's set_mmss64() so we no more have a non time64 test

[RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-13 Thread Xunlei Pang
From: Xunlei Pang This driver has a number of y2038/y2106 issues. This patch resolves them by: - Repalce get_seconds() with get_seconds64() - Replace rtc_time_to_tm() with rtc_time64_to_tm() - Change test_rtc_set_mmss() to use rtc_class_ops's set_mmss64() After this patch, this driver should

[RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-13 Thread Xunlei Pang
From: Xunlei Pang pang.xun...@linaro.org This driver has a number of y2038/y2106 issues. This patch resolves them by: - Repalce get_seconds() with get_seconds64() - Replace rtc_time_to_tm() with rtc_time64_to_tm() - Change test_rtc_set_mmss() to use rtc_class_ops's set_mmss64() After this

Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-13 Thread Alessandro Zummo
On Tue, 13 Jan 2015 23:44:51 +0800 Xunlei Pang xlp...@126.com wrote: This patch resolves them by: - Repalce get_seconds() with get_seconds64() - Replace rtc_time_to_tm() with rtc_time64_to_tm() - Change test_rtc_set_mmss() to use rtc_class_ops's set_mmss64() so we no more have a non time64