Re: [RFC PATCH v2 4/9] crypto: qce: Add ablkcipher algorithms

2014-04-29 Thread Stanimir Varbanov
Thanks for the review! On 04/28/2014 11:18 AM, Herbert Xu wrote: > On Mon, Apr 14, 2014 at 03:48:40PM +0300, Stanimir Varbanov wrote: >> >> +} else if (IS_DES(flags)) { >> +u32 tmp[DES_EXPKEY_WORDS]; >> + >> +if (keylen != QCE_DES_KEY_SIZE) >> +goto

Re: [RFC PATCH v2 4/9] crypto: qce: Add ablkcipher algorithms

2014-04-29 Thread Stanimir Varbanov
Thanks for the review! On 04/28/2014 11:00 AM, Herbert Xu wrote: > On Mon, Apr 14, 2014 at 03:48:40PM +0300, Stanimir Varbanov wrote: >> >> +if (IS_AES(flags)) { >> +switch (keylen) { >> +case AES_KEYSIZE_128: >> +case AES_KEYSIZE_256: >> +

Re: [RFC PATCH v2 4/9] crypto: qce: Add ablkcipher algorithms

2014-04-28 Thread Herbert Xu
On Mon, Apr 14, 2014 at 03:48:40PM +0300, Stanimir Varbanov wrote: > > + } else if (IS_DES(flags)) { > + u32 tmp[DES_EXPKEY_WORDS]; > + > + if (keylen != QCE_DES_KEY_SIZE) > + goto badkey; No need to check here since you've already set min_keysize an

Re: [RFC PATCH v2 4/9] crypto: qce: Add ablkcipher algorithms

2014-04-28 Thread Herbert Xu
On Mon, Apr 14, 2014 at 03:48:40PM +0300, Stanimir Varbanov wrote: > > + if (IS_AES(flags)) { > + switch (keylen) { > + case AES_KEYSIZE_128: > + case AES_KEYSIZE_256: > + break; > + default: > + goto badkey

[RFC PATCH v2 4/9] crypto: qce: Add ablkcipher algorithms

2014-04-14 Thread Stanimir Varbanov
Here is the implementation of AES, DES and 3DES crypto API callbacks, the crypto register alg function, the async request handler and its dma done callback function. Signed-off-by: Stanimir Varbanov --- drivers/crypto/qce/ablkcipher.c | 403 drivers/crypt