Re: [RFC PATCH v3] Fix: clocksource watchdog marks TSC unstable on guest VM

2015-09-09 Thread Shaohua Li
On Wed, Sep 09, 2015 at 11:51:43AM +0200, Thomas Gleixner wrote: > On Tue, 8 Sep 2015, Shaohua Li wrote: > > On Tue, Sep 08, 2015 at 05:08:03PM +0200, Thomas Gleixner wrote: > > > For non paravirt kernels which can read the TSC directly, we'd need a > > > way to transport that information. A simple

Re: [RFC PATCH v3] Fix: clocksource watchdog marks TSC unstable on guest VM

2015-09-09 Thread Thomas Gleixner
On Tue, 8 Sep 2015, Shaohua Li wrote: > On Tue, Sep 08, 2015 at 05:08:03PM +0200, Thomas Gleixner wrote: > > For non paravirt kernels which can read the TSC directly, we'd need a > > way to transport that information. A simple mechanism would be to > > query an emulated MSR from the watchdog which

Re: [RFC PATCH v3] Fix: clocksource watchdog marks TSC unstable on guest VM

2015-09-08 Thread Shaohua Li
On Tue, Sep 08, 2015 at 05:08:03PM +0200, Thomas Gleixner wrote: > On Tue, 8 Sep 2015, Mathieu Desnoyers wrote: > > Introduce WATCHDOG_RETRY to bound the number of retry (in the > > unlikely event of a bogus clock source for wdnow). If the > > number of retry has been reached, disable the watchdog

Re: [RFC PATCH v3] Fix: clocksource watchdog marks TSC unstable on guest VM

2015-09-08 Thread Thomas Gleixner
On Tue, 8 Sep 2015, Mathieu Desnoyers wrote: > Introduce WATCHDOG_RETRY to bound the number of retry (in the > unlikely event of a bogus clock source for wdnow). If the > number of retry has been reached, disable the watchdog timer. This does not make any sense at all. Why would the clocksource be

[RFC PATCH v3] Fix: clocksource watchdog marks TSC unstable on guest VM

2015-09-08 Thread Mathieu Desnoyers
I have been getting those warnings across a range of guest kernels in my development virtual machines. The host is a 3.13 Ubuntu kernel. The latest guest on which I reproduced this is a 4.2 kernel (akpm's tree). [ 126.902240] clocksource: timekeeping watchdog: Marking clocksource 'tsc' as unstab