Re: [RFC PATCH v3] tpm_tis: verify interrupt during init

2014-08-28 Thread Jason Gunthorpe
On Thu, Aug 28, 2014 at 12:35:16AM +, Scot Doyle wrote: > > To move it means we have to understand why you are getting timeouts: > > > > [ 33.247720] tpm_tis 00:08: tpm_transmit: tpm_send: error -62 > > [ 33.247731] tpm_tis 00:08: [Hardware Error]: TPM command timed out > > during

Re: [RFC PATCH v3] tpm_tis: verify interrupt during init

2014-08-28 Thread Jason Gunthorpe
On Thu, Aug 28, 2014 at 12:35:16AM +, Scot Doyle wrote: To move it means we have to understand why you are getting timeouts: [ 33.247720] tpm_tis 00:08: tpm_transmit: tpm_send: error -62 [ 33.247731] tpm_tis 00:08: [Hardware Error]: TPM command timed out during continue self

Re: [RFC PATCH v3] tpm_tis: verify interrupt during init

2014-08-27 Thread Scot Doyle
On Wed, 27 Aug 2014, Jason Gunthorpe wrote: > On Wed, Aug 27, 2014 at 09:32:10PM +, Scot Doyle wrote: -if (tpm_do_selftest(chip)) { -dev_err(dev, "TPM self test failed\n"); -rc = -ENODEV; -goto out_err; -} >>> >>> Move

Re: [RFC PATCH v3] tpm_tis: verify interrupt during init

2014-08-27 Thread Jason Gunthorpe
On Wed, Aug 27, 2014 at 09:32:10PM +, Scot Doyle wrote: > If suspend/resume occur before falling back to polling mode (within 30 > seconds after module load), then the machine freezes on resume because > the module is waiting on the interrupts. Okay, this is just a specific case of the

[RFC PATCH v3] tpm_tis: verify interrupt during init

2014-08-27 Thread Scot Doyle
On Wed, 27 Aug 2014, Jason Gunthorpe wrote: > On Wed, Aug 27, 2014 at 04:31:56AM +, Scot Doyle wrote: >> It doesn't enable stock SeaBIOS machines to suspend/resume before the 30 >> second interrupt timeout, unless using interrupts=0 or force=1. > > ? Can you explain that a bit more?

[RFC PATCH v3] tpm_tis: verify interrupt during init

2014-08-27 Thread Scot Doyle
On Wed, 27 Aug 2014, Jason Gunthorpe wrote: On Wed, Aug 27, 2014 at 04:31:56AM +, Scot Doyle wrote: It doesn't enable stock SeaBIOS machines to suspend/resume before the 30 second interrupt timeout, unless using interrupts=0 or force=1. ? Can you explain that a bit more? interrupts

Re: [RFC PATCH v3] tpm_tis: verify interrupt during init

2014-08-27 Thread Jason Gunthorpe
On Wed, Aug 27, 2014 at 09:32:10PM +, Scot Doyle wrote: If suspend/resume occur before falling back to polling mode (within 30 seconds after module load), then the machine freezes on resume because the module is waiting on the interrupts. Okay, this is just a specific case of the

Re: [RFC PATCH v3] tpm_tis: verify interrupt during init

2014-08-27 Thread Scot Doyle
On Wed, 27 Aug 2014, Jason Gunthorpe wrote: On Wed, Aug 27, 2014 at 09:32:10PM +, Scot Doyle wrote: -if (tpm_do_selftest(chip)) { -dev_err(dev, TPM self test failed\n); -rc = -ENODEV; -goto out_err; -} Move gettimeout too Can it be moved?