Re: [RFC PATCH v3 0/3] x86/perf/amd: AMD PMC counters and NMI latency

2019-04-03 Thread Cyrill Gorcunov
On Wed, Apr 03, 2019 at 05:27:54PM +0300, Cyrill Gorcunov wrote: > On Wed, Apr 03, 2019 at 10:15:33AM -0400, Vince Weaver wrote: > > > Mind to point me where json events should lay, I could try to convert > > > names. > > > > I was mostly joking about that. But the event lists are in the kernel

Re: [RFC PATCH v3 0/3] x86/perf/amd: AMD PMC counters and NMI latency

2019-04-03 Thread Cyrill Gorcunov
On Wed, Apr 03, 2019 at 10:15:33AM -0400, Vince Weaver wrote: > > Mind to point me where json events should lay, I could try to convert > > names. > > I was mostly joking about that. But the event lists are in the kernel > tree in > tools/perf/pmu-events/arch/x86/ > > I don't think

Re: [RFC PATCH v3 0/3] x86/perf/amd: AMD PMC counters and NMI latency

2019-04-03 Thread Vince Weaver
On Wed, 3 Apr 2019, Cyrill Gorcunov wrote: > > Shame on Intel though for not providing perf JSON files for the > > Pentium 4 event names. > > Mind to point me where json events should lay, I could try to convert > names. I was mostly joking about that. But the event lists are in the kernel

Re: [RFC PATCH v3 0/3] x86/perf/amd: AMD PMC counters and NMI latency

2019-04-02 Thread Cyrill Gorcunov
On Tue, Apr 02, 2019 at 05:13:15PM -0400, Vince Weaver wrote: > > > You know, running fuzzer on p4 might worth in anycase. As to potential > > problems to fix -- i could try find some time slot for, still quite > > limited too 'cause of many other duties :( > > > Well I fired up the Pentium 4 >

Re: [RFC PATCH v3 0/3] x86/perf/amd: AMD PMC counters and NMI latency

2019-04-02 Thread Vince Weaver
On Tue, 2 Apr 2019, Cyrill Gorcunov wrote: > You know, running fuzzer on p4 might worth in anycase. As to potential > problems to fix -- i could try find some time slot for, still quite > limited too 'cause of many other duties :( Well I fired up the Pentium 4 /dev/sda1 has gone 1457

Re: [RFC PATCH v3 0/3] x86/perf/amd: AMD PMC counters and NMI latency

2019-04-02 Thread Vince Weaver
On Tue, 2 Apr 2019, Cyrill Gorcunov wrote: > On Tue, Apr 02, 2019 at 03:03:02PM +0200, Peter Zijlstra wrote: > > I have vague memories of the P4 thing crashing with Vince's perf_fuzzer, > > but maybe I'm wrong. > > No, you're correct. p4 was crashing many times before we manage to make > it

Re: [RFC PATCH v3 0/3] x86/perf/amd: AMD PMC counters and NMI latency

2019-04-02 Thread Cyrill Gorcunov
On Tue, Apr 02, 2019 at 10:53:38AM -0400, Vince Weaver wrote: > On Tue, 2 Apr 2019, Cyrill Gorcunov wrote: > > On Tue, Apr 02, 2019 at 03:03:02PM +0200, Peter Zijlstra wrote: > > > I have vague memories of the P4 thing crashing with Vince's perf_fuzzer, > > > but maybe I'm wrong. > > > > No,

Re: [RFC PATCH v3 0/3] x86/perf/amd: AMD PMC counters and NMI latency

2019-04-02 Thread Cyrill Gorcunov
On Tue, Apr 02, 2019 at 03:03:02PM +0200, Peter Zijlstra wrote: > On Mon, Apr 01, 2019 at 09:46:33PM +, Lendacky, Thomas wrote: > > This patch series addresses issues with increased NMI latency in newer > > AMD processors that can result in unknown NMI messages when PMC counters > > are

Re: [RFC PATCH v3 0/3] x86/perf/amd: AMD PMC counters and NMI latency

2019-04-02 Thread Lendacky, Thomas
On 4/2/19 8:03 AM, Peter Zijlstra wrote: > On Mon, Apr 01, 2019 at 09:46:33PM +, Lendacky, Thomas wrote: >> This patch series addresses issues with increased NMI latency in newer >> AMD processors that can result in unknown NMI messages when PMC counters >> are active. >> >> The following

Re: [RFC PATCH v3 0/3] x86/perf/amd: AMD PMC counters and NMI latency

2019-04-02 Thread Peter Zijlstra
On Mon, Apr 01, 2019 at 09:46:33PM +, Lendacky, Thomas wrote: > This patch series addresses issues with increased NMI latency in newer > AMD processors that can result in unknown NMI messages when PMC counters > are active. > > The following fixes are included in this series: > > - Resolve a

[RFC PATCH v3 0/3] x86/perf/amd: AMD PMC counters and NMI latency

2019-04-01 Thread Lendacky, Thomas
This patch series addresses issues with increased NMI latency in newer AMD processors that can result in unknown NMI messages when PMC counters are active. The following fixes are included in this series: - Resolve a race condition when disabling an overflowed PMC counter, specifically when