Re: [RFC PATCH v3 09/10] sched/fair: Select an energy-efficient CPU on task wake-up

2018-06-19 Thread Pavan Kondeti
On Tue, Jun 19, 2018 at 08:57:23AM +0100, Quentin Perret wrote: > Hi Pavan, > > On Tuesday 19 Jun 2018 at 10:36:01 (+0530), Pavan Kondeti wrote: > > On Mon, May 21, 2018 at 03:25:04PM +0100, Quentin Perret wrote: > > > > > > > > > + if (cpumask_test_cpu(prev_cpu, >cpus_allowed)) > > > +

Re: [RFC PATCH v3 09/10] sched/fair: Select an energy-efficient CPU on task wake-up

2018-06-19 Thread Pavan Kondeti
On Tue, Jun 19, 2018 at 08:57:23AM +0100, Quentin Perret wrote: > Hi Pavan, > > On Tuesday 19 Jun 2018 at 10:36:01 (+0530), Pavan Kondeti wrote: > > On Mon, May 21, 2018 at 03:25:04PM +0100, Quentin Perret wrote: > > > > > > > > > + if (cpumask_test_cpu(prev_cpu, >cpus_allowed)) > > > +

Re: [RFC PATCH v3 09/10] sched/fair: Select an energy-efficient CPU on task wake-up

2018-06-19 Thread Quentin Perret
Hi Pavan, On Tuesday 19 Jun 2018 at 10:36:01 (+0530), Pavan Kondeti wrote: > On Mon, May 21, 2018 at 03:25:04PM +0100, Quentin Perret wrote: > > > > > + if (cpumask_test_cpu(prev_cpu, >cpus_allowed)) > > + prev_energy = best_energy = compute_energy(p, prev_cpu); > > + else > > +

Re: [RFC PATCH v3 09/10] sched/fair: Select an energy-efficient CPU on task wake-up

2018-06-19 Thread Quentin Perret
Hi Pavan, On Tuesday 19 Jun 2018 at 10:36:01 (+0530), Pavan Kondeti wrote: > On Mon, May 21, 2018 at 03:25:04PM +0100, Quentin Perret wrote: > > > > > + if (cpumask_test_cpu(prev_cpu, >cpus_allowed)) > > + prev_energy = best_energy = compute_energy(p, prev_cpu); > > + else > > +

Re: [RFC PATCH v3 09/10] sched/fair: Select an energy-efficient CPU on task wake-up

2018-06-18 Thread Pavan Kondeti
On Mon, May 21, 2018 at 03:25:04PM +0100, Quentin Perret wrote: > + if (cpumask_test_cpu(prev_cpu, >cpus_allowed)) > + prev_energy = best_energy = compute_energy(p, prev_cpu); > + else > + prev_energy = best_energy = ULONG_MAX; > + > +

Re: [RFC PATCH v3 09/10] sched/fair: Select an energy-efficient CPU on task wake-up

2018-06-18 Thread Pavan Kondeti
On Mon, May 21, 2018 at 03:25:04PM +0100, Quentin Perret wrote: > + if (cpumask_test_cpu(prev_cpu, >cpus_allowed)) > + prev_energy = best_energy = compute_energy(p, prev_cpu); > + else > + prev_energy = best_energy = ULONG_MAX; > + > +

Re: [RFC PATCH v3 09/10] sched/fair: Select an energy-efficient CPU on task wake-up

2018-06-08 Thread Quentin Perret
On Friday 08 Jun 2018 at 13:59:28 (+0200), Juri Lelli wrote: > On 08/06/18 12:19, Quentin Perret wrote: > > On Friday 08 Jun 2018 at 12:24:46 (+0200), Juri Lelli wrote: > > > Hi, > > > > > > On 21/05/18 15:25, Quentin Perret wrote: > > > > > > [...] > > > > > > > +static int

Re: [RFC PATCH v3 09/10] sched/fair: Select an energy-efficient CPU on task wake-up

2018-06-08 Thread Quentin Perret
On Friday 08 Jun 2018 at 13:59:28 (+0200), Juri Lelli wrote: > On 08/06/18 12:19, Quentin Perret wrote: > > On Friday 08 Jun 2018 at 12:24:46 (+0200), Juri Lelli wrote: > > > Hi, > > > > > > On 21/05/18 15:25, Quentin Perret wrote: > > > > > > [...] > > > > > > > +static int

Re: [RFC PATCH v3 09/10] sched/fair: Select an energy-efficient CPU on task wake-up

2018-06-08 Thread Juri Lelli
On 08/06/18 12:19, Quentin Perret wrote: > On Friday 08 Jun 2018 at 12:24:46 (+0200), Juri Lelli wrote: > > Hi, > > > > On 21/05/18 15:25, Quentin Perret wrote: > > > > [...] > > > > > +static int find_energy_efficient_cpu(struct task_struct *p, int prev_cpu) > > > +{ > > > + unsigned long

Re: [RFC PATCH v3 09/10] sched/fair: Select an energy-efficient CPU on task wake-up

2018-06-08 Thread Juri Lelli
On 08/06/18 12:19, Quentin Perret wrote: > On Friday 08 Jun 2018 at 12:24:46 (+0200), Juri Lelli wrote: > > Hi, > > > > On 21/05/18 15:25, Quentin Perret wrote: > > > > [...] > > > > > +static int find_energy_efficient_cpu(struct task_struct *p, int prev_cpu) > > > +{ > > > + unsigned long

Re: [RFC PATCH v3 09/10] sched/fair: Select an energy-efficient CPU on task wake-up

2018-06-08 Thread Quentin Perret
On Friday 08 Jun 2018 at 12:24:46 (+0200), Juri Lelli wrote: > Hi, > > On 21/05/18 15:25, Quentin Perret wrote: > > [...] > > > +static int find_energy_efficient_cpu(struct task_struct *p, int prev_cpu) > > +{ > > + unsigned long cur_energy, prev_energy, best_energy, cpu_cap, task_util; > > +

Re: [RFC PATCH v3 09/10] sched/fair: Select an energy-efficient CPU on task wake-up

2018-06-08 Thread Quentin Perret
On Friday 08 Jun 2018 at 12:24:46 (+0200), Juri Lelli wrote: > Hi, > > On 21/05/18 15:25, Quentin Perret wrote: > > [...] > > > +static int find_energy_efficient_cpu(struct task_struct *p, int prev_cpu) > > +{ > > + unsigned long cur_energy, prev_energy, best_energy, cpu_cap, task_util; > > +

Re: [RFC PATCH v3 09/10] sched/fair: Select an energy-efficient CPU on task wake-up

2018-06-08 Thread Juri Lelli
Hi, On 21/05/18 15:25, Quentin Perret wrote: [...] > +static int find_energy_efficient_cpu(struct task_struct *p, int prev_cpu) > +{ > + unsigned long cur_energy, prev_energy, best_energy, cpu_cap, task_util; > + int cpu, best_energy_cpu = prev_cpu; > + struct sched_energy_fd *sfd;

Re: [RFC PATCH v3 09/10] sched/fair: Select an energy-efficient CPU on task wake-up

2018-06-08 Thread Juri Lelli
Hi, On 21/05/18 15:25, Quentin Perret wrote: [...] > +static int find_energy_efficient_cpu(struct task_struct *p, int prev_cpu) > +{ > + unsigned long cur_energy, prev_energy, best_energy, cpu_cap, task_util; > + int cpu, best_energy_cpu = prev_cpu; > + struct sched_energy_fd *sfd;

[RFC PATCH v3 09/10] sched/fair: Select an energy-efficient CPU on task wake-up

2018-05-21 Thread Quentin Perret
If an energy model is available, and if the system isn't overutilized, waking tasks are re-routed into a new energy-aware placement algorithm. The selection of an energy-efficient CPU for a task is achieved by estimating the impact on system-level active energy resulting from the placement of the

[RFC PATCH v3 09/10] sched/fair: Select an energy-efficient CPU on task wake-up

2018-05-21 Thread Quentin Perret
If an energy model is available, and if the system isn't overutilized, waking tasks are re-routed into a new energy-aware placement algorithm. The selection of an energy-efficient CPU for a task is achieved by estimating the impact on system-level active energy resulting from the placement of the