Re: [RFC PATCH v3 2/4] x86: Add the support of ACRN guest

2019-04-12 Thread Borislav Petkov
On Fri, Apr 12, 2019 at 08:36:34AM +0800, Zhao, Yakui wrote: > So we will leverage the X86_FEATURE_X2APIC bit from CPUID to indicate > whether the x2apic is supported in linux guest when ACRN hypervisor is > detected. > Is this fine to you? Yes, put that more precise info in the comment pls.

Re: [RFC PATCH v3 2/4] x86: Add the support of ACRN guest

2019-04-11 Thread Zhao, Yakui
On 2019年04月11日 21:49, Borislav Petkov wrote: On Wed, Apr 10, 2019 at 05:15:48PM +0800, Zhao, Yakui wrote: Currently the x2apic is not enabled in the first step. Next step it needs to check the cpu info reported by ACRN hypervisor to determine whether the x2apic should be supported. What

Re: [RFC PATCH v3 2/4] x86: Add the support of ACRN guest

2019-04-11 Thread Borislav Petkov
On Wed, Apr 10, 2019 at 05:15:48PM +0800, Zhao, Yakui wrote: > Currently the x2apic is not enabled in the first step. > Next step it needs to check the cpu info reported by ACRN hypervisor to > determine whether the x2apic should be supported. What "cpu info"? CPUID or something ACRN-specific?

Re: [RFC PATCH v3 2/4] x86: Add the support of ACRN guest

2019-04-10 Thread Zhao, Yakui
On 2019年04月08日 22:39, Borislav Petkov wrote: On Mon, Apr 08, 2019 at 04:12:09PM +0800, Zhao Yakui wrote: ACRN is an open-source hypervisor maintained by Linuxfoundation. I think tglx wanted to say "by the Linux Foundation" here. Sure. It will be fixed. This is to add the Linux guest

Re: [RFC PATCH v3 2/4] x86: Add the support of ACRN guest

2019-04-08 Thread Borislav Petkov
On Mon, Apr 08, 2019 at 04:12:09PM +0800, Zhao Yakui wrote: > ACRN is an open-source hypervisor maintained by Linuxfoundation. I think tglx wanted to say "by the Linux Foundation" here. > This is to add the Linux guest support on acrn-hypervisor. I think you were told already: "Please do not

[RFC PATCH v3 2/4] x86: Add the support of ACRN guest

2019-04-08 Thread Zhao Yakui
ACRN is an open-source hypervisor maintained by Linuxfoundation. This is to add the Linux guest support on acrn-hypervisor. Add x86_hyper_acrn into supported hypervisors array, which enables Linux ACRN guest running on ACRN hypervisor. It is restricted to X86_64. Co-developed-by: Jason Chen CJ