Re: [RFC PATCH v3 3/4] x86: Use HYPERVISOR_CALLBACK_VECTOR for acrn_guest upcall vector

2019-04-12 Thread Borislav Petkov
On Fri, Apr 12, 2019 at 09:00:10AM +0800, Zhao, Yakui wrote: > This is not a problem. > I take a look at the header file of mshyperv.h and xen/events.h. > It seems that they have no such extra conditional definition. > To follow the same style, I will remove it. Yes, the less ifdeffery the

Re: [RFC PATCH v3 3/4] x86: Use HYPERVISOR_CALLBACK_VECTOR for acrn_guest upcall vector

2019-04-11 Thread Zhao, Yakui
On 2019年04月11日 21:55, Borislav Petkov wrote: On Wed, Apr 10, 2019 at 03:57:08PM +0800, Zhao, Yakui wrote: It is used to avoid that one function declaration has no definition when asm/acrnhyper.h is included and ACRN_GUEST is not enabled. And that is a problem because...? This is not a

Re: [RFC PATCH v3 3/4] x86: Use HYPERVISOR_CALLBACK_VECTOR for acrn_guest upcall vector

2019-04-11 Thread Borislav Petkov
On Wed, Apr 10, 2019 at 03:57:08PM +0800, Zhao, Yakui wrote: > It is used to avoid that one function declaration has no definition > when asm/acrnhyper.h is included and ACRN_GUEST is not enabled. And that is a problem because...? > Do you have any suggestion about the header order? > > > >

Re: [RFC PATCH v3 3/4] x86: Use HYPERVISOR_CALLBACK_VECTOR for acrn_guest upcall vector

2019-04-10 Thread Zhao, Yakui
On 2019年04月08日 23:00, Borislav Petkov wrote: You can prefix your subject now like this: x86/acrn: Use ... Thanks for suggestion. It will be updated in next version. On Mon, Apr 08, 2019 at 04:12:10PM +0800, Zhao Yakui wrote: Linux kernel uses the HYPERVISOR_CALLBACK_VECTOR for

Re: [RFC PATCH v3 3/4] x86: Use HYPERVISOR_CALLBACK_VECTOR for acrn_guest upcall vector

2019-04-08 Thread Borislav Petkov
You can prefix your subject now like this: x86/acrn: Use ... On Mon, Apr 08, 2019 at 04:12:10PM +0800, Zhao Yakui wrote: > Linux kernel uses the HYPERVISOR_CALLBACK_VECTOR for hypervisor upcall > vector. And it is already used for Xen and HyperV. > After Acrn hypervisor is detected, it will also

[RFC PATCH v3 3/4] x86: Use HYPERVISOR_CALLBACK_VECTOR for acrn_guest upcall vector

2019-04-08 Thread Zhao Yakui
Linux kernel uses the HYPERVISOR_CALLBACK_VECTOR for hypervisor upcall vector. And it is already used for Xen and HyperV. After Acrn hypervisor is detected, it will also use this defined vector to notify kernel. Co-developed-by: Jason Chen CJ Signed-off-by: Jason Chen CJ Signed-off-by: Zhao