Re: [RFC PATCH v4] Use kernfs_break_active_protection() for device online store callbacks

2014-04-18 Thread Li Zhong
On Thu, 2014-04-17 at 11:17 -0400, Tejun Heo wrote: > Hello, > > On Thu, Apr 17, 2014 at 02:50:44PM +0800, Li Zhong wrote: > > This patch tries to solve the device hot remove locking issues in a > > different way from commit 5e33bc41, as kernfs already has a mechanism > > to break active protecti

Re: [RFC PATCH v4] Use kernfs_break_active_protection() for device online store callbacks

2014-04-17 Thread Tejun Heo
Hello, On Thu, Apr 17, 2014 at 02:50:44PM +0800, Li Zhong wrote: > This patch tries to solve the device hot remove locking issues in a > different way from commit 5e33bc41, as kernfs already has a mechanism > to break active protection. > > The problem here is the order of s_active, and series

[RFC PATCH v4] Use kernfs_break_active_protection() for device online store callbacks

2014-04-16 Thread Li Zhong
This patch tries to solve the device hot remove locking issues in a different way from commit 5e33bc41, as kernfs already has a mechanism to break active protection. The problem here is the order of s_active, and series of hotplug related lock. This patch takes s_active out of the lock depende