Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-28 Thread Daniel Jordan
On Tue, Nov 27, 2018 at 08:50:08PM +0100, Pavel Machek wrote: > Hi! Hi, Pavel. > > + > > +ktask: parallelize CPU-intensive kernel work > > + > > + > > +:Date: November, 2018 > > +:Author: Daniel Jordan > >

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-28 Thread Daniel Jordan
On Tue, Nov 27, 2018 at 08:50:08PM +0100, Pavel Machek wrote: > Hi! Hi, Pavel. > > + > > +ktask: parallelize CPU-intensive kernel work > > + > > + > > +:Date: November, 2018 > > +:Author: Daniel Jordan > >

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-27 Thread Pavel Machek
Hi! > Motivates and explains the ktask API for kernel clients. > > Signed-off-by: Daniel Jordan > --- > Documentation/core-api/index.rst | 1 + > Documentation/core-api/ktask.rst | 213 +++ > 2 files changed, 214 insertions(+) > create mode 100644

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-27 Thread Pavel Machek
Hi! > Motivates and explains the ktask API for kernel clients. > > Signed-off-by: Daniel Jordan > --- > Documentation/core-api/index.rst | 1 + > Documentation/core-api/ktask.rst | 213 +++ > 2 files changed, 214 insertions(+) > create mode 100644

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-08 Thread Jonathan Corbet
On Thu, 8 Nov 2018 11:15:53 -0800 Daniel Jordan wrote: > > - You have kerneldoc comments for the API functions, but you don't pull > > those into the documentation itself. Adding some kernel-doc directives > > could help to fill things out nicely with little effort. > > I thought this

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-08 Thread Jonathan Corbet
On Thu, 8 Nov 2018 11:15:53 -0800 Daniel Jordan wrote: > > - You have kerneldoc comments for the API functions, but you don't pull > > those into the documentation itself. Adding some kernel-doc directives > > could help to fill things out nicely with little effort. > > I thought this

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-08 Thread Daniel Jordan
On Thu, Nov 08, 2018 at 10:26:38AM -0700, Jonathan Corbet wrote: > On Mon, 5 Nov 2018 11:55:46 -0500 > Daniel Jordan wrote: > > > Motivates and explains the ktask API for kernel clients. > > A couple of quick thoughts: > > - Agree with Peter on the use of "task"; something like "job" would be

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-08 Thread Daniel Jordan
On Thu, Nov 08, 2018 at 10:26:38AM -0700, Jonathan Corbet wrote: > On Mon, 5 Nov 2018 11:55:46 -0500 > Daniel Jordan wrote: > > > Motivates and explains the ktask API for kernel clients. > > A couple of quick thoughts: > > - Agree with Peter on the use of "task"; something like "job" would be

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-08 Thread Jonathan Corbet
On Mon, 5 Nov 2018 11:55:46 -0500 Daniel Jordan wrote: > Motivates and explains the ktask API for kernel clients. A couple of quick thoughts: - Agree with Peter on the use of "task"; something like "job" would be far less likely to create confusion. Maybe you could even call it a "batch

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-08 Thread Jonathan Corbet
On Mon, 5 Nov 2018 11:55:46 -0500 Daniel Jordan wrote: > Motivates and explains the ktask API for kernel clients. A couple of quick thoughts: - Agree with Peter on the use of "task"; something like "job" would be far less likely to create confusion. Maybe you could even call it a "batch

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-07 Thread Daniel Jordan
On Wed, Nov 07, 2018 at 11:35:54AM +0100, Peter Zijlstra wrote: > On Tue, Nov 06, 2018 at 12:34:11PM -0800, Daniel Jordan wrote: > > On Tue, Nov 06, 2018 at 09:49:11AM +0100, Peter Zijlstra wrote: > > > On Mon, Nov 05, 2018 at 11:55:46AM -0500, Daniel Jordan wrote: > > > > +Concept > > > >

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-07 Thread Daniel Jordan
On Wed, Nov 07, 2018 at 11:35:54AM +0100, Peter Zijlstra wrote: > On Tue, Nov 06, 2018 at 12:34:11PM -0800, Daniel Jordan wrote: > > On Tue, Nov 06, 2018 at 09:49:11AM +0100, Peter Zijlstra wrote: > > > On Mon, Nov 05, 2018 at 11:55:46AM -0500, Daniel Jordan wrote: > > > > +Concept > > > >

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-07 Thread Daniel Jordan
On Wed, Nov 07, 2018 at 11:27:52AM +0100, Peter Zijlstra wrote: > On Tue, Nov 06, 2018 at 08:51:54PM +, Jason Gunthorpe wrote: > > On Tue, Nov 06, 2018 at 12:34:11PM -0800, Daniel Jordan wrote: > > > > > > What isn't clear is if this calling thread is waiting or not. Only do > > > > this

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-07 Thread Daniel Jordan
On Wed, Nov 07, 2018 at 11:27:52AM +0100, Peter Zijlstra wrote: > On Tue, Nov 06, 2018 at 08:51:54PM +, Jason Gunthorpe wrote: > > On Tue, Nov 06, 2018 at 12:34:11PM -0800, Daniel Jordan wrote: > > > > > > What isn't clear is if this calling thread is waiting or not. Only do > > > > this

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-07 Thread Peter Zijlstra
On Tue, Nov 06, 2018 at 12:34:11PM -0800, Daniel Jordan wrote: > On Tue, Nov 06, 2018 at 09:49:11AM +0100, Peter Zijlstra wrote: > > On Mon, Nov 05, 2018 at 11:55:46AM -0500, Daniel Jordan wrote: > > > +Concept > > > +=== > > > + > > > +ktask is built on unbound workqueues to take advantage of

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-07 Thread Peter Zijlstra
On Tue, Nov 06, 2018 at 12:34:11PM -0800, Daniel Jordan wrote: > On Tue, Nov 06, 2018 at 09:49:11AM +0100, Peter Zijlstra wrote: > > On Mon, Nov 05, 2018 at 11:55:46AM -0500, Daniel Jordan wrote: > > > +Concept > > > +=== > > > + > > > +ktask is built on unbound workqueues to take advantage of

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-07 Thread Peter Zijlstra
On Tue, Nov 06, 2018 at 08:51:54PM +, Jason Gunthorpe wrote: > On Tue, Nov 06, 2018 at 12:34:11PM -0800, Daniel Jordan wrote: > > > > What isn't clear is if this calling thread is waiting or not. Only do > > > this inheritance trick if it is actually waiting on the work. If it is > > > not,

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-07 Thread Peter Zijlstra
On Tue, Nov 06, 2018 at 08:51:54PM +, Jason Gunthorpe wrote: > On Tue, Nov 06, 2018 at 12:34:11PM -0800, Daniel Jordan wrote: > > > > What isn't clear is if this calling thread is waiting or not. Only do > > > this inheritance trick if it is actually waiting on the work. If it is > > > not,

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-06 Thread Jason Gunthorpe
On Tue, Nov 06, 2018 at 12:34:11PM -0800, Daniel Jordan wrote: > > What isn't clear is if this calling thread is waiting or not. Only do > > this inheritance trick if it is actually waiting on the work. If it is > > not, nobody cares. > > The calling thread waits. Even if it didn't though, the

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-06 Thread Jason Gunthorpe
On Tue, Nov 06, 2018 at 12:34:11PM -0800, Daniel Jordan wrote: > > What isn't clear is if this calling thread is waiting or not. Only do > > this inheritance trick if it is actually waiting on the work. If it is > > not, nobody cares. > > The calling thread waits. Even if it didn't though, the

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-06 Thread Daniel Jordan
On Tue, Nov 06, 2018 at 09:49:11AM +0100, Peter Zijlstra wrote: > On Mon, Nov 05, 2018 at 11:55:46AM -0500, Daniel Jordan wrote: > > +Concept > > +=== > > + > > +ktask is built on unbound workqueues to take advantage of the thread > > management > > +facilities it provides: creation,

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-06 Thread Daniel Jordan
On Tue, Nov 06, 2018 at 09:49:11AM +0100, Peter Zijlstra wrote: > On Mon, Nov 05, 2018 at 11:55:46AM -0500, Daniel Jordan wrote: > > +Concept > > +=== > > + > > +ktask is built on unbound workqueues to take advantage of the thread > > management > > +facilities it provides: creation,

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-06 Thread Peter Zijlstra
On Mon, Nov 05, 2018 at 11:55:46AM -0500, Daniel Jordan wrote: > +Concept > +=== > + > +ktask is built on unbound workqueues to take advantage of the thread > management > +facilities it provides: creation, destruction, flushing, priority setting, > and > +NUMA affinity. > + > +A little

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-06 Thread Peter Zijlstra
On Mon, Nov 05, 2018 at 11:55:46AM -0500, Daniel Jordan wrote: > +Concept > +=== > + > +ktask is built on unbound workqueues to take advantage of the thread > management > +facilities it provides: creation, destruction, flushing, priority setting, > and > +NUMA affinity. > + > +A little

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-05 Thread Daniel Jordan
On Mon, Nov 05, 2018 at 01:19:50PM -0800, Randy Dunlap wrote: > On 11/5/18 8:55 AM, Daniel Jordan wrote: > > Hi, > > > +Resource Limits > > +=== > > + > > +ktask has resource limits on the number of work items it sends to > > workqueue. > >

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-05 Thread Daniel Jordan
On Mon, Nov 05, 2018 at 01:19:50PM -0800, Randy Dunlap wrote: > On 11/5/18 8:55 AM, Daniel Jordan wrote: > > Hi, > > > +Resource Limits > > +=== > > + > > +ktask has resource limits on the number of work items it sends to > > workqueue. > >

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-05 Thread Randy Dunlap
On 11/5/18 8:55 AM, Daniel Jordan wrote: > Motivates and explains the ktask API for kernel clients. > > Signed-off-by: Daniel Jordan > --- > Documentation/core-api/index.rst | 1 + > Documentation/core-api/ktask.rst | 213 +++ > 2 files changed, 214 insertions(+) >

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-05 Thread Randy Dunlap
On 11/5/18 8:55 AM, Daniel Jordan wrote: > Motivates and explains the ktask API for kernel clients. > > Signed-off-by: Daniel Jordan > --- > Documentation/core-api/index.rst | 1 + > Documentation/core-api/ktask.rst | 213 +++ > 2 files changed, 214 insertions(+) >

[RFC PATCH v4 01/13] ktask: add documentation

2018-11-05 Thread Daniel Jordan
Motivates and explains the ktask API for kernel clients. Signed-off-by: Daniel Jordan --- Documentation/core-api/index.rst | 1 + Documentation/core-api/ktask.rst | 213 +++ 2 files changed, 214 insertions(+) create mode 100644 Documentation/core-api/ktask.rst

[RFC PATCH v4 01/13] ktask: add documentation

2018-11-05 Thread Daniel Jordan
Motivates and explains the ktask API for kernel clients. Signed-off-by: Daniel Jordan --- Documentation/core-api/index.rst | 1 + Documentation/core-api/ktask.rst | 213 +++ 2 files changed, 214 insertions(+) create mode 100644 Documentation/core-api/ktask.rst