Re: [RFC PATCH v4 3/5] PCI: Check platform specific ECAM quirks

2016-07-25 Thread Mark Salter
On Tue, 2016-06-28 at 09:54 +0200, Tomasz Nowicki wrote: > Some platforms may not be fully compliant with generic set of PCI config > accessors. For these cases we implement the way to overwrite accessors > set. Algorithm traverses available quirk list (static array), > matches against and > retur

Re: [RFC PATCH v4 3/5] PCI: Check platform specific ECAM quirks

2016-07-22 Thread Robert Richter
On 22.07.16 14:00:42, Ard Biesheuvel wrote: > On 22 July 2016 at 13:38, Robert Richter wrote: > > And, we should support some sort of MCFG_OEM_REVISION_ANY to move the > > rev handling optional to pci_cfg_fixup::init(). > > > > xxx_ANY implies 'wildcard', which we don't want in this code. The se

Re: [RFC PATCH v4 3/5] PCI: Check platform specific ECAM quirks

2016-07-22 Thread Ard Biesheuvel
On 22 July 2016 at 13:38, Robert Richter wrote: > On 29.06.16 15:56:50, Ard Biesheuvel wrote: >> On 29 June 2016 at 15:34, Christopher Covington wrote: >> > Hi Tomasz, >> > >> > On 06/29/2016 06:48 AM, Tomasz Nowicki wrote: >> >> On 28.06.2016 18:12, Duc Dang wrote: >> >>> On Tue, Jun 28, 2016 at

Re: [RFC PATCH v4 3/5] PCI: Check platform specific ECAM quirks

2016-07-22 Thread Robert Richter
On 29.06.16 15:56:50, Ard Biesheuvel wrote: > On 29 June 2016 at 15:34, Christopher Covington wrote: > > Hi Tomasz, > > > > On 06/29/2016 06:48 AM, Tomasz Nowicki wrote: > >> On 28.06.2016 18:12, Duc Dang wrote: > >>> On Tue, Jun 28, 2016 at 6:04 AM, Christopher Covington > >>> wrote: > Hi T

Re: [RFC PATCH v4 3/5] PCI: Check platform specific ECAM quirks

2016-07-04 Thread Duc Dang
On Tue, Jun 28, 2016 at 6:04 AM, Christopher Covington wrote: > Hi Tomasz, > > On 06/28/2016 03:54 AM, Tomasz Nowicki wrote: > >> diff --git a/drivers/pci/host/mcfg-quirks.c b/drivers/pci/host/mcfg-quirks.c >> new file mode 100644 >> index 000..fb2b184 >> --- /dev/null >> +++ b/drivers/pci/hos

Re: [RFC PATCH v4 3/5] PCI: Check platform specific ECAM quirks

2016-06-29 Thread Jeffrey Hugo
On 6/29/2016 7:52 AM, Tomasz Nowicki wrote: On 29.06.2016 15:34, Christopher Covington wrote: I'm confused by this statement. OEMID is defined as 6 bytes long and OEM Table ID as 8 bytes long in the ACPI specification. As far as I can tell, if your string isn't exactly that long, padding up to t

Re: [RFC PATCH v4 3/5] PCI: Check platform specific ECAM quirks

2016-06-29 Thread Tomasz Nowicki
On 29.06.2016 15:34, Christopher Covington wrote: I'm confused by this statement. OEMID is defined as 6 bytes long and OEM Table ID as 8 bytes long in the ACPI specification. As far as I can tell, if your string isn't exactly that long, padding up to that length is required. Well, I cannot find

Re: [RFC PATCH v4 3/5] PCI: Check platform specific ECAM quirks

2016-06-29 Thread Ard Biesheuvel
On 29 June 2016 at 15:52, Tomasz Nowicki wrote: > On 29.06.2016 15:34, Christopher Covington wrote: >> >> I'm confused by this statement. OEMID is defined as 6 bytes long and OEM >> Table ID as 8 bytes long in the ACPI specification. As far as I can >> tell, if your string isn't exactly that long,

Re: [RFC PATCH v4 3/5] PCI: Check platform specific ECAM quirks

2016-06-29 Thread Ard Biesheuvel
On 29 June 2016 at 15:34, Christopher Covington wrote: > Hi Tomasz, > > On 06/29/2016 06:48 AM, Tomasz Nowicki wrote: >> On 28.06.2016 18:12, Duc Dang wrote: >>> On Tue, Jun 28, 2016 at 6:04 AM, Christopher Covington >>> wrote: Hi Tomasz, > Ard's comments on v3 included: "...

Re: [RFC PATCH v4 3/5] PCI: Check platform specific ECAM quirks

2016-06-29 Thread Christopher Covington
Hi Tomasz, On 06/29/2016 06:48 AM, Tomasz Nowicki wrote: > On 28.06.2016 18:12, Duc Dang wrote: >> On Tue, Jun 28, 2016 at 6:04 AM, Christopher Covington >> wrote: >>> Hi Tomasz, >>> Ard's comments on v3 included: >>> >>> "... exact OEM table/rev id matches ..." >>> "... substring match ... out

Re: [RFC PATCH v4 3/5] PCI: Check platform specific ECAM quirks

2016-06-29 Thread Tomasz Nowicki
On 28.06.2016 18:12, Duc Dang wrote: On Tue, Jun 28, 2016 at 6:04 AM, Christopher Covington wrote: Hi Tomasz, On 06/28/2016 03:54 AM, Tomasz Nowicki wrote: diff --git a/drivers/pci/host/mcfg-quirks.c b/drivers/pci/host/mcfg-quirks.c new file mode 100644 index 000..fb2b184 --- /dev/null +

Re: [RFC PATCH v4 3/5] PCI: Check platform specific ECAM quirks

2016-06-28 Thread Duc Dang
On Tue, Jun 28, 2016 at 6:04 AM, Christopher Covington wrote: > Hi Tomasz, > > On 06/28/2016 03:54 AM, Tomasz Nowicki wrote: > >> diff --git a/drivers/pci/host/mcfg-quirks.c b/drivers/pci/host/mcfg-quirks.c >> new file mode 100644 >> index 000..fb2b184 >> --- /dev/null >> +++ b/drivers/pci/hos

Re: [RFC PATCH v4 3/5] PCI: Check platform specific ECAM quirks

2016-06-28 Thread Christopher Covington
Hi Tomasz, On 06/28/2016 03:54 AM, Tomasz Nowicki wrote: > diff --git a/drivers/pci/host/mcfg-quirks.c b/drivers/pci/host/mcfg-quirks.c > new file mode 100644 > index 000..fb2b184 > --- /dev/null > +++ b/drivers/pci/host/mcfg-quirks.c > @@ -0,0 +1,88 @@ > +static bool pci_mcfg_fixup_match(st

[RFC PATCH v4 3/5] PCI: Check platform specific ECAM quirks

2016-06-28 Thread Tomasz Nowicki
Some platforms may not be fully compliant with generic set of PCI config accessors. For these cases we implement the way to overwrite accessors set. Algorithm traverses available quirk list (static array), matches against and returns pci_config_window structure with fancy PCI config ops. oem_id, o