Re: [RFC PATCH v4 5/6] uretprobes: invoke return probe handlers

2013-03-05 Thread Anton Arapov
On Mon, Mar 04, 2013 at 05:51:20PM +0100, Oleg Nesterov wrote: > On 03/04, Anton Arapov wrote: > > > > +static void handle_uretprobe(struct xol_area *area, struct pt_regs *regs) > > +{ > > + struct hlist_head *head; > > + struct hlist_node *tmp; > > + struct return_uprobe_i *ri; > > + struc

Re: [RFC PATCH v4 5/6] uretprobes: invoke return probe handlers

2013-03-05 Thread Anton Arapov
On Tue, Mar 05, 2013 at 12:33:26PM +0530, Ananth N Mavinakayanahalli wrote: > On Mon, Mar 04, 2013 at 03:38:12PM +0100, Anton Arapov wrote: > > > > diff --git a/arch/x86/include/asm/uprobes.h b/arch/x86/include/asm/uprobes.h > > index c353555..fa9d9de 100644 > > --- a/arch/x86/include/asm/uprobes.

Re: [RFC PATCH v4 5/6] uretprobes: invoke return probe handlers

2013-03-04 Thread Ananth N Mavinakayanahalli
On Mon, Mar 04, 2013 at 03:38:12PM +0100, Anton Arapov wrote: > > diff --git a/arch/x86/include/asm/uprobes.h b/arch/x86/include/asm/uprobes.h > index c353555..fa9d9de 100644 > --- a/arch/x86/include/asm/uprobes.h > +++ b/arch/x86/include/asm/uprobes.h > @@ -56,4 +56,9 @@ extern bool arch_uprobe_x

Re: [RFC PATCH v4 5/6] uretprobes: invoke return probe handlers

2013-03-04 Thread Oleg Nesterov
On 03/04, Anton Arapov wrote: > > +static void handle_uretprobe(struct xol_area *area, struct pt_regs *regs) > +{ > + struct hlist_head *head; > + struct hlist_node *tmp; > + struct return_uprobe_i *ri; > + struct uprobe_task *utask; > + unsigned long orig_ret_vaddr; > + > +

[RFC PATCH v4 5/6] uretprobes: invoke return probe handlers

2013-03-04 Thread Anton Arapov
Uretprobe handlers are invoked when the trampoline is hit, on completion the trampoline is replaced with the saved return address and the uretprobe instance deleted. v4: - check, whether utask is not NULL in handle_uretprobe() ? do we want a printk() for this case? - get rid of area->rp_tra